diff mbox series

[meta-ti,scarthgap/master,2/2] conf: machine: omap-a15.inc: include ipu1 firmware in the boot partition

Message ID 20241209101330.1893700-3-a-limaye@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series omap-a15: Add | expand

Commit Message

Aniket Limaye Dec. 9, 2024, 10:10 a.m. UTC
Early Boot of remote processors is supported at the SPL stage of the
bootloader. Currently, SPL looks for the remoteproc firmwares in the
boot partition.

Therefore, add the rproc firmware to the boot partition of wic images.

Signed-off-by: Aniket Limaye <a-limaye@ti.com>
---
 meta-ti-bsp/conf/machine/include/omap-a15.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Matthias Schiffer Jan. 28, 2025, 1:11 p.m. UTC | #1
On Mon, 2024-12-09 at 15:40 +0530, Aniket Limaye via lists.yoctoproject.org
wrote:
> 
> Early Boot of remote processors is supported at the SPL stage of the
> bootloader. Currently, SPL looks for the remoteproc firmwares in the
> boot partition.
> 
> Therefore, add the rproc firmware to the boot partition of wic images.
> 
> Signed-off-by: Aniket Limaye <a-limaye@ti.com>

This patch introduces a dependency of meta-ti-bsp on meta-ti-extras, breaking
builds of omap-a15 platforms without meta-ti-extras.

Best regards,
Matthias


> ---
>  meta-ti-bsp/conf/machine/include/omap-a15.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/include/omap-a15.inc b/meta-ti-bsp/conf/machine/include/omap-a15.inc
> index be086936..a258decd 100644
> --- a/meta-ti-bsp/conf/machine/include/omap-a15.inc
> +++ b/meta-ti-bsp/conf/machine/include/omap-a15.inc
> @@ -48,5 +48,6 @@ MACHINE_FEATURES = "apm usbgadget usbhost vfat ext2 screen alsa gpu mmip dsp gc3
>  
>  IMAGE_FSTYPES += "tar.xz wic.xz wic.bmap"
>  WKS_FILE ?= "sdimage-2part.wks"
> -IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX} ${UBOOT_EXTLINUX_BOOT_FILES}"
> +IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX} ${UBOOT_EXTLINUX_BOOT_FILES} ipc/dra7-ipu1-fw.xem4;dra7-ipu1-fw.xem4"
>  do_image_wic[depends] += "virtual/bootloader:do_deploy"
> +do_image_wic[depends] += "ti-ipc-rtos:do_deploy"
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#18098): https://lists.yoctoproject.org/g/meta-ti/message/18098
> Mute This Topic: https://lists.yoctoproject.org/mt/110003435/4454427
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [matthias.schiffer@ew.tq-group.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Denys Dmytriyenko Jan. 28, 2025, 5:59 p.m. UTC | #2
On Tue, Jan 28, 2025 at 02:11:18PM +0100, Matthias Schiffer via lists.yoctoproject.org wrote:
> On Mon, 2024-12-09 at 15:40 +0530, Aniket Limaye via lists.yoctoproject.org
> wrote:
> > 
> > Early Boot of remote processors is supported at the SPL stage of the
> > bootloader. Currently, SPL looks for the remoteproc firmwares in the
> > boot partition.
> > 
> > Therefore, add the rproc firmware to the boot partition of wic images.
> > 
> > Signed-off-by: Aniket Limaye <a-limaye@ti.com>
> 
> This patch introduces a dependency of meta-ti-bsp on meta-ti-extras, breaking
> builds of omap-a15 platforms without meta-ti-extras.

Ah, indeed. And the reason ti-ipc-rtos lives in meta-ti-extras is because 
those are some legacy recipes built from sources using old tools like XDC, 
SYS/BIOS and CGT... Those cannot be easily moved to meta-ti-bsp.

I'd say this change needs to be reverted and the inclusion of IPU FW pushed 
down to corresponding distro or product layers that use meta-ti-extras.


> Best regards,
> Matthias
> 
> 
> > ---
> >  meta-ti-bsp/conf/machine/include/omap-a15.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta-ti-bsp/conf/machine/include/omap-a15.inc b/meta-ti-bsp/conf/machine/include/omap-a15.inc
> > index be086936..a258decd 100644
> > --- a/meta-ti-bsp/conf/machine/include/omap-a15.inc
> > +++ b/meta-ti-bsp/conf/machine/include/omap-a15.inc
> > @@ -48,5 +48,6 @@ MACHINE_FEATURES = "apm usbgadget usbhost vfat ext2 screen alsa gpu mmip dsp gc3
> >  
> >  IMAGE_FSTYPES += "tar.xz wic.xz wic.bmap"
> >  WKS_FILE ?= "sdimage-2part.wks"
> > -IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX} ${UBOOT_EXTLINUX_BOOT_FILES}"
> > +IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX} ${UBOOT_EXTLINUX_BOOT_FILES} ipc/dra7-ipu1-fw.xem4;dra7-ipu1-fw.xem4"
> >  do_image_wic[depends] += "virtual/bootloader:do_deploy"
> > +do_image_wic[depends] += "ti-ipc-rtos:do_deploy"
diff mbox series

Patch

diff --git a/meta-ti-bsp/conf/machine/include/omap-a15.inc b/meta-ti-bsp/conf/machine/include/omap-a15.inc
index be086936..a258decd 100644
--- a/meta-ti-bsp/conf/machine/include/omap-a15.inc
+++ b/meta-ti-bsp/conf/machine/include/omap-a15.inc
@@ -48,5 +48,6 @@  MACHINE_FEATURES = "apm usbgadget usbhost vfat ext2 screen alsa gpu mmip dsp gc3
 
 IMAGE_FSTYPES += "tar.xz wic.xz wic.bmap"
 WKS_FILE ?= "sdimage-2part.wks"
-IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX} ${UBOOT_EXTLINUX_BOOT_FILES}"
+IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX} ${UBOOT_EXTLINUX_BOOT_FILES} ipc/dra7-ipu1-fw.xem4;dra7-ipu1-fw.xem4"
 do_image_wic[depends] += "virtual/bootloader:do_deploy"
+do_image_wic[depends] += "ti-ipc-rtos:do_deploy"