| Message ID | 20240620032202.169122-5-sabeeh-khan@ti.com |
|---|---|
| State | RFC |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | add FW and utilities for cc33xx wireless driver | expand |
On Wed, Jun 19, 2024 at 10:22:02PM -0500, Sabeeh Khan via lists.yoctoproject.org wrote: > Add scripts and conf files to be used to control and configure > the cc33xx WLAN device. Documentation for these scripts can be found here: > https://www.ti.com/tool/CC33XX-SOFTWARE > > Signed-off-by: Sabeeh Khan <sabeeh-khan@ti.com> > --- > .../cc33xx-target-scripts.bb | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb > > diff --git a/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb > new file mode 100644 > index 00000000..2f13f911 > --- /dev/null > +++ b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb > @@ -0,0 +1,22 @@ > +DESCRIPTION = "Scripts and configuration files for TI cc33xx wireless drivers" SUMMARY > +LICENSE = "BSD-3-Clause" > +LIC_FILES_CHKSUM = "file://COPYING;md5=904443cf7fae5c09c3d5f83f8557c265" > + > +SRCREV = "4371c93ea01b339f6f73f77d6d6bfcc185def8c0" > +BRANCH = "master" > +SRC_URI = "git://git.ti.com/git/cc33xx-wlan/cc33xx-target-scripts.git;protocol=https;branch=${BRANCH} \ > +" > + > +S = "${WORKDIR}/git" > + > +FILES:${PN} += "${datadir}/cc33xx/" > + > +do_install() { > + install -d ${D}${datadir}/cc33xx/ > + > + scripts=`find ./* -type f -name "*.*"` Is this find command necessary? > + for s in $scripts > + do > + install -m 0755 $s ${D}${datadir}/cc33xx/ > + done > +} > -- > 2.34.1
On 6/20/2024 3:27 PM, Denys Dmytriyenko wrote: > On Wed, Jun 19, 2024 at 10:22:02PM -0500, Sabeeh Khan via lists.yoctoproject.org wrote: >> [...] >> >> diff --git a/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb >> new file mode 100644 >> index 00000000..2f13f911 >> --- /dev/null >> +++ b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb >> @@ -0,0 +1,22 @@ >> +DESCRIPTION = "Scripts and configuration files for TI cc33xx wireless drivers" > SUMMARY Apologies for not being familiar, but are you suggesting here to have "SUMMARY" variable instead of "DESCRIPTION", or in addition to? Can I please have some more context over the ask here? I don't see "SUMMARY" variable in other meta-ti recipes, so I'm looking for a reference. > >> [...] >> + >> +do_install() { >> + install -d ${D}${datadir}/cc33xx/ >> + >> + scripts=`find ./* -type f -name "*.*"` > Is this find command necessary? The recipe should install .sh and .conf files from the git repo only. This was done to ignore any README or license files and not have them installed.
On Thu, Jun 20, 2024 at 03:37:12PM -0500, Khan, Sabeeh wrote: > > On 6/20/2024 3:27 PM, Denys Dmytriyenko wrote: > >On Wed, Jun 19, 2024 at 10:22:02PM -0500, Sabeeh Khan via lists.yoctoproject.org wrote: > >>[...] > >> > >>diff --git a/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb > >>new file mode 100644 > >>index 00000000..2f13f911 > >>--- /dev/null > >>+++ b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb > >>@@ -0,0 +1,22 @@ > >>+DESCRIPTION = "Scripts and configuration files for TI cc33xx wireless drivers" > >SUMMARY > > Apologies for not being familiar, but are you suggesting here > > to have "SUMMARY" variable instead of "DESCRIPTION", or in addition to? > > Can I please have some more context over the ask here? > > I don't see "SUMMARY" variable in other meta-ti recipes, so I'm > looking for a reference. https://docs.yoctoproject.org/ref-manual/variables.html#term-SUMMARY https://docs.yoctoproject.org/ref-manual/variables.html#term-DESCRIPTION SUMMARY is a shorter version of the package description (one-line under 72 characters), while DESCRIPTION can be a longer multi-line description. DESCRIPTION can be omitted and will be derived from SUMMARY, but not the other way around. In the very old days only the DESCRIPTION was used, hence old recipes still don't set SUMMARY, but newly added recipes should not do that. Here's one of the many recipes in meta-ti that properly uses/sets both: https://git.yoctoproject.org/meta-ti/tree/meta-ti-extras/recipes-ti/jailhouse/ti-jailhouse.inc > >>[...] > >>+ > >>+do_install() { > >>+ install -d ${D}${datadir}/cc33xx/ > >>+ > >>+ scripts=`find ./* -type f -name "*.*"` > >Is this find command necessary? > > The recipe should install .sh and .conf files from the git repo only. > > This was done to ignore any README or license files and not have > them installed. I believe you can use globs directly with install, unless there's a directory hierarchy: install -m 0755 *.* ${D}${datadir}/cc33xx/
On 6/20/2024 8:17 PM, Denys Dmytriyenko wrote: > On Thu, Jun 20, 2024 at 03:37:12PM -0500, Khan, Sabeeh wrote: >> On 6/20/2024 3:27 PM, Denys Dmytriyenko wrote: >>> On Wed, Jun 19, 2024 at 10:22:02PM -0500, Sabeeh Khan via lists.yoctoproject.org wrote: >>>> [...] >>>> >>>> diff --git a/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb >>>> new file mode 100644 >>>> index 00000000..2f13f911 >>>> --- /dev/null >>>> +++ b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb >>>> @@ -0,0 +1,22 @@ >>>> +DESCRIPTION = "Scripts and configuration files for TI cc33xx wireless drivers" >>> SUMMARY >> Apologies for not being familiar, but are you suggesting here >> >> to have "SUMMARY" variable instead of "DESCRIPTION", or in addition to? >> >> Can I please have some more context over the ask here? >> >> I don't see "SUMMARY" variable in other meta-ti recipes, so I'm >> looking for a reference. > https://urldefense.com/v3/__https://docs.yoctoproject.org/ref-manual/variables.html*term-SUMMARY__;Iw!!G3vK!T0lI-6cdoXVmU9UPzr9erSCvNsNdMvKJfZFYYP7HcUra2w5WfkbtKxo7hDbZ8P2Uk5WwWYI2c9n5$ > https://urldefense.com/v3/__https://docs.yoctoproject.org/ref-manual/variables.html*term-DESCRIPTION__;Iw!!G3vK!T0lI-6cdoXVmU9UPzr9erSCvNsNdMvKJfZFYYP7HcUra2w5WfkbtKxo7hDbZ8P2Uk5WwWRlLSudn$ > > SUMMARY is a shorter version of the package description (one-line under 72 > characters), while DESCRIPTION can be a longer multi-line description. > > DESCRIPTION can be omitted and will be derived from SUMMARY, but not the other > way around. > > In the very old days only the DESCRIPTION was used, hence old recipes still > don't set SUMMARY, but newly added recipes should not do that. > > Here's one of the many recipes in meta-ti that properly uses/sets both: > https://urldefense.com/v3/__https://git.yoctoproject.org/meta-ti/tree/meta-ti-extras/recipes-ti/jailhouse/ti-jailhouse.inc__;!!G3vK!T0lI-6cdoXVmU9UPzr9erSCvNsNdMvKJfZFYYP7HcUra2w5WfkbtKxo7hDbZ8P2Uk5WwWUukMkI9$ This makes it very clear, thank you! I'll make the changes throughout the series. > >>>> [...] >>>> + >>>> +do_install() { >>>> + install -d ${D}${datadir}/cc33xx/ >>>> + >>>> + scripts=`find ./* -type f -name "*.*"` >>> Is this find command necessary? >> The recipe should install .sh and .conf files from the git repo only. >> >> This was done to ignore any README or license files and not have >> them installed. > I believe you can use globs directly with install, unless there's a > directory hierarchy: > > install -m 0755 *.* ${D}${datadir}/cc33xx/ Yes, there is also a directory hierarchy. So for now I will leave this as is.
diff --git a/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb new file mode 100644 index 00000000..2f13f911 --- /dev/null +++ b/meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb @@ -0,0 +1,22 @@ +DESCRIPTION = "Scripts and configuration files for TI cc33xx wireless drivers" +LICENSE = "BSD-3-Clause" +LIC_FILES_CHKSUM = "file://COPYING;md5=904443cf7fae5c09c3d5f83f8557c265" + +SRCREV = "4371c93ea01b339f6f73f77d6d6bfcc185def8c0" +BRANCH = "master" +SRC_URI = "git://git.ti.com/git/cc33xx-wlan/cc33xx-target-scripts.git;protocol=https;branch=${BRANCH} \ +" + +S = "${WORKDIR}/git" + +FILES:${PN} += "${datadir}/cc33xx/" + +do_install() { + install -d ${D}${datadir}/cc33xx/ + + scripts=`find ./* -type f -name "*.*"` + for s in $scripts + do + install -m 0755 $s ${D}${datadir}/cc33xx/ + done +}
Add scripts and conf files to be used to control and configure the cc33xx WLAN device. Documentation for these scripts can be found here: https://www.ti.com/tool/CC33XX-SOFTWARE Signed-off-by: Sabeeh Khan <sabeeh-khan@ti.com> --- .../cc33xx-target-scripts.bb | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 meta-ti-extras/recipes-connectivity/cc33xx-target-scripts/cc33xx-target-scripts.bb