diff mbox series

[RFC,master/scarthgap,3/4] cc33xx-fw: install cc33xx firmware

Message ID 20240620032202.169122-4-sabeeh-khan@ti.com
State RFC
Delegated to: Ryan Eatmon
Headers show
Series add FW and utilities for cc33xx wireless driver | expand

Commit Message

Sabeeh Khan June 20, 2024, 3:22 a.m. UTC
Download and install the cc33xx firmware and binaries
to be used with the cc33xx drivers.

FW Version: 1.7.0.120

Signed-off-by: Sabeeh Khan <sabeeh-khan@ti.com>
---
 .../recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb    | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb

Comments

Ryan Eatmon June 20, 2024, 4:33 p.m. UTC | #1
On 6/19/2024 10:22 PM, Sabeeh Khan via lists.yoctoproject.org wrote:
> Download and install the cc33xx firmware and binaries
> to be used with the cc33xx drivers.
> 
> FW Version: 1.7.0.120
> 
> Signed-off-by: Sabeeh Khan <sabeeh-khan@ti.com>
> ---
>   .../recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb    | 26 +++++++++++++++++++
>   1 file changed, 26 insertions(+)
>   create mode 100644 meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
> 
> diff --git a/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
> new file mode 100644
> index 00000000..152e3501
> --- /dev/null
> +++ b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
> @@ -0,0 +1,26 @@
> +DESCRIPTION = "Firmware files for use with TI cc33xx"
> +LICENSE = "TI-TSPA"
> +LIC_FILES_CHKSUM = "file://LICENCE;md5=df68504cbd0a4da1643ebcfd5783dbc9"
> +
> +SRC_URI = " \
> +	git://git.ti.com/git/cc33xx-wlan/cc33xx-fw.git;protocol=https;branch=${BRANCH}
> +"

These patches are not consistent.

This one does a multi line SRC_URI and adds the BRANCH variable.  Can we 
redo the patches to be consistent in style?  Either use BRANCH in all, 
or don't use BRANCH.  And make all of the SRC_URI and single line.


> +PV = "1.7.0.120"
> +
> +SRCREV = "988ded3a7d4d0e46de62e9ebfcb685c502bd9edf"
> +BRANCH = "master"
> +
> +CLEANBROKEN = "1"
> +
> +S = "${WORKDIR}/git"
> +
> +do_compile() {
> +    :
> +}
> +
> +do_install() {
> +    oe_runmake 'DEST_DIR=${D}' install
> +}
> +
> +FILES:${PN} = "${nonarch_base_libdir}/firmware/ti-connectivity/*"
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#17769): https://lists.yoctoproject.org/g/meta-ti/message/17769
> Mute This Topic: https://lists.yoctoproject.org/mt/106774314/6551054
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Sabeeh Khan June 20, 2024, 4:52 p.m. UTC | #2
On 6/20/2024 11:33 AM, Ryan Eatmon wrote:
>
>
> On 6/19/2024 10:22 PM, Sabeeh Khan via lists.yoctoproject.org wrote:
>> Download and install the cc33xx firmware and binaries
>> to be used with the cc33xx drivers.
>>
>> FW Version: 1.7.0.120
>>
>> Signed-off-by: Sabeeh Khan <sabeeh-khan@ti.com>
>> ---
>>   .../recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb    | 26 +++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>   create mode 100644 
>> meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
>>
>> diff --git a/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb 
>> b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
>> new file mode 100644
>> index 00000000..152e3501
>> --- /dev/null
>> +++ b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
>> @@ -0,0 +1,26 @@
>> +DESCRIPTION = "Firmware files for use with TI cc33xx"
>> +LICENSE = "TI-TSPA"
>> +LIC_FILES_CHKSUM = 
>> "file://LICENCE;md5=df68504cbd0a4da1643ebcfd5783dbc9"
>> +
>> +SRC_URI = " \
>> + 
>> git://git.ti.com/git/cc33xx-wlan/cc33xx-fw.git;protocol=https;branch=${BRANCH}
>> +"
>
> These patches are not consistent.
>
> This one does a multi line SRC_URI and adds the BRANCH variable. Can 
> we redo the patches to be consistent in style?  Either use BRANCH in 
> all, or don't use BRANCH.  And make all of the SRC_URI and single line.
>
Hi Ryan, thanks for the review.

Yes, I have no issue in changing this and will ensure the SRC_URI/BRANCH 
variable are consistent.
Denys Dmytriyenko June 20, 2024, 6:35 p.m. UTC | #3
On Wed, Jun 19, 2024 at 10:22:01PM -0500, Sabeeh Khan via lists.yoctoproject.org wrote:
> Download and install the cc33xx firmware and binaries
> to be used with the cc33xx drivers.
> 
> FW Version: 1.7.0.120
> 
> Signed-off-by: Sabeeh Khan <sabeeh-khan@ti.com>
> ---
>  .../recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb    | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
> 
> diff --git a/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
> new file mode 100644
> index 00000000..152e3501
> --- /dev/null
> +++ b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
> @@ -0,0 +1,26 @@
> +DESCRIPTION = "Firmware files for use with TI cc33xx"
> +LICENSE = "TI-TSPA"
> +LIC_FILES_CHKSUM = "file://LICENCE;md5=df68504cbd0a4da1643ebcfd5783dbc9"
> +
> +SRC_URI = " \
> +	git://git.ti.com/git/cc33xx-wlan/cc33xx-fw.git;protocol=https;branch=${BRANCH} 
> +"
> +
> +PV = "1.7.0.120"
> +
> +SRCREV = "988ded3a7d4d0e46de62e9ebfcb685c502bd9edf"
> +BRANCH = "master"
> +
> +CLEANBROKEN = "1"
> +
> +S = "${WORKDIR}/git"
> +
> +do_compile() {
> +    :
> +}

do_compile[noexec] = "1"


> +do_install() {
> +    oe_runmake 'DEST_DIR=${D}' install
> +}
> +
> +FILES:${PN} = "${nonarch_base_libdir}/firmware/ti-connectivity/*"
> -- 
> 2.34.1
Sabeeh Khan June 20, 2024, 6:39 p.m. UTC | #4
On 6/20/2024 1:35 PM, Denys Dmytriyenko wrote:
> On Wed, Jun 19, 2024 at 10:22:01PM -0500, Sabeeh Khan via lists.yoctoproject.org wrote:
>> Download and install the cc33xx firmware and binaries
>> to be used with the cc33xx drivers.
>>
>> FW Version: 1.7.0.120
>>
>> Signed-off-by: Sabeeh Khan<sabeeh-khan@ti.com>
>> ---
>>   .../recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb    | 26 +++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>   create mode 100644 meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
>>
>> diff --git a/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
>> new file mode 100644
>> index 00000000..152e3501
>> --- /dev/null
>> +++ b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
>> @@ -0,0 +1,26 @@
>> +DESCRIPTION = "Firmware files for use with TI cc33xx"
>> +LICENSE = "TI-TSPA"
>> +LIC_FILES_CHKSUM ="file://LICENCE;md5=df68504cbd0a4da1643ebcfd5783dbc9"
>> +
>> +SRC_URI = " \
>> +	git://git.ti.com/git/cc33xx-wlan/cc33xx-fw.git;protocol=https;branch=${BRANCH}
>> +"
>> +
>> +PV = "1.7.0.120"
>> +
>> +SRCREV = "988ded3a7d4d0e46de62e9ebfcb685c502bd9edf"
>> +BRANCH = "master"
>> +
>> +CLEANBROKEN = "1"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +do_compile() {
>> +    :
>> +}
> do_compile[noexec] = "1"
I will correct, thank you!
diff mbox series

Patch

diff --git a/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
new file mode 100644
index 00000000..152e3501
--- /dev/null
+++ b/meta-ti-extras/recipes-bsp/cc33xx-fw/cc33xx-fw_git.bb
@@ -0,0 +1,26 @@ 
+DESCRIPTION = "Firmware files for use with TI cc33xx"
+LICENSE = "TI-TSPA"
+LIC_FILES_CHKSUM = "file://LICENCE;md5=df68504cbd0a4da1643ebcfd5783dbc9"
+
+SRC_URI = " \
+	git://git.ti.com/git/cc33xx-wlan/cc33xx-fw.git;protocol=https;branch=${BRANCH} 
+"
+
+PV = "1.7.0.120"
+
+SRCREV = "988ded3a7d4d0e46de62e9ebfcb685c502bd9edf"
+BRANCH = "master"
+
+CLEANBROKEN = "1"
+
+S = "${WORKDIR}/git"
+
+do_compile() {
+    :
+}
+
+do_install() {
+    oe_runmake 'DEST_DIR=${D}' install
+}
+
+FILES:${PN} = "${nonarch_base_libdir}/firmware/ti-connectivity/*"