diff mbox series

[2/2] uutils-coreutils: delete .cargo/config.toml

Message ID 20260706083445.2842309-2-ross.burton@arm.com
State New
Headers show
Series [1/2] librav1e: make nasm dependency x86-specific | expand

Commit Message

Ross Burton July 6, 2026, 8:34 a.m. UTC
This file hardcodes a specific compiler for aarch64-linux builds, which
is not the compiler that we provide.  As it's otherwise useless, we can
just delete the file.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb   | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Etienne Cordonnier July 6, 2026, 8:50 a.m. UTC | #1
Hi Ross,

what is the use-case of the patch? config.toml file is ignored in
out-of-tree builds ( https://github.com/rust-lang/cargo/issues/2930 ), so
AFAIU removing it shouldn't make any difference for a bitbake build. Is it
for devtool builds?

Étienne


On Mon, Jul 6, 2026 at 10:34 AM Ross Burton via lists.openembedded.org
<ross.burton=arm.com@lists.openembedded.org> wrote:

> This file hardcodes a specific compiler for aarch64-linux builds, which
> is not the compiler that we provide.  As it's otherwise useless, we can
> just delete the file.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  .../recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb   | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta-oe/recipes-core/uutils-coreutils/
> uutils-coreutils_0.9.0.bb b/meta-oe/recipes-core/uutils-coreutils/
> uutils-coreutils_0.9.0.bb
> index d294736395..2c7d3a3200 100644
> --- a/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
> +++ b/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
> @@ -65,6 +65,10 @@ python __anonymous() {
>
>  BBCLASSEXTEND = "native nativesdk"
>
> +do_configure:prepend() {
> +    rm -f ${S}/.cargo/config.toml
> +}
> +
>  do_compile:prepend() {
>      export LIBSTDBUF_DIR="${libdir}/coreutils"
>  }
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#128027):
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Ddevel_message_128027&d=DwIFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=SOdQBYUxH7BLXzTcxj9ZvaK6NGp2-7IVaqDjBLLiqzTSJVfVV9rx4ihsNf7nh8E0&s=O9-vKBRH9FlzsZfYlxmATl9wU4N_eiIW6nyWGWtYbVY&e=
> Mute This Topic:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_120136596_7048771&d=DwIFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=SOdQBYUxH7BLXzTcxj9ZvaK6NGp2-7IVaqDjBLLiqzTSJVfVV9rx4ihsNf7nh8E0&s=2yFkpP2kDn3joVADoPeFPZ0Zi9frtMNUKCeXShwvgr8&e=
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Ddevel_unsub&d=DwIFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=SOdQBYUxH7BLXzTcxj9ZvaK6NGp2-7IVaqDjBLLiqzTSJVfVV9rx4ihsNf7nh8E0&s=IkfzKX-TOIl7nmyig50STkBSa2ay6flcERE0_reNnh0&e=
> [ecordonnier@snap.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Mikko Rapeli July 6, 2026, 9:01 a.m. UTC | #2
Hi,

The file is not ignored. It gets used and overrides linker set by cargo.bbclass/rust.
uutils-coreutils builds are currently broken on arm64 build hosts and this
patch fixed them.

Cheers,

-Mikko

On Mon, Jul 06, 2026 at 10:50:19AM +0200, Etienne Cordonnier via lists.openembedded.org wrote:
> Hi Ross,
> 
> what is the use-case of the patch? config.toml file is ignored in
> out-of-tree builds ( https://github.com/rust-lang/cargo/issues/2930 ), so
> AFAIU removing it shouldn't make any difference for a bitbake build. Is it
> for devtool builds?
> 
> Étienne
> 
> 
> On Mon, Jul 6, 2026 at 10:34 AM Ross Burton via lists.openembedded.org
> <ross.burton=arm.com@lists.openembedded.org> wrote:
> 
> > This file hardcodes a specific compiler for aarch64-linux builds, which
> > is not the compiler that we provide.  As it's otherwise useless, we can
> > just delete the file.
> >
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> >  .../recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb   | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta-oe/recipes-core/uutils-coreutils/
> > uutils-coreutils_0.9.0.bb b/meta-oe/recipes-core/uutils-coreutils/
> > uutils-coreutils_0.9.0.bb
> > index d294736395..2c7d3a3200 100644
> > --- a/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
> > +++ b/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
> > @@ -65,6 +65,10 @@ python __anonymous() {
> >
> >  BBCLASSEXTEND = "native nativesdk"
> >
> > +do_configure:prepend() {
> > +    rm -f ${S}/.cargo/config.toml
> > +}
> > +
> >  do_compile:prepend() {
> >      export LIBSTDBUF_DIR="${libdir}/coreutils"
> >  }
> > --
> > 2.43.0
> >
> >
> > 
> >
> >

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#128031): https://lists.openembedded.org/g/openembedded-devel/message/128031
> Mute This Topic: https://lists.openembedded.org/mt/120136596/7159507
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [mikko.rapeli@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Etienne Cordonnier July 6, 2026, 9:07 a.m. UTC | #3
OK, thanks. I'll need to investigate whether something changed. In the past
I had to send fixes specifically because this file was ignored in yocto
builds ( see https://github.com/uutils/coreutils/pull/8360 ).

On Mon, Jul 6, 2026 at 11:01 AM Mikko Rapeli <mikko.rapeli@linaro.org>
wrote:

> Hi,
>
> The file is not ignored. It gets used and overrides linker set by
> cargo.bbclass/rust.
> uutils-coreutils builds are currently broken on arm64 build hosts and this
> patch fixed them.
>
> Cheers,
>
> -Mikko
>
> On Mon, Jul 06, 2026 at 10:50:19AM +0200, Etienne Cordonnier via
> lists.openembedded.org wrote:
> > Hi Ross,
> >
> > what is the use-case of the patch? config.toml file is ignored in
> > out-of-tree builds ( https://github.com/rust-lang/cargo/issues/2930  ),
> so
> > AFAIU removing it shouldn't make any difference for a bitbake build. Is
> it
> > for devtool builds?
> >
> > Étienne
> >
> >
> > On Mon, Jul 6, 2026 at 10:34 AM Ross Burton via lists.openembedded.org
> > <ross.burton=arm.com@lists.openembedded.org> wrote:
> >
> > > This file hardcodes a specific compiler for aarch64-linux builds, which
> > > is not the compiler that we provide.  As it's otherwise useless, we can
> > > just delete the file.
> > >
> > > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > > ---
> > >  .../recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb   | 4
> ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/meta-oe/recipes-core/uutils-coreutils/
> > > uutils-coreutils_0.9.0.bb b/meta-oe/recipes-core/uutils-coreutils/
> > > uutils-coreutils_0.9.0.bb
> > > index d294736395..2c7d3a3200 100644
> > > --- a/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
> > > +++ b/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
> > > @@ -65,6 +65,10 @@ python __anonymous() {
> > >
> > >  BBCLASSEXTEND = "native nativesdk"
> > >
> > > +do_configure:prepend() {
> > > +    rm -f ${S}/.cargo/config.toml
> > > +}
> > > +
> > >  do_compile:prepend() {
> > >      export LIBSTDBUF_DIR="${libdir}/coreutils"
> > >  }
> > > --
> > > 2.43.0
> > >
> > >
> > >
> > >
> > >
>
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#128031):
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Ddevel_message_128031&d=DwIDaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=uLBAxAVxvPA0OdjZ6ENLmT8jfeji5R00bAuSC7pG1WThhqcr5s4ImgHl2V2Ksvon&s=GqPIL0bx8OcFWM9cn_D5VM-RjX-XWtIMAIOBYhIQDKY&e=
> > Mute This Topic:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_120136596_7159507&d=DwIDaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=uLBAxAVxvPA0OdjZ6ENLmT8jfeji5R00bAuSC7pG1WThhqcr5s4ImgHl2V2Ksvon&s=i2fZUu8gqjbAx4GrXThyR-Ef6r7RD9Zi78eiCpHFsXM&e=
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Ddevel_unsub&d=DwIDaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=uLBAxAVxvPA0OdjZ6ENLmT8jfeji5R00bAuSC7pG1WThhqcr5s4ImgHl2V2Ksvon&s=N5X_J-Kw5XXiqJL6mqgIKED8BMXuK0S7uIHndfvs03k&e=
> [mikko.rapeli@linaro.org]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb b/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
index d294736395..2c7d3a3200 100644
--- a/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
+++ b/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.9.0.bb
@@ -65,6 +65,10 @@  python __anonymous() {
 
 BBCLASSEXTEND = "native nativesdk"
 
+do_configure:prepend() {
+    rm -f ${S}/.cargo/config.toml
+}
+
 do_compile:prepend() {
     export LIBSTDBUF_DIR="${libdir}/coreutils"
 }