diff mbox series

[1/2] librav1e: make nasm dependency x86-specific

Message ID 20260706083445.2842309-1-ross.burton@arm.com
State Accepted
Headers show
Series [1/2] librav1e: make nasm dependency x86-specific | expand

Commit Message

Ross Burton July 6, 2026, 8:34 a.m. UTC
nasm is an x86 assembler, so only depend on it (and work around the
build paths errors) on x86-64 (the assembler fastpaths are explicitly
64-bit only).

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../recipes-multimedia/rav1e/librav1e_p20250902.bb           | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Khem Raj July 6, 2026, 1:31 p.m. UTC | #1
Does adding fdebug-prefix-map to ASFLAGS help on  x86


On Mon, Jul 6, 2026, 1:34 AM Ross Burton via lists.openembedded.org
<ross.burton=arm.com@lists.openembedded.org> wrote:

> nasm is an x86 assembler, so only depend on it (and work around the
> build paths errors) on x86-64 (the assembler fastpaths are explicitly
> 64-bit only).
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  .../recipes-multimedia/rav1e/librav1e_p20250902.bb           | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/rav1e/
> librav1e_p20250902.bb b/meta-multimedia/recipes-multimedia/rav1e/
> librav1e_p20250902.bb
> index 836cd4448f..80ac5d9268 100644
> --- a/meta-multimedia/recipes-multimedia/rav1e/librav1e_p20250902.bb
> +++ b/meta-multimedia/recipes-multimedia/rav1e/librav1e_p20250902.bb
> @@ -7,9 +7,10 @@ inherit cargo_c pkgconfig cargo-update-recipe-crates
>
>  require ${PN}-crates.inc
>
> -DEPENDS += "nasm-native"
> +DEPENDS:append:x86_64 = " nasm-native"
>
>  SRC_URI += "git://
> github.com/xiph/rav1e.git;protocol=https;nobranch=1;tag=${PV}
> <http://github.com/xiph/rav1e.git;protocol=https;nobranch=1;tag=$%7BPV%7D>
> "
>  SRCREV = "a2f01b3e233f531c28a20b4c29fb5c9e5d29fa6d"
>
> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> +# TODO we need to pass -fdebug-prefix-map to the nasm calls
> +INHIBIT_PACKAGE_DEBUG_SPLIT:x86-64 = "1"
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#128026):
> https://lists.openembedded.org/g/openembedded-devel/message/128026
> Mute This Topic: https://lists.openembedded.org/mt/120136595/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Ross Burton July 6, 2026, 1:51 p.m. UTC | #2
On 6 Jul 2026, at 14:31, Khem Raj <raj.khem@gmail.com> wrote:
> 
> Does adding fdebug-prefix-map to ASFLAGS help on  x86

It would, if the nasm invocation wasn’t buried into rust crates with no way to add flags from the recipe.

Ross
diff mbox series

Patch

diff --git a/meta-multimedia/recipes-multimedia/rav1e/librav1e_p20250902.bb b/meta-multimedia/recipes-multimedia/rav1e/librav1e_p20250902.bb
index 836cd4448f..80ac5d9268 100644
--- a/meta-multimedia/recipes-multimedia/rav1e/librav1e_p20250902.bb
+++ b/meta-multimedia/recipes-multimedia/rav1e/librav1e_p20250902.bb
@@ -7,9 +7,10 @@  inherit cargo_c pkgconfig cargo-update-recipe-crates
 
 require ${PN}-crates.inc
 
-DEPENDS += "nasm-native"
+DEPENDS:append:x86_64 = " nasm-native"
 
 SRC_URI += "git://github.com/xiph/rav1e.git;protocol=https;nobranch=1;tag=${PV}"
 SRCREV = "a2f01b3e233f531c28a20b4c29fb5c9e5d29fa6d"
 
-INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
+# TODO we need to pass -fdebug-prefix-map to the nasm calls
+INHIBIT_PACKAGE_DEBUG_SPLIT:x86-64 = "1"