diff mbox series

[meta-oe,3/3] cheese: require distro feature opengl

Message ID 20250903062503.122121-3-hongxu.jia@windriver.com
State Under Review
Headers show
Series [meta-oe,1/3] libsdl2-ttf: require distro feature opengl | expand

Commit Message

Hongxu Jia Sept. 3, 2025, 6:25 a.m. UTC
Make cheese require distro feature opengl. Otherwise it fails
to build world if 'opengl' doesn't exist in DISTRO_FEATURES.
...
|ERROR: Nothing PROVIDES 'clutter-gst-3.0' (but meta-openembedded/meta-gnome/recipes-gnome/
cheese/cheese_44.1.bb DEPENDS on or otherwise requires it)
|clutter-gst-3.0 was skipped: missing required distro feature 'opengl' (not in DISTRO_FEATURES)
|ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
|Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cheese', 'clutter-gst-3.0']
...

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta-gnome/recipes-gnome/cheese/cheese_44.1.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Khem Raj Sept. 3, 2025, 6:32 a.m. UTC | #1
On Tue, Sep 2, 2025 at 11:25 PM hongxu via lists.openembedded.org
<hongxu.jia=eng.windriver.com@lists.openembedded.org> wrote:
>
> Make cheese require distro feature opengl. Otherwise it fails
> to build world if 'opengl' doesn't exist in DISTRO_FEATURES.
> ...
> |ERROR: Nothing PROVIDES 'clutter-gst-3.0' (but meta-openembedded/meta-gnome/recipes-gnome/
> cheese/cheese_44.1.bb DEPENDS on or otherwise requires it)
> |clutter-gst-3.0 was skipped: missing required distro feature 'opengl' (not in DISTRO_FEATURES)
> |ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> |Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cheese', 'clutter-gst-3.0']
> ...
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta-gnome/recipes-gnome/cheese/cheese_44.1.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb b/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
> index 180f3f6319..8e78162991 100644
> --- a/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
> +++ b/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
> @@ -5,6 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a17cb0a873d252440acfdf9b3d0e7fbf"
>
>  inherit gnomebase gobject-introspection vala itstool gtk-icon-cache gsettings gnome-help gtk-doc
>
> +REQUIRED_DISTRO_FEATURES = "opengl"
> +

this also needs inherit features_check

>  SRC_URI += "file://0001-libcheese-Add-GtkWidget-cast-to-avoid-an-incompatibl.patch"
>
>  SRC_URI[archive.sha256sum] = "5f2185c4c99e54ddf2b8baf60c82819950e54952e132e8639875f3edcbf8f68e"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#119192): https://lists.openembedded.org/g/openembedded-devel/message/119192
> Mute This Topic: https://lists.openembedded.org/mt/115041303/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Hongxu Jia Sept. 3, 2025, 6:37 a.m. UTC | #2
On 9/3/25 14:32, Khem Raj via lists.openembedded.org wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Tue, Sep 2, 2025 at 11:25 PM hongxu via lists.openembedded.org
> <hongxu.jia=eng.windriver.com@lists.openembedded.org>  wrote:
>> Make cheese require distro feature opengl. Otherwise it fails
>> to build world if 'opengl' doesn't exist in DISTRO_FEATURES.
>> ...
>> |ERROR: Nothing PROVIDES 'clutter-gst-3.0' (but meta-openembedded/meta-gnome/recipes-gnome/
>> cheese/cheese_44.1.bb DEPENDS on or otherwise requires it)
>> |clutter-gst-3.0 was skipped: missing required distro feature 'opengl' (not in DISTRO_FEATURES)
>> |ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
>> |Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cheese', 'clutter-gst-3.0']
>> ...
>>
>> Signed-off-by: Hongxu Jia<hongxu.jia@windriver.com>
>> ---
>>   meta-gnome/recipes-gnome/cheese/cheese_44.1.bb | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb b/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
>> index 180f3f6319..8e78162991 100644
>> --- a/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
>> +++ b/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
>> @@ -5,6 +5,8 @@ LIC_FILES_CHKSUM ="file://COPYING;md5=a17cb0a873d252440acfdf9b3d0e7fbf"
>>
>>   inherit gnomebase gobject-introspection vala itstool gtk-icon-cache gsettings gnome-help gtk-doc
>>
>> +REQUIRED_DISTRO_FEATURES = "opengl"
>> +
> this also needs inherit features_check

It is not necessary, because bbclass gtk-icon-cache has inherited 
features_check already [1]

[1] 
https://git.openembedded.org/openembedded-core/tree/meta/classes-recipe/gtk-icon-cache.bbclass#n16

//Hongxu

>
>>   SRC_URI +="file://0001-libcheese-Add-GtkWidget-cast-to-avoid-an-incompatibl.patch"
>>
>>   SRC_URI[archive.sha256sum] = "5f2185c4c99e54ddf2b8baf60c82819950e54952e132e8639875f3edcbf8f68e"
>> --
>> 2.34.1
>>
>>
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#119194):https://lists.openembedded.org/g/openembedded-devel/message/119194
>> Mute This Topic:https://lists.openembedded.org/mt/115041303/3617049
>> Group Owner:openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub  [hongxu.jia@eng.windriver.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
Khem Raj Sept. 3, 2025, 4:07 p.m. UTC | #3
On Tue, Sep 2, 2025 at 11:37 PM hongxu via lists.openembedded.org
<hongxu.jia=eng.windriver.com@lists.openembedded.org> wrote:
>
> On 9/3/25 14:32, Khem Raj via lists.openembedded.org wrote:
>
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Tue, Sep 2, 2025 at 11:25 PM hongxu via lists.openembedded.org
> <hongxu.jia=eng.windriver.com@lists.openembedded.org> wrote:
>
> Make cheese require distro feature opengl. Otherwise it fails
> to build world if 'opengl' doesn't exist in DISTRO_FEATURES.
> ...
> |ERROR: Nothing PROVIDES 'clutter-gst-3.0' (but meta-openembedded/meta-gnome/recipes-gnome/
> cheese/cheese_44.1.bb DEPENDS on or otherwise requires it)
> |clutter-gst-3.0 was skipped: missing required distro feature 'opengl' (not in DISTRO_FEATURES)
> |ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> |Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cheese', 'clutter-gst-3.0']
> ...
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta-gnome/recipes-gnome/cheese/cheese_44.1.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb b/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
> index 180f3f6319..8e78162991 100644
> --- a/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
> +++ b/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
> @@ -5,6 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a17cb0a873d252440acfdf9b3d0e7fbf"
>
>  inherit gnomebase gobject-introspection vala itstool gtk-icon-cache gsettings gnome-help gtk-doc
>
> +REQUIRED_DISTRO_FEATURES = "opengl"
> +
>
> this also needs inherit features_check
>
> It is not necessary, because bbclass gtk-icon-cache has inherited features_check already [1]
>

hmm ok. Perhaps a mention of indirect inclusion would have been good
for future references, but not a big deal.

> [1] https://git.openembedded.org/openembedded-core/tree/meta/classes-recipe/gtk-icon-cache.bbclass#n16
>
> //Hongxu
>
>  SRC_URI += "file://0001-libcheese-Add-GtkWidget-cast-to-avoid-an-incompatibl.patch"
>
>  SRC_URI[archive.sha256sum] = "5f2185c4c99e54ddf2b8baf60c82819950e54952e132e8639875f3edcbf8f68e"
> --
> 2.34.1
>
>
>
>
>
>
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#119195): https://lists.openembedded.org/g/openembedded-devel/message/119195
> Mute This Topic: https://lists.openembedded.org/mt/115041303/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb b/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
index 180f3f6319..8e78162991 100644
--- a/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
+++ b/meta-gnome/recipes-gnome/cheese/cheese_44.1.bb
@@ -5,6 +5,8 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=a17cb0a873d252440acfdf9b3d0e7fbf"
 
 inherit gnomebase gobject-introspection vala itstool gtk-icon-cache gsettings gnome-help gtk-doc
 
+REQUIRED_DISTRO_FEATURES = "opengl"
+
 SRC_URI += "file://0001-libcheese-Add-GtkWidget-cast-to-avoid-an-incompatibl.patch"
 
 SRC_URI[archive.sha256sum] = "5f2185c4c99e54ddf2b8baf60c82819950e54952e132e8639875f3edcbf8f68e"