diff mbox series

[meta-oe] php: fix removal of --with-zlib-dir configure option

Message ID 20250723070852.381343-1-gijs.peskens@munisense.com
State New
Headers show
Series [meta-oe] php: fix removal of --with-zlib-dir configure option | expand

Commit Message

Gijs Peskens July 23, 2025, 7:08 a.m. UTC
From: Gijs Peskens <gijs@peskens.net>

---
 meta-oe/recipes-devtools/php/php_8.4.10.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gijs Peskens July 23, 2025, 7:11 a.m. UTC | #1
Since I seem to have forgotten (first time mailing a patch, sorry) to 
add a explanation:

PHP has removed the --with-zlib-dir configure option since that is now 
taken over by pkg-config, this breaks building PHP on Walnascar when zip 
is enabled via PACKAGECONFIG.
So remove it.

On 23-07-2025 09:08, Gijs Peskens wrote:
> From: Gijs Peskens <gijs@peskens.net>
>
> ---
>   meta-oe/recipes-devtools/php/php_8.4.10.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-devtools/php/php_8.4.10.bb b/meta-oe/recipes-devtools/php/php_8.4.10.bb
> index 4d598949a..4ed5d1e4f 100644
> --- a/meta-oe/recipes-devtools/php/php_8.4.10.bb
> +++ b/meta-oe/recipes-devtools/php/php_8.4.10.bb
> @@ -110,7 +110,7 @@ PACKAGECONFIG[sqlite3] = "--with-sqlite3=${STAGING_LIBDIR}/.. \
>                             ,--without-sqlite3 --without-pdo-sqlite \
>                             ,sqlite3"
>   PACKAGECONFIG[valgrind] = "--with-valgrind=${STAGING_DIR_TARGET}/usr,--with-valgrind=no,valgrind"
> -PACKAGECONFIG[zip] = "--with-zip --with-zlib-dir=${STAGING_EXECPREFIXDIR},,libzip"
> +PACKAGECONFIG[zip] = "--with-zip,,libzip"
>   
>   export HOSTCC = "${BUILD_CC}"
>   export PHP_NATIVE_DIR = "${STAGING_BINDIR_NATIVE}"
Khem Raj July 23, 2025, 3:39 p.m. UTC | #2
On Wed, Jul 23, 2025 at 4:08 AM Gijs Peskens via
lists.openembedded.org <gijs=peskens.net@lists.openembedded.org>
wrote:
>
> Since I seem to have forgotten (first time mailing a patch, sorry) to
> add a explanation:
>
> PHP has removed the --with-zlib-dir configure option since that is now
> taken over by pkg-config, this breaks building PHP on Walnascar when zip
> is enabled via PACKAGECONFIG.
> So remove it.

Please enhance the commit message with this info and send a v2

>
> On 23-07-2025 09:08, Gijs Peskens wrote:
> > From: Gijs Peskens <gijs@peskens.net>
> >
> > ---
> >   meta-oe/recipes-devtools/php/php_8.4.10.bb | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-devtools/php/php_8.4.10.bb b/meta-oe/recipes-devtools/php/php_8.4.10.bb
> > index 4d598949a..4ed5d1e4f 100644
> > --- a/meta-oe/recipes-devtools/php/php_8.4.10.bb
> > +++ b/meta-oe/recipes-devtools/php/php_8.4.10.bb
> > @@ -110,7 +110,7 @@ PACKAGECONFIG[sqlite3] = "--with-sqlite3=${STAGING_LIBDIR}/.. \
> >                             ,--without-sqlite3 --without-pdo-sqlite \
> >                             ,sqlite3"
> >   PACKAGECONFIG[valgrind] = "--with-valgrind=${STAGING_DIR_TARGET}/usr,--with-valgrind=no,valgrind"
> > -PACKAGECONFIG[zip] = "--with-zip --with-zlib-dir=${STAGING_EXECPREFIXDIR},,libzip"
> > +PACKAGECONFIG[zip] = "--with-zip,,libzip"
> >
> >   export HOSTCC = "${BUILD_CC}"
> >   export PHP_NATIVE_DIR = "${STAGING_BINDIR_NATIVE}"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#118716): https://lists.openembedded.org/g/openembedded-devel/message/118716
> Mute This Topic: https://lists.openembedded.org/mt/114301638/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/php/php_8.4.10.bb b/meta-oe/recipes-devtools/php/php_8.4.10.bb
index 4d598949a..4ed5d1e4f 100644
--- a/meta-oe/recipes-devtools/php/php_8.4.10.bb
+++ b/meta-oe/recipes-devtools/php/php_8.4.10.bb
@@ -110,7 +110,7 @@  PACKAGECONFIG[sqlite3] = "--with-sqlite3=${STAGING_LIBDIR}/.. \
                           ,--without-sqlite3 --without-pdo-sqlite \
                           ,sqlite3"
 PACKAGECONFIG[valgrind] = "--with-valgrind=${STAGING_DIR_TARGET}/usr,--with-valgrind=no,valgrind"
-PACKAGECONFIG[zip] = "--with-zip --with-zlib-dir=${STAGING_EXECPREFIXDIR},,libzip"
+PACKAGECONFIG[zip] = "--with-zip,,libzip"
 
 export HOSTCC = "${BUILD_CC}"
 export PHP_NATIVE_DIR = "${STAGING_BINDIR_NATIVE}"