diff mbox series

[meta-python,063/149] python3-pytest-mock: add missing run-time dependencies

Message ID 20230531082437.10646-64-brgl@bgdev.pl
State New
Headers show
Series python3: improve run-time dependencies situation | expand

Commit Message

Bartosz Golaszewski May 31, 2023, 8:23 a.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Add missing RDEPENDS for this package.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 .../recipes-devtools/python/python3-pytest-mock_3.10.0.bb   | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Khem Raj June 5, 2023, 6:09 p.m. UTC | #1 
on qemux86-64/glibc I am seeing

AssertionError:
Failed ptests:
{'python3-pytest-mock':
['tests/test_pytest_mock.py::test_assert_called_args_with_introspection',

'tests/test_pytest_mock.py::test_assert_called_kwargs_with_introspection',

'tests/test_pytest_mock.py::test_detailed_introspection_async',
                         'tests/test_pytest_mock.py::test_plain_stopall',

'tests/test_pytest_mock.py::test_used_with_class_scope',

'tests/test_pytest_mock.py::test_used_with_module_scope',

'tests/test_pytest_mock.py::test_used_with_package_scope',

'tests/test_pytest_mock.py::test_used_with_session_scope']}


Cannot run ptests without @expectedFailure as ptests are expected to fail

On Wed, May 31, 2023 at 1:26 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add missing RDEPENDS for this package.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  .../recipes-devtools/python/python3-pytest-mock_3.10.0.bb   | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb b/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
> index c4e672f33..bf5bc250a 100644
> --- a/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
> +++ b/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
> @@ -18,6 +18,12 @@ inherit setuptools3 ptest
>
>  DEPENDS += "${PYTHON_PN}-setuptools-scm-native"
>
> +RDEPENDS:${PN} += " \
> +    python3-asyncio \
> +    python3-pytest \
> +    python3-unittest \
> +"
> +
>  S = "${WORKDIR}/git"
>
>  do_install_ptest() {
> --
> 2.39.2
>
Bartosz Golaszewski June 6, 2023, 9:05 a.m. UTC | #2 
On Mon, Jun 5, 2023 at 8:09 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> on qemux86-64/glibc I am seeing
>
> AssertionError:
> Failed ptests:
> {'python3-pytest-mock':
> ['tests/test_pytest_mock.py::test_assert_called_args_with_introspection',
>
> 'tests/test_pytest_mock.py::test_assert_called_kwargs_with_introspection',
>
> 'tests/test_pytest_mock.py::test_detailed_introspection_async',
>                          'tests/test_pytest_mock.py::test_plain_stopall',
>
> 'tests/test_pytest_mock.py::test_used_with_class_scope',
>
> 'tests/test_pytest_mock.py::test_used_with_module_scope',
>
> 'tests/test_pytest_mock.py::test_used_with_package_scope',
>
> 'tests/test_pytest_mock.py::test_used_with_session_scope']}
>
>
> Cannot run ptests without @expectedFailure as ptests are expected to fail
>

I'm not sure I follow. Without this patch the ptests can't even be
started as pytest is not available for import, so it's not really a
regression.

Bart

> On Wed, May 31, 2023 at 1:26 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add missing RDEPENDS for this package.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> >  .../recipes-devtools/python/python3-pytest-mock_3.10.0.bb   | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb b/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
> > index c4e672f33..bf5bc250a 100644
> > --- a/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
> > +++ b/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
> > @@ -18,6 +18,12 @@ inherit setuptools3 ptest
> >
> >  DEPENDS += "${PYTHON_PN}-setuptools-scm-native"
> >
> > +RDEPENDS:${PN} += " \
> > +    python3-asyncio \
> > +    python3-pytest \
> > +    python3-unittest \
> > +"
> > +
> >  S = "${WORKDIR}/git"
> >
> >  do_install_ptest() {
> > --
> > 2.39.2
> >
Khem Raj June 6, 2023, 3:10 p.m. UTC | #3 
On Tue, Jun 6, 2023 at 2:05 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> On Mon, Jun 5, 2023 at 8:09 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > on qemux86-64/glibc I am seeing
> >
> > AssertionError:
> > Failed ptests:
> > {'python3-pytest-mock':
> > ['tests/test_pytest_mock.py::test_assert_called_args_with_introspection',
> >
> >
> 'tests/test_pytest_mock.py::test_assert_called_kwargs_with_introspection',
> >
> > 'tests/test_pytest_mock.py::test_detailed_introspection_async',
> >                          'tests/test_pytest_mock.py::test_plain_stopall',
> >
> > 'tests/test_pytest_mock.py::test_used_with_class_scope',
> >
> > 'tests/test_pytest_mock.py::test_used_with_module_scope',
> >
> > 'tests/test_pytest_mock.py::test_used_with_package_scope',
> >
> > 'tests/test_pytest_mock.py::test_used_with_session_scope']}
> >
> >
> > Cannot run ptests without @expectedFailure as ptests are expected to fail
> >
>
> I'm not sure I follow. Without this patch the ptests can't even be
> started as pytest is not available for import, so it's not really a
> regression.


That’s fine all we need it disable from auto run

>
>
> Bart
>
> > On Wed, May 31, 2023 at 1:26 AM Bartosz Golaszewski <brgl@bgdev.pl>
> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Add missing RDEPENDS for this package.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > ---
> > >  .../recipes-devtools/python/python3-pytest-mock_3.10.0.bb   | 6
> ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/meta-python/recipes-devtools/python/
> python3-pytest-mock_3.10.0.bb b/meta-python/recipes-devtools/python/
> python3-pytest-mock_3.10.0.bb
> > > index c4e672f33..bf5bc250a 100644
> > > --- a/meta-python/recipes-devtools/python/
> python3-pytest-mock_3.10.0.bb
> > > +++ b/meta-python/recipes-devtools/python/
> python3-pytest-mock_3.10.0.bb
> > > @@ -18,6 +18,12 @@ inherit setuptools3 ptest
> > >
> > >  DEPENDS += "${PYTHON_PN}-setuptools-scm-native"
> > >
> > > +RDEPENDS:${PN} += " \
> > > +    python3-asyncio \
> > > +    python3-pytest \
> > > +    python3-unittest \
> > > +"
> > > +
> > >  S = "${WORKDIR}/git"
> > >
> > >  do_install_ptest() {
> > > --
> > > 2.39.2
> > >
>
diff mbox series

Patch

diff --git a/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb b/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
index c4e672f33..bf5bc250a 100644
--- a/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
+++ b/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
@@ -18,6 +18,12 @@  inherit setuptools3 ptest
 
 DEPENDS += "${PYTHON_PN}-setuptools-scm-native"
 
+RDEPENDS:${PN} += " \
+    python3-asyncio \
+    python3-pytest \
+    python3-unittest \
+"
+
 S = "${WORKDIR}/git"
 
 do_install_ptest() {