| Message ID | 20250126115104.1148761-1-ejo@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | busybox: drop net-tools from defconfig | expand |
On Sun, 2025-01-26 at 12:51 +0100, Enrico Jörns via lists.openembedded.org wrote: > The 'net-tools' have been deprecated 15 years ago! [1] > Let's remove their busybox pendants from the defconfig to prevent > people > from accidentally starting projects with ancient technology. > > [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html > > Signed-off-by: Enrico Jörns <ejo@pengutronix.de> > --- > meta/recipes-core/busybox/busybox/defconfig | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) I did a quick grep of OE-Core and we still have a handful of sites using this on target, particularly but not limited to our QA, the ones that caught my eye: meta/recipes-core/udev/udev-extraconf/network.sh: ifconfig | grep -q "^$INTERFACE" || ifup $INTERFACE meta/recipes-core/images/build-appliance-image/README_VirtualBox_Toaster.txt: $ ifconfig meta/recipes-core/images/build-appliance-image/README_VirtualBox_Toaster.txt: $ ifconfig meta/recipes-core/busybox/files/simple.script: /SBIN_DIR/ifconfig $interface 0.0.0.0 meta/recipes-core/busybox/files/simple.script: /SBIN_DIR/ifconfig $interface $ip $BROADCAST $NETMASK meta/lib/oeqa/selftest/cases/devtool.py: result = runCmd('PATH="$PATH:/sbin:/usr/sbin" ifconfig -a', ignore_status=True) meta/lib/oeqa/selftest/cases/devtool.py: self.skipTest('Failed to determine if tap devices exist with ifconfig or ip: %s' % result.output) meta/lib/oeqa/utils/qemurunner.py: cmd = "ifconfig eth0 %s netmask %s up\n" % (self.ip, self.netmask) meta/lib/oeqa/runtime/cases/ethernet_ip_connman.py: (status, output) = self.target.run("ifconfig eth0 | grep 'inet ' | awk '{print $2}'") meta/lib/oeqa/runtime/cases/ethernet_ip_connman.py: (status, output) = self.target.run("ifconfig eth0:1 %s netmask 255.255.255.0 && sleep 2 && ping -c 5 %s && ifconfig eth0:1 down" % (virtual_ip,virtual_ip)) but there are others too. We probably need to finish resolving these to other commands before we can turn this off. If you aren't able to help with that, we should at least have an open bug to sort it out. Cheers, Richard
Hi Richard, Am Sonntag, dem 26.01.2025 um 12:58 +0000 schrieb Richard Purdie: > On Sun, 2025-01-26 at 12:51 +0100, Enrico Jörns via > lists.openembedded.org wrote: > > The 'net-tools' have been deprecated 15 years ago! [1] > > Let's remove their busybox pendants from the defconfig to prevent > > people > > from accidentally starting projects with ancient technology. > > > > [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html > > > > Signed-off-by: Enrico Jörns <ejo@pengutronix.de> > > --- > > meta/recipes-core/busybox/busybox/defconfig | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > I did a quick grep of OE-Core and we still have a handful of sites > using this on target, particularly but not limited to our QA, the ones > that caught my eye: thank you for looking into this! Well, not that I hadn't done a grep before.
On Sun, 2025-01-26 at 21:30 +0100, Enrico Jörns wrote: > Am Sonntag, dem 26.01.2025 um 12:58 +0000 schrieb Richard Purdie: > > On Sun, 2025-01-26 at 12:51 +0100, Enrico Jörns via > > lists.openembedded.org wrote: > > > The 'net-tools' have been deprecated 15 years ago! [1] > > > Let's remove their busybox pendants from the defconfig to prevent > > > people > > > from accidentally starting projects with ancient technology. > > > > > > [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html > > > > > > Signed-off-by: Enrico Jörns <ejo@pengutronix.de> > > > --- > > > meta/recipes-core/busybox/busybox/defconfig | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > I did a quick grep of OE-Core and we still have a handful of sites > > using this on target, particularly but not limited to our QA, the ones > > that caught my eye: > > thank you for looking into this! > > Well, not that I hadn't done a grep before.
diff --git a/meta/recipes-core/busybox/busybox/defconfig b/meta/recipes-core/busybox/busybox/defconfig index 38b82457b7..22c9dafcb3 100644 --- a/meta/recipes-core/busybox/busybox/defconfig +++ b/meta/recipes-core/busybox/busybox/defconfig @@ -899,11 +899,11 @@ CONFIG_FEATURE_HTTPD_PORT_DEFAULT=0 # CONFIG_FEATURE_HTTPD_LAST_MODIFIED is not set # CONFIG_FEATURE_HTTPD_DATE is not set # CONFIG_FEATURE_HTTPD_ACL_IP is not set -CONFIG_IFCONFIG=y -CONFIG_FEATURE_IFCONFIG_STATUS=y +# CONFIG_IFCONFIG is not set +# CONFIG_FEATURE_IFCONFIG_STATUS is not set # CONFIG_FEATURE_IFCONFIG_SLIP is not set # CONFIG_FEATURE_IFCONFIG_MEMSTART_IOADDR_IRQ is not set -CONFIG_FEATURE_IFCONFIG_HW=y +# CONFIG_FEATURE_IFCONFIG_HW is not set # CONFIG_FEATURE_IFCONFIG_BROADCAST_PLUS is not set # CONFIG_IFENSLAVE is not set # CONFIG_IFPLUGD is not set @@ -950,7 +950,7 @@ CONFIG_NC=y # CONFIG_NC_SERVER is not set # CONFIG_NC_EXTRA is not set # CONFIG_NC_110_COMPAT is not set -CONFIG_NETSTAT=y +# CONFIG_NETSTAT is not set # CONFIG_FEATURE_NETSTAT_WIDE is not set # CONFIG_FEATURE_NETSTAT_PRG is not set CONFIG_NSLOOKUP=y @@ -964,7 +964,7 @@ CONFIG_PING=y CONFIG_PING6=y CONFIG_FEATURE_FANCY_PING=y # CONFIG_PSCAN is not set -CONFIG_ROUTE=y +# CONFIG_ROUTE is not set # CONFIG_SLATTACH is not set # CONFIG_SSL_CLIENT is not set # CONFIG_TC is not set
The 'net-tools' have been deprecated 15 years ago! [1] Let's remove their busybox pendants from the defconfig to prevent people from accidentally starting projects with ancient technology. [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html Signed-off-by: Enrico Jörns <ejo@pengutronix.de> --- meta/recipes-core/busybox/busybox/defconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)