[RFC,01/15] openssh: Extend to provide native recipe

Message ID 20211124144739.2250-2-stefan.herbrechtsmeier-oss@weidmueller.com
State New
Headers show
Series Rework npm support | expand

Commit Message

Stefan Herbrechtsmeier Nov. 24, 2021, 2:47 p.m. UTC
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---

 meta/recipes-connectivity/openssh/openssh_8.8p1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Kanavin Nov. 24, 2021, 3:08 p.m. UTC | #1
The use case for native openssh needs to be provided in the commit message.
Just say that 'this is needed so that X can work properly'.

Alex

On Wed, 24 Nov 2021 at 15:48, Stefan Herbrechtsmeier <
stefan.herbrechtsmeier-oss@weidmueller.com> wrote:

> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> Signed-off-by: Stefan Herbrechtsmeier <
> stefan.herbrechtsmeier@weidmueller.com>
> ---
>
>  meta/recipes-connectivity/openssh/openssh_8.8p1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
> b/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
> index ee86bb92ab..33fdf1e8ab 100644
> --- a/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
> +++ b/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
> @@ -182,4 +182,4 @@ ALTERNATIVE_PRIORITY = "90"
>  ALTERNATIVE:${PN}-scp = "scp"
>  ALTERNATIVE:${PN}-ssh = "ssh"
>
> -BBCLASSEXTEND += "nativesdk"
> +BBCLASSEXTEND += "native nativesdk"
> --
> 2.20.1
>
>
Bruce Ashfield Nov. 24, 2021, 3:08 p.m. UTC | #2
The extension to provide the native recipe is clear from the patch
itself .. it would be useful to document what is using it on the
-native side.

Bruce

On Wed, Nov 24, 2021 at 9:48 AM Stefan Herbrechtsmeier
<stefan.herbrechtsmeier-oss@weidmueller.com> wrote:
>
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> ---
>
>  meta/recipes-connectivity/openssh/openssh_8.8p1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/openssh/openssh_8.8p1.bb b/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
> index ee86bb92ab..33fdf1e8ab 100644
> --- a/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
> +++ b/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
> @@ -182,4 +182,4 @@ ALTERNATIVE_PRIORITY = "90"
>  ALTERNATIVE:${PN}-scp = "scp"
>  ALTERNATIVE:${PN}-ssh = "ssh"
>
> -BBCLASSEXTEND += "nativesdk"
> +BBCLASSEXTEND += "native nativesdk"
> --
> 2.20.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#158696): https://lists.openembedded.org/g/openembedded-core/message/158696
> Mute This Topic: https://lists.openembedded.org/mt/87282274/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Patch

diff --git a/meta/recipes-connectivity/openssh/openssh_8.8p1.bb b/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
index ee86bb92ab..33fdf1e8ab 100644
--- a/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
+++ b/meta/recipes-connectivity/openssh/openssh_8.8p1.bb
@@ -182,4 +182,4 @@  ALTERNATIVE_PRIORITY = "90"
 ALTERNATIVE:${PN}-scp = "scp"
 ALTERNATIVE:${PN}-ssh = "ssh"
 
-BBCLASSEXTEND += "nativesdk"
+BBCLASSEXTEND += "native nativesdk"