| Message ID | 20241007120950.975803-1-ejo@pengutronix.de |
|---|---|
| Headers | show |
| Series | busybox: cleanup and fix config fragments | expand |
Am Montag, dem 07.10.2024 um 14:09 +0200 schrieb Enrico Jörns: [TO += Andrej Valek <andrej.v@skyrain.eu>] > Most of the busybox config fragments are useless since the respective options > were accidentally enabled in the 'defconfig' file during the defconfig update > to busybox 1.33.0 [1]. > > This is redundant and confusing and takes the ability to disable options by > removing the respective fragment file from the SRC_URI. > > While cleaning this up, some other inconsistencies were found and fixed. > > The series starts with a defconfig sync to the current defaults to have a clear > base to work on. > > [1] 4335cd24 ("busybox: refresh the defconfig from 1.33.0") > > > Enrico Jörns (9): > busybox: sync config for busybox 1.36.1 > busybox: disable defconfig options from simpler fragments > busybox: disable defconfig options from syslogd.cfg > busybox: mdev.cfg: remove CONFIG_SETSID > busybox: disable defconfig options from login-utilities.cfg > busybox: disable defconfig options from unicode.cfg > busybox: getopts.cfg: disable long options > busybox: disable long options in defconfig and fix longopts.cfg > busybox: disable defconfig options from mount-via-label.cfg > > meta/recipes-core/busybox/busybox/defconfig | 124 +++++++++--------- > meta/recipes-core/busybox/busybox/getopts.cfg | 2 - > .../recipes-core/busybox/busybox/longopts.cfg | 11 +- > meta/recipes-core/busybox/busybox/mdev.cfg | 1 - > 4 files changed, 68 insertions(+), 70 deletions(-) >
Hi Enrico, Could you please guide me to the right patch? I wasn't able to find it ;). BR, Andrej On 24.10.2024 15:04, Enrico Jörns wrote: > Am Montag, dem 07.10.2024 um 14:09 +0200 schrieb Enrico Jörns: > > [TO += Andrej Valek <andrej.v@skyrain.eu>] > >> Most of the busybox config fragments are useless since the respective options >> were accidentally enabled in the 'defconfig' file during the defconfig update >> to busybox 1.33.0 [1]. >> >> This is redundant and confusing and takes the ability to disable options by >> removing the respective fragment file from the SRC_URI. >> >> While cleaning this up, some other inconsistencies were found and fixed. >> >> The series starts with a defconfig sync to the current defaults to have a clear >> base to work on. >> >> [1] 4335cd24 ("busybox: refresh the defconfig from 1.33.0") >> >> >> Enrico Jörns (9): >> busybox: sync config for busybox 1.36.1 >> busybox: disable defconfig options from simpler fragments >> busybox: disable defconfig options from syslogd.cfg >> busybox: mdev.cfg: remove CONFIG_SETSID >> busybox: disable defconfig options from login-utilities.cfg >> busybox: disable defconfig options from unicode.cfg >> busybox: getopts.cfg: disable long options >> busybox: disable long options in defconfig and fix longopts.cfg >> busybox: disable defconfig options from mount-via-label.cfg >> >> meta/recipes-core/busybox/busybox/defconfig | 124 +++++++++--------- >> meta/recipes-core/busybox/busybox/getopts.cfg | 2 - >> .../recipes-core/busybox/busybox/longopts.cfg | 11 +- >> meta/recipes-core/busybox/busybox/mdev.cfg | 1 - >> 4 files changed, 68 insertions(+), 70 deletions(-) >>
On Fri, 2024-10-25 at 17:01 +0200, Andrej Valek via lists.openembedded.org wrote: > Could you please guide me to the right patch? I wasn't able to find > it ;). They're listed here: https://lore.kernel.org/openembedded-core/a30ee7e5-bc6c-4490-9c10-2972138051b5@skyrain.eu/ Sorry about not getting these in before the upgrade, I'm a bit distracted by the autobuilder changes and retesting the upgrade distracted me further. The fixes there do look really good so it would be great if we could rebase them and get them merged, Thanks, Richard
On Fri, 2024-10-25 at 19:26 +0200, Andrej wrote: > Ok, I was thinking that it was done by intention, but it happened 14y > ago > https://github.com/openembedded/openembedded-core/commit/615a98ed9a02 > 1da245513790c064761a0a5a67e9 . So I guess not. > > Enrico, no > problem, most of them could by integrated into defconfig. Please > squash it into one commit if you're going to do it. Or let me know > and I will take a care of it ;). In many ways I prefer having multiple changes showing an evolution as those patches do, it does make review easier. Cheers, Richard
Hi Andrej, Hi Richard, Am Freitag, dem 25.10.2024 um 19:07 +0100 schrieb Richard Purdie: > On Fri, 2024-10-25 at 19:26 +0200, Andrej wrote: > > Ok, I was thinking that it was done by intention, but it happened 14y > > ago > > https://github.com/openembedded/openembedded-core/commit/615a98ed9a02 > > 1da245513790c064761a0a5a67e9 . So I guess not. I am not sure if I fully understand what you are referring to here. Could you provide some details about what happened there? OE didn't have those fragments 14y ago I guess. > > Enrico, no > > problem, most of them could by integrated into defconfig. Please > > squash it into one commit if you're going to do it. Or let me know > > and I will take a care of it ;). > > In many ways I prefer having multiple changes showing an evolution as > those patches do, it does make review easier. Thanks Richard for stepping in! I've rebased and revised my patches now and sent a v2. Regards, Enrico > Cheers, > > Richard >
Most of the busybox config fragments are useless since the respective options were accidentally enabled in the 'defconfig' file during the defconfig update to busybox 1.33.0 [1]. This is redundant and confusing and takes the ability to disable options by removing the respective fragment file from the SRC_URI. While cleaning this up, some other inconsistencies were found and fixed. The series starts with a defconfig sync to the current defaults to have a clear base to work on. [1] 4335cd24 ("busybox: refresh the defconfig from 1.33.0") Enrico Jörns (9): busybox: sync config for busybox 1.36.1 busybox: disable defconfig options from simpler fragments busybox: disable defconfig options from syslogd.cfg busybox: mdev.cfg: remove CONFIG_SETSID busybox: disable defconfig options from login-utilities.cfg busybox: disable defconfig options from unicode.cfg busybox: getopts.cfg: disable long options busybox: disable long options in defconfig and fix longopts.cfg busybox: disable defconfig options from mount-via-label.cfg meta/recipes-core/busybox/busybox/defconfig | 124 +++++++++--------- meta/recipes-core/busybox/busybox/getopts.cfg | 2 - .../recipes-core/busybox/busybox/longopts.cfg | 11 +- meta/recipes-core/busybox/busybox/mdev.cfg | 1 - 4 files changed, 68 insertions(+), 70 deletions(-)