mbox series

[0/2] Rework WIC sector size

Message ID 1773361726-30192-1-git-send-email-mark.hatle@kernel.crashing.org
Headers show
Series Rework WIC sector size | expand

Message

Mark Hatle March 13, 2026, 12:28 a.m. UTC 
This work is effectively based on the 'v7' of the 'standalone wic'
submission.  It was requested that the submission be broken into
individual parts so we can review and get merge things individually.

Changes from v7:

Introduction of additional (previous implementation) vfat 4k tests.

Update the test suite to add a new cmdline argument test in addition
to (not replacing) the previous variable version of the test.

Update the test case to include fat partition tests.

Cleanup Deprecation message so it only displays once, if the older
style is used.  In v7 the message may have been displayed twice.

Mark Hatle (1):
  oeqa/selftest: wic: Add vfat to test_wic_sector_size

Trevor Woerner (1):
  wic: re-implement sector-size support

 meta/lib/oeqa/selftest/cases/wic.py                | 105 ++++++++++++++++++++-
 scripts/lib/wic/engine.py                          |  60 +++++++-----
 scripts/lib/wic/help.py                            |  23 +++--
 scripts/lib/wic/misc.py                            |   6 ++
 scripts/lib/wic/partition.py                       |  97 ++++++++++++++++++-
 scripts/lib/wic/plugins/imager/direct.py           |  18 +---
 scripts/lib/wic/plugins/source/bootimg_efi.py      |   5 +-
 scripts/lib/wic/plugins/source/bootimg_pcbios.py   |  11 ++-
 .../lib/wic/plugins/source/isoimage_isohybrid.py   |   5 +-
 scripts/wic                                        |  41 ++++++++
 10 files changed, 306 insertions(+), 65 deletions(-)

Comments

Richard Purdie March 13, 2026, 11:23 a.m. UTC | #1 
On Thu, 2026-03-12 at 19:28 -0500, Mark Hatle via lists.openembedded.org wrote:
> This work is effectively based on the 'v7' of the 'standalone wic'
> submission.  It was requested that the submission be broken into
> individual parts so we can review and get merge things individually.
> 
> Changes from v7:
> 
> Introduction of additional (previous implementation) vfat 4k tests.
> 
> Update the test suite to add a new cmdline argument test in addition
> to (not replacing) the previous variable version of the test.
> 
> Update the test case to include fat partition tests.
> 
> Cleanup Deprecation message so it only displays once, if the older
> style is used.  In v7 the message may have been displayed twice.
> 
> Mark Hatle (1):
>   oeqa/selftest: wic: Add vfat to test_wic_sector_size
> 
> Trevor Woerner (1):
>   wic: re-implement sector-size support

Something in here failed in testing:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/3519
wic.Wic2.test_mkfs_extraopts
ERROR: A sector/block size is specified in both the mkfs-extraopts argument (-S 1024) and the wic arguments (512) and they do not match.
https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/3401
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/3292

Cheers,

Richard