diff mbox series

[v4,3/3] tests/parse: add coverage for old override syntax

Message ID GV1PR07MB91207B4781549380AE6B9B89A8712@GV1PR07MB9120.eurprd07.prod.outlook.com
State New
Headers show
Series [v4,1/3] bb/data_smart: remove dead code | expand

Commit Message

Konrad Weihmann Oct. 3, 2024, 8:13 a.m. UTC 
including previously unconvered tests for true failure cases of
_prepend/_append/_remove.
In addition add tests for not valid cases

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
---
  lib/bb/tests/parse.py | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)
diff mbox series

Patch

diff --git a/lib/bb/tests/parse.py b/lib/bb/tests/parse.py
index 410679d5a..e111747ec 100644
--- a/lib/bb/tests/parse.py
+++ b/lib/bb/tests/parse.py
@@ -126,6 +126,34 @@  EXTRA_OECONF:append = " c"
          d.setVar("OVERRIDES", "class-target")
          self.assertEqual(d.getVar("EXTRA_OECONF"), "b c d")
  
+    override_old_template = """
+EXTRA_OECONF{operation} = " c"
+"""
+
+    def test_parse_old_override_syntax(self):
+        for pattern in ['_append', '_prepend', '_remove']:
+            f = self.parsehelper(
+                self.override_old_template.format(operation=pattern))
+            try:
+                bb.parse.handle(f.name, self.d)['']
+                self.fail(
+                    'Pattern should have raised bb.BBHandledException for %s' % pattern)
+            except bb.BBHandledException:
+                pass
+
+    override_old_valid_template = """
+do{operation}something () {{
+   :
+}}
+addtask do{operation}something
+"""
+
+    def test_parse_old_override_syntax_no_warning(self):
+        for pattern in ['_append', '_prepend', '_remove']:
+            f = self.parsehelper(
+                self.override_old_valid_template.format(operation=pattern))
+            bb.parse.handle(f.name, self.d)['']
+
      overridetest3 = """
  DESCRIPTION = "A"
  DESCRIPTION:${PN}-dev = "${DESCRIPTION} B"