diff mbox series

[3/3] tests/parse: add coverage for old override syntax

Message ID GV1PR07MB91206D0607025857909F16ECA86D2@GV1PR07MB9120.eurprd07.prod.outlook.com
State New
Headers show
Series [1/3] bb/data_smart: remove dead code | expand

Commit Message

Konrad Weihmann Sept. 21, 2024, 12:09 p.m. UTC 
including previously unconvered tests for true failure cases of
_prepend/_append/_remove.
In addition add tests for not valid cases

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
---
 lib/bb/tests/parse.py | 69 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)
diff mbox series

Patch

diff --git a/lib/bb/tests/parse.py b/lib/bb/tests/parse.py
index 410679d5a..2da3a2a22 100644
--- a/lib/bb/tests/parse.py
+++ b/lib/bb/tests/parse.py
@@ -132,6 +132,75 @@  DESCRIPTION:${PN}-dev = "${DESCRIPTION} B"
 PN = "bc"
 """
 
+    override_old_append = """
+EXTRA_OECONF_append = " c"
+"""
+
+    def test_parse_old_override_syntax_append(self):
+        f = self.parsehelper(self.override_old_append)
+        try:
+            bb.parse.handle(f.name, self.d)['']
+            self.fail('Pattern should have raised bb.BBHandledException')
+        except bb.BBHandledException:
+            pass
+
+    override_old_prepend = """
+EXTRA_OECONF_prepend = " c"
+"""
+
+    def test_parse_old_override_syntax_prepend(self):
+        f = self.parsehelper(self.override_old_prepend)
+        try:
+            bb.parse.handle(f.name, self.d)['']
+            self.fail('Pattern should have raised bb.BBHandledException')
+        except bb.BBHandledException:
+            pass
+
+    override_old_remove = """
+EXTRA_OECONF_remove = " c"
+"""
+
+    def test_parse_old_override_syntax_remove(self):
+        f = self.parsehelper(self.override_old_remove)
+        try:
+            bb.parse.handle(f.name, self.d)['']
+            self.fail('Pattern should have raised bb.BBHandledException')
+        except bb.BBHandledException:
+            pass
+
+    override_old_valid_append = """
+do_appendsomething () {
+   :
+}
+addtask do_appendsomething
+"""
+
+    def test_parse_old_override_syntax_no_warning_append(self):
+        f = self.parsehelper(self.override_old_valid_append)
+        bb.parse.handle(f.name, self.d)['']
+
+    override_old_valid_prepend = """
+do_prependsomething () {
+   :
+}
+addtask do_prependsomething
+"""
+
+    def test_parse_old_override_syntax_no_warning_prepend(self):
+        f = self.parsehelper(self.override_old_valid_prepend)
+        bb.parse.handle(f.name, self.d)['']
+
+    override_old_valid_remove = """
+do_removesomething () {
+   :
+}
+addtask do_removesomething
+"""
+
+    def test_parse_old_override_syntax_no_warning_remove(self):
+        f = self.parsehelper(self.override_old_valid_remove)
+        bb.parse.handle(f.name, self.d)['']
+
     def test_parse_combinations(self):
         f = self.parsehelper(self.overridetest3)
         d = bb.parse.handle(f.name, self.d)['']