diff mbox series

[v2] wget: Work around wget2 bugs in Range handling and --continue

Message ID 20261017153416.78661-1-richard.purdie@linuxfoundation.org
State New
Headers show
Series [v2] wget: Work around wget2 bugs in Range handling and --continue | expand

Commit Message

Richard Purdie Oct. 17, 2026, 3:34 p.m. UTC 
wget v2 has bugs with --continue and -O with servers that don't support Range: headers
such as python's simple http.server. Whilst likely not widely used in production,
this breaks some of our selftests.

For now, skip the continue option with wget v2+.

Bug filed upstream: https://gitlab.com/gnuwget/wget2/-/work_items/728

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 lib/bb/fetch/wget.py | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/lib/bb/fetch/wget.py b/lib/bb/fetch/wget.py
index b464fcfbe97..c554f162c04 100644
--- a/lib/bb/fetch/wget.py
+++ b/lib/bb/fetch/wget.py
@@ -127,6 +127,11 @@  class Wget(FetchMethod):
 
         fetchcmd = self.basecmd.copy()
 
+        wget2 = False
+        version = subprocess.check_output(fetchcmd + ["--version"], text=True)
+        if "Wget2" in version:
+             wget2 = True
+
         dldir = os.path.realpath(d.getVar("DL_DIR"))
         # Where we ultimately want the file
         finalpath = os.path.join(dldir, ud.localfile)
@@ -150,7 +155,11 @@  class Wget(FetchMethod):
                 fetchcmd.append("--password=" + ud.pswd)
 
         uri = ud.url.split(";")[0]
-        fetchcmd.append("--continue")
+        # wget2 has bugs with --continue and -O with servers that don't support Range: headers
+        # so we skip that for now with wget v2+
+        # https://gitlab.com/gnuwget/wget2/-/work_items/728
+        if not wget2:
+            fetchcmd.append("--continue")
         fetchcmd.append("--directory-prefix=" + dldir)
         fetchcmd.append(uri)
         self._runwget(ud, d, fetchcmd, False)