diff mbox series

fetch/svn: fix typo in the svn:externals error handler

Message ID 20260920190222.5657-1-wxbet.oe@gmail.com
State Accepted, archived
Commit 6f5ecebbebd117fca0326fe5e78bbe487ef8a1e1
Headers show
Series fetch/svn: fix typo in the svn:externals error handler | expand

Commit Message

WXbet Sept. 20, 2026, 7:02 p.m. UTC
From: WXbet <57314510+WXbet@users.noreply.github.com>

The except branch swallowing a failed "svn propget svn:externals" call
reads "passs". Python parses that as a name, so the handler raises a
NameError instead of ignoring the error, and the original FetchError is
lost. Introduced in 58097a59f ("fetch/svn: Convert to use lists of
command arguments").

Signed-off-by: WXbet <57314510+WXbet@users.noreply.github.com>
---
 lib/bb/fetch/svn.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/lib/bb/fetch/svn.py b/lib/bb/fetch/svn.py
index 73ce83f..5d57793 100644
--- a/lib/bb/fetch/svn.py
+++ b/lib/bb/fetch/svn.py
@@ -165,7 +165,7 @@  class Svn(FetchMethod):
                         else:
                             bb.debug(1, "svn repository has externals:\n%s" % output)
                 except bb.fetch.FetchError:
-                    passs
+                    pass
             scmdata = ud.parm.get("scmdata", "")
             if scmdata == "keep":
                 tar_flags = []