diff mbox series

[3/4] tests: add fetch_import tests to test bb.fetch2 => bb.fetch migration

Message ID 20260827142958.547182-3-chris.laplante@agilent.com
State New
Headers show
Series [1/4] lib: rename fetch2 as fetch; invert compat shim to make bb.fetch2 = bb.fetch | expand

Commit Message

chris.laplante@agilent.com Aug. 27, 2026, 2:29 p.m. UTC 
From: Chris Laplante <chris.laplante@agilent.com>

Also tests that importing bb.fetch2 (instead of bb.fetch) results in a
DeprecationWarning.

AI-Generated: GPT-5.6 Sol

Signed-off-by: Chris Laplante <chris.laplante@agilent.com>
---
 bin/bitbake-selftest         |  1 +
 lib/bb/tests/fetch_import.py | 64 ++++++++++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)
 create mode 100644 lib/bb/tests/fetch_import.py
diff mbox series

Patch

diff --git a/bin/bitbake-selftest b/bin/bitbake-selftest
index 8ac0aeb5f..27791d2db 100755
--- a/bin/bitbake-selftest
+++ b/bin/bitbake-selftest
@@ -32,6 +32,7 @@  tests = ["bb.tests.codeparser",
          "bb.tests.data",
          "bb.tests.event",
          "bb.tests.fetch",
+         "bb.tests.fetch_import",
          "bb.tests.parse",
          "bb.tests.runqueue",
          "bb.tests.setup",
diff --git a/lib/bb/tests/fetch_import.py b/lib/bb/tests/fetch_import.py
new file mode 100644
index 000000000..3c44a1b3a
--- /dev/null
+++ b/lib/bb/tests/fetch_import.py
@@ -0,0 +1,64 @@ 
+#
+# Copyright (C) 2026 Agilent Technologies, Inc.
+#
+# SPDX-License-Identifier: GPL-2.0-only
+#
+
+import os
+import subprocess
+import sys
+import unittest
+
+
+class FetchImportTests(unittest.TestCase):
+    def run_python(self, code):
+        env = os.environ.copy()
+        libdir = os.path.realpath(os.path.join(os.path.dirname(__file__), "..", ".."))
+        env["PYTHONPATH"] = os.pathsep.join(filter(None, (libdir, env.get("PYTHONPATH"))))
+        result = subprocess.run(
+            [sys.executable, "-c", code],
+            env=env,
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE,
+            text=True,
+        )
+        self.assertEqual(result.returncode, 0, result.stderr)
+
+    def test_fetch_is_lazy(self):
+        self.run_python("""
+import sys
+import bb
+
+assert "bb.fetch" not in sys.modules
+assert "bb.fetch2" not in sys.modules
+""")
+
+    def test_fetch_import(self):
+        self.run_python("""
+import sys
+import bb.fetch
+from bb.fetch import Fetch
+
+assert sys.modules["bb.fetch"] is bb.fetch
+assert Fetch is bb.fetch.Fetch
+""")
+
+    def test_fetch2_import_compatibility(self):
+        self.run_python("""
+import sys
+import warnings
+
+with warnings.catch_warnings(record=True) as caught:
+    warnings.simplefilter("always")
+    import bb.fetch2
+    from bb.fetch2 import Fetch
+
+assert len(caught) == 1
+assert caught[0].category is DeprecationWarning
+assert str(caught[0].message) == "bb.fetch2 is deprecated; use bb.fetch instead"
+assert caught[0].filename == "<string>"
+
+assert bb.fetch2 is bb.fetch
+assert sys.modules["bb.fetch2"] is bb.fetch
+assert Fetch is bb.fetch.Fetch
+""")
\ No newline at end of file