| Message ID | 20260501091418.76994-2-bijak.dawid@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | d89a2ededcf9cb01649d507f4bea74fcd3e157bc |
| Headers | show |
| Series | doc: bitbake-user-manual-metadata: clarify inherit_defer documentation | expand |
Hi Dawid, On 5/1/26 11:14 AM, Dawid Bijak wrote: > The documentation for inherit_defer contained the claim > "If VARNAME is going to be set, it needs to be set before the > inherit_defer statement is parsed" > which is incorrect and contradicts the purpose of inherit_defer. > > Drop the incorrect statement. > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
Hi Quentin, On Thu, May 07, 2026 at 03:48:19PM +0200, Quentin Schulz wrote: > Hi Dawid, > > On 5/1/26 11:14 AM, Dawid Bijak wrote: > > The documentation for inherit_defer contained the claim > > "If VARNAME is going to be set, it needs to be set before the > > inherit_defer statement is parsed" > > which is incorrect and contradicts the purpose of inherit_defer. > > > > Drop the incorrect statement. > > > > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> > > Thanks! > Quentin Thank you for the thorough review of the series. I'll send v3 incorporating your remarks. It will however take around a week since I'm tied up at the moment. Greets, Dawid
diff --git a/doc/bitbake-user-manual/bitbake-user-manual-metadata.rst b/doc/bitbake-user-manual/bitbake-user-manual-metadata.rst index 40cae6b05..ee6919dc4 100644 --- a/doc/bitbake-user-manual/bitbake-user-manual-metadata.rst +++ b/doc/bitbake-user-manual/bitbake-user-manual-metadata.rst @@ -829,9 +829,7 @@ Here is an example:: inherit_defer ${VARNAME} -If ``VARNAME`` is -going to be set, it needs to be set before the ``inherit_defer`` statement is -parsed. One way to achieve a conditional inherit in this case is to use +One way to achieve a conditional inherit in this case is to use overrides:: VARIABLE = ""
The documentation for inherit_defer contained the claim "If VARNAME is going to be set, it needs to be set before the inherit_defer statement is parsed" which is incorrect and contradicts the purpose of inherit_defer. Drop the incorrect statement. Signed-off-by: Dawid Bijak <bijak.dawid@gmail.com> --- doc/bitbake-user-manual/bitbake-user-manual-metadata.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)