diff mbox series

[V2] bitbake-setup: Avoid unexpected positional parameter propagation when sourcing scripts

Message ID 20251125120824.1023662-1-changqing.li@windriver.com
State New
Headers show
Series [V2] bitbake-setup: Avoid unexpected positional parameter propagation when sourcing scripts | expand

Commit Message

Changqing Li Nov. 25, 2025, 12:08 p.m. UTC
From: Changqing Li <changqing.li@windriver.com>

Using `set` to define positional parameters in the current shell causes
those parameters to persist. When another script is sourced in the same
shell without explicit arguments, it unexpectedly inherits these
positional parameters. This change prevents such unintended propagation.

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 bin/bitbake-setup | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/bin/bitbake-setup b/bin/bitbake-setup
index 75be90940..8e229073a 100755
--- a/bin/bitbake-setup
+++ b/bin/bitbake-setup
@@ -184,7 +184,7 @@  def setup_bitbake_build(bitbake_config, layerdir, setupdir, thisdir, update_bb_c
 
     def _make_init_build_env(builddir, oeinitbuildenvdir):
         builddir = os.path.realpath(builddir)
-        cmd = "cd {}\nset {}\n. ./oe-init-build-env\n".format(oeinitbuildenvdir, builddir)
+        cmd = 'cd {}\nset {}\n. ./oe-init-build-env\nset --\n'.format(oeinitbuildenvdir, builddir)
         initbuild_in_builddir = os.path.join(builddir, 'init-build-env')
 
         with open(initbuild_in_builddir, 'w') as f: