diff mbox series

bb/main.py: skip noisy output for bitbake-getvar

Message ID 20250612050709.3588563-1-hongxu.jia@windriver.com
State New
Headers show
Series bb/main.py: skip noisy output for bitbake-getvar | expand

Commit Message

Hongxu Jia June 12, 2025, 5:07 a.m. UTC 
Calling oe-debuginfod in a build failed:
...
$ oe-debuginfod
|Getting sysroot...
|Error: NOTE: Reconnecting to bitbake server...
|NOTE: Retrying server connection (#1)... (18:55:53.009687)
|path-to-build/tmp/work/x86_64-linux/elfutils-native/0.192/recipe-sysroot-native doesn't exist.
|Have you run 'bitbake elfutils-native -caddto_recipe_sysroot'?
...

The script oe-debuginfod calls bitbake-getvar to get sysroot, the
output of bitbake-getvar was mixed with output of bitbake
...
NOTE: Reconnecting to bitbake server...
NOTE: Retrying server connection (#1)... (18:55:53.009687)
...

Because script bitbake-getvar sets 2 or 3 to quiet level, improve
the output of bitbake, skip reconnect output if quiet < 2

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 lib/bb/main.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Alexander Kanavin June 12, 2025, 8:18 a.m. UTC | #1 
On Thu, 12 Jun 2025 at 07:07, hongxu via lists.openembedded.org
<hongxu.jia=eng.windriver.com@lists.openembedded.org> wrote:
> Because script bitbake-getvar sets 2 or 3 to quiet level, improve
> the output of bitbake, skip reconnect output if quiet < 2
>
> -                    logger.info("Reconnecting to bitbake server...")
> +                    if configParams.quiet < 2:
> +                        logger.info("Reconnecting to bitbake server...")

Thanks, this is better, but actually, I think it's even better to just
use logger.setLevel() at the start, so that these calls don't have to
be each wrapped in a condition (with potential for regressions if more
logger.info()s are added).

Alex
diff mbox series

Patch

diff --git a/lib/bb/main.py b/lib/bb/main.py
index bca8ebfa0..a2285e507 100755
--- a/lib/bb/main.py
+++ b/lib/bb/main.py
@@ -468,7 +468,8 @@  def setup_bitbake(configParams, extrafeatures=None):
                     server = bb.server.process.BitBakeServer(lock, sockname, featureset, configParams.server_timeout, configParams.xmlrpcinterface, configParams.profile)
 
                 else:
-                    logger.info("Reconnecting to bitbake server...")
+                    if configParams.quiet < 2:
+                        logger.info("Reconnecting to bitbake server...")
                     if not os.path.exists(sockname):
                         logger.info("Previous bitbake instance shutting down?, waiting to retry... (%s)" % timestamp())
                         procs = bb.server.process.get_lockfile_process_msg(lockfile)
@@ -499,9 +500,11 @@  def setup_bitbake(configParams, extrafeatures=None):
                 retries -= 1
                 tryno = 8 - retries
                 if isinstance(e, (bb.server.process.ProcessTimeout, BrokenPipeError, EOFError, SystemExit)):
-                    logger.info("Retrying server connection (#%d)... (%s)" % (tryno, timestamp()))
+                    if configParams.quiet < 2:
+                        logger.info("Retrying server connection (#%d)... (%s)" % (tryno, timestamp()))
                 else:
-                    logger.info("Retrying server connection (#%d)... (%s, %s)" % (tryno, traceback.format_exc(), timestamp()))
+                    if configParams.quiet < 2:
+                        logger.info("Retrying server connection (#%d)... (%s, %s)" % (tryno, traceback.format_exc(), timestamp()))
 
             if not retries:
                 bb.fatal("Unable to connect to bitbake server, or start one (server startup failures would be in bitbake-cookerdaemon.log).")