@@ -224,7 +224,7 @@ class TestAllBuildsPage(SeleniumTestCase):
url = reverse('all-builds')
self.get(url)
- self.wait_until_visible('#allbuildstable', poll=3)
+ self.wait_until_visible('#allbuildstable')
# get the project name cells from the table
cells = self.find_all('#allbuildstable td[class="project"]')
@@ -257,7 +257,7 @@ class TestAllBuildsPage(SeleniumTestCase):
url = reverse('all-builds')
self.get(url)
- self.wait_until_visible('#allbuildstable', poll=3)
+ self.wait_until_visible('#allbuildstable')
# test recent builds area for successful build
element = self._get_build_time_element(build1)
@@ -452,7 +452,7 @@ class TestAllBuildsPage(SeleniumTestCase):
def test_show_rows(row_to_show, show_row_link):
# Check that we can show rows == row_to_show
show_row_link.select_by_value(str(row_to_show))
- self.wait_until_visible('#allbuildstable tbody tr', poll=3)
+ self.wait_until_visible('#allbuildstable tbody tr')
# check at least some rows are visible
self.assertTrue(
len(self.find_all('#allbuildstable tbody tr')) > 0
@@ -81,7 +81,7 @@ class TestAllProjectsPage(SeleniumTestCase):
def _get_row_for_project(self, project_name):
""" Get the HTML row for a project, or None if not found """
- self.wait_until_visible('#projectstable tbody tr', poll=3)
+ self.wait_until_visible('#projectstable tbody tr')
rows = self.find_all('#projectstable tbody tr')
# find the row with a project name matching the one supplied
@@ -236,7 +236,7 @@ class TestAllProjectsPage(SeleniumTestCase):
self.get(url)
# Chseck search box is present and works
- self.wait_until_visible('#projectstable tbody tr', poll=3)
+ self.wait_until_visible('#projectstable tbody tr')
search_box = self.find('#search-input-projectstable')
self.assertTrue(search_box.is_displayed())
@@ -244,7 +244,7 @@ class TestAllProjectsPage(SeleniumTestCase):
search_box.send_keys('test project 10')
search_btn = self.find('#search-submit-projectstable')
search_btn.click()
- self.wait_until_visible('#projectstable tbody tr', poll=3)
+ self.wait_until_visible('#projectstable tbody tr')
rows = self.find_all('#projectstable tbody tr')
self.assertTrue(len(rows) == 1)
@@ -290,7 +290,7 @@ class TestAllProjectsPage(SeleniumTestCase):
)
url = reverse('all-projects')
self.get(url)
- self.wait_until_visible('#projectstable tbody tr', poll=3)
+ self.wait_until_visible('#projectstable tbody tr')
# Check edit column
edit_column = self.find('#edit-columns-button')
@@ -313,7 +313,7 @@ class TestAllProjectsPage(SeleniumTestCase):
def test_show_rows(row_to_show, show_row_link):
# Check that we can show rows == row_to_show
show_row_link.select_by_value(str(row_to_show))
- self.wait_until_visible('#projectstable tbody tr', poll=3)
+ self.wait_until_visible('#projectstable tbody tr')
# check at least some rows are visible
self.assertTrue(
len(self.find_all('#projectstable tbody tr')) > 0
@@ -321,7 +321,7 @@ class TestAllProjectsPage(SeleniumTestCase):
url = reverse('all-projects')
self.get(url)
- self.wait_until_visible('#projectstable tbody tr', poll=3)
+ self.wait_until_visible('#projectstable tbody tr')
show_rows = self.driver.find_elements(
By.XPATH,
@@ -162,7 +162,7 @@ class TestBuildDashboardPage(SeleniumTestCase):
"""
url = reverse('builddashboard', args=(build.id,))
self.get(url)
- self.wait_until_visible('#global-nav', poll=3)
+ self.wait_until_visible('#global-nav')
def _get_build_dashboard_errors(self, build):
"""
@@ -224,7 +224,7 @@ class TestLandingPage(SeleniumTestCase):
self.get(reverse('landing'))
- self.wait_until_visible("#latest-builds", poll=3)
+ self.wait_until_visible("#latest-builds")
elements = self.find_all('#allbuildstable')
self.assertEqual(len(elements), 1, 'should redirect to builds')
content = self.get_page_source()
@@ -108,9 +108,9 @@ class TestLayerDetailsPage(SeleniumTestCase):
save_btn.click()
try:
- self.wait_until_visible("#save-changes-for-switch", poll=3)
+ self.wait_until_visible("#save-changes-for-switch")
btn_save_chg_for_switch = self.wait_until_clickable(
- "#save-changes-for-switch", poll=3)
+ "#save-changes-for-switch")
btn_save_chg_for_switch.click()
except ElementClickInterceptedException:
self.skipTest(
@@ -148,9 +148,9 @@ class TestLayerDetailsPage(SeleniumTestCase):
dir_input.send_keys(new_dir)
try:
- self.wait_until_visible("#save-changes-for-switch", poll=3)
+ self.wait_until_visible("#save-changes-for-switch")
btn_save_chg_for_switch = self.wait_until_clickable(
- "#save-changes-for-switch", poll=3)
+ "#save-changes-for-switch")
btn_save_chg_for_switch.click()
except ElementClickInterceptedException:
self.skipTest(
@@ -90,7 +90,7 @@ class TestNewCustomImagePage(SeleniumTestCase):
"""
url = reverse('newcustomimage', args=(self.project.id,))
self.get(url)
- self.wait_until_visible('#global-nav', poll=3)
+ self.wait_until_visible('#global-nav')
self.click('button[data-recipe="%s"]' % self.recipe.id)
@@ -47,7 +47,7 @@ class TestNewProjectPage(SeleniumTestCase):
url = reverse('newproject')
self.get(url)
- self.wait_until_visible('#new-project-name', poll=3)
+ self.wait_until_visible('#new-project-name')
self.enter_text('#new-project-name', project_name)
select = Select(self.find('#projectversion'))
@@ -58,7 +58,7 @@ class TestNewProjectPage(SeleniumTestCase):
# We should get redirected to the new project's page with the
# notification at the top
element = self.wait_until_visible(
- '#project-created-notification', poll=3)
+ '#project-created-notification')
self.assertTrue(project_name in element.text,
"New project name not in new project notification")
@@ -79,7 +79,7 @@ class TestNewProjectPage(SeleniumTestCase):
url = reverse('newproject')
self.get(url)
- self.wait_until_visible('#new-project-name', poll=3)
+ self.wait_until_visible('#new-project-name')
self.enter_text('#new-project-name', project_name)
@@ -91,7 +91,7 @@ class TestNewProjectPage(SeleniumTestCase):
self.click("#create-project-button")
- self.wait_until_present('#hint-error-project-name', poll=3)
+ self.wait_until_present('#hint-error-project-name')
element = self.find('#hint-error-project-name')
self.assertTrue(("Project names must be unique" in element.text),
In my testing I wasn't able to see issues needing the poll parameter in the browser tests. Drop those. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- lib/toaster/tests/browser/test_all_builds_page.py | 6 +++--- lib/toaster/tests/browser/test_all_projects_page.py | 12 ++++++------ .../tests/browser/test_builddashboard_page.py | 2 +- lib/toaster/tests/browser/test_landing_page.py | 2 +- lib/toaster/tests/browser/test_layerdetails_page.py | 8 ++++---- .../tests/browser/test_new_custom_image_page.py | 2 +- lib/toaster/tests/browser/test_new_project_page.py | 8 ++++---- 7 files changed, 20 insertions(+), 20 deletions(-)