[06/28] toaster/tests/function/basic: Make element detection more specific

Message ID	20241023095949.3351980-6-richard.purdie@linuxfoundation.org
State	New
Headers	show Return-Path: <richard.purdie@linuxfoundation.org> ip: 209.85.221.46, mailfrom: richard.purdie@linuxfoundation.org) From: Richard Purdie <richard.purdie@linuxfoundation.org> To: bitbake-devel@lists.openembedded.org Subject: [PATCH 06/28] toaster/tests/function/basic: Make element detection more specific Date: Wed, 23 Oct 2024 10:59:27 +0100 Message-ID: <20241023095949.3351980-6-richard.purdie@linuxfoundation.org> In-Reply-To: <20241023095949.3351980-1-richard.purdie@linuxfoundation.org> References: <20241023095949.3351980-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	[01/28] toaster/test/functional: Move _create_test_new_project to base class as helper \| expand [01/28] toaster/test/functional: Move _create_test_new_project to base class as helper [02/28] toaster/tests/functional: Tweak the project creation function for better reuse [03/28] toaster/tests/functional_basic: Reuse common project creation code [04/28] toaster/tests/project_config: Reuse common project creation code [05/28] toaster/tests/function/basic: Improve exception handling for error readability [06/28] toaster/tests/function/basic: Make element detection more specific [07/28] toaster/tests/browser: Increase the default wait timeout [08/28] toaster/tests/browser: Drop unneeded poll parameters [09/28] toaster/tests/functional/helpers: Drop unneeded poll values and sleep [10/28] toaster/tests/functional/basic: Improve the projects table selection to a common function [11/28] toaster/tests/functional/project_config: Fix the wait calls to avoid polling [12/28] toaster/tests/functiona/project_page: Switch to using library create_project function [13/28] toaster/tests/functiona/project_page: Drop pointless test covered elsewhere [14/28] toaster/tests/functiona/project_page: Improve waits and drop polling [15/28] toaster/tests/browser/helpers: Add not visible wait function [16/28] toaster/tests/functiona/project_page_tab_config: Switch to using library create_project fun… [17/28] toaster/tests/functiona/project_page_tab_config: Improve waits and drop polling [18/28] toaster/tests/browser/helpers: Drop remains of polling/sleep calls [19/28] functional/utils: Drop unused code from wait_until_build_cancelled [20/28] toaster/tests/browser/helper: Improve wait_until_clickable exception handling [21/28] toaster/tests/browser/helper: Add wait_until_element_clickable funciton [22/28] toaster/tests/browser: Add various fixes for test failures encountered [23/28] toaster/tests/functional/util: Avoid test hangs [24/28] toaster/tests/functional/project_page: Use wait_until_element_clickable before click calls [25/28] toaster/tests/browser/helper: Add wait for jquery to complete [26/28] tests/toaster/functional/utils: Handle WebDriverException [27/28] toaster/tests/browser/layerdetails: Drop unwanted test skipping/exception handling [28/28] toaster/tests/selenium_helper_base: Dump a screenshot into tmp upon failure

diff --git a/lib/toaster/tests/functional/test_functional_basic.py b/lib/toaster/tests/functional/test_functional_basic.py index a95ce4862c..c73a278f6c 100644 --- a/lib/toaster/tests/functional/test_functional_basic.py +++ b/lib/toaster/tests/functional/test_functional_basic.py @@ -31,50 +31,50 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.get(reverse('all-projects')) self.wait_until_present('#projectstable', poll=10) self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#config-nav') self.assertTrue(self.element_exists('#config-nav'),'Configuration Tab does not exist') project_URL=self.get_URL() self.driver.find_element(By.XPATH, '//a[@href="'+project_URL+'"]').click() - self.wait_until_present('#config-nav', poll=10) try: + self.wait_until_present('#config-nav') self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'customimages/"'+"]").click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#filter-modal-customimagestable') except: self.fail(msg='No Custom images tab available') self.assertTrue(re.search("Custom images",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'Custom images information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'images/"'+"]").click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#filter-modal-imagerecipestable') except: self.fail(msg='No Compatible image tab available') self.assertTrue(re.search("Compatible image recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible image recipes information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'softwarerecipes/"'+"]").click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#filter-modal-softwarerecipestable') except: self.fail(msg='No Compatible software recipe tab available') self.assertTrue(re.search("Compatible software recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible software recipe information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'machines/"'+"]").click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#filter-modal-machinestable') except: self.fail(msg='No Compatible machines tab available') self.assertTrue(re.search("Compatible machines",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible machine information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'layers/"'+"]").click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#filter-modal-layerstable') except: self.fail(msg='No Compatible layers tab available') self.assertTrue(re.search("Compatible layers",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible layer information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'configuration"'+"]").click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#configvar-list') except: self.fail(msg='No Bitbake variables tab available') self.assertTrue(re.search("Bitbake variables",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Bitbake variables information is not loading properly') @@ -85,20 +85,21 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.wait_until_present('#projectstable', poll=10) self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() project_URL=self.get_URL() - self.wait_until_present('#config-nav', poll=10) # Machine section of page + self.wait_until_visible('#machine-section') self.assertTrue(self.element_exists('#machine-section'),'Machine section for the project configuration page does not exist') self.assertTrue(re.search("qemux86-64",self.driver.find_element(By.XPATH, "//span[@id='project-machine-name']").text),'The machine type is not assigned') try: self.driver.find_element(By.XPATH, "//span[@id='change-machine-toggle']").click() - self.wait_until_visible('#select-machine-form', poll=10) - self.wait_until_visible('#cancel-machine-change', poll=10) + self.wait_until_visible('#select-machine-form') + self.wait_until_visible('#cancel-machine-change') self.driver.find_element(By.XPATH, "//form[@id='select-machine-form']/a[@id='cancel-machine-change']").click() except: self.fail(msg='The machine information is wrong in the configuration page') # Most built recipes section + self.wait_until_visible('#no-most-built') try: self.driver.find_element(By.ID, 'no-most-built') except: @@ -108,6 +109,7 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.assertTrue(re.search("Yocto Project master",self.driver.find_element(By.XPATH, "//span[@id='project-release-title']").text), 'The project release is not defined in the project detail page') # List of layers in project + self.wait_until_visible('#layer-container') self.driver.find_element(By.XPATH, "//div[@id='layer-container']") self.assertTrue(re.search("3",self.driver.find_element(By.ID, "project-layers-count").text),'There should be 3 layers listed in the layer count') try: @@ -131,14 +133,15 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.get(reverse('all-projects')) self.wait_until_present('#projectstable', poll=10) self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_visible('#machine-section') self.assertTrue(self.element_exists('#machine-section'),'Machine section for the project configuration page does not exist') + self.wait_until_visible('#project-machine-name') self.assertTrue(re.search("qemux86-64",self.driver.find_element(By.ID, "project-machine-name").text),'The machine type is not assigned') try: self.driver.find_element(By.ID, "change-machine-toggle").click() - self.wait_until_visible('#select-machine-form', poll=10) - self.wait_until_visible('#cancel-machine-change', poll=10) + self.wait_until_visible('#select-machine-form') + self.wait_until_visible('#cancel-machine-change') self.driver.find_element(By.ID, "cancel-machine-change").click() except: self.fail(msg='The machine information is wrong in the configuration page') @@ -148,14 +151,16 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.get(reverse('all-projects')) self.wait_until_present('#projectstable', poll=10) self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#config-nav') project_URL=self.get_URL() + + self.wait_until_visible('#no-most-built') self.assertTrue(re.search("You haven't built any recipes yet",self.driver.find_element(By.ID, "no-most-built").text),'Default message of no builds is not present') try: self.driver.find_element(By.XPATH, "//div[@id='no-most-built']/p/a[@href="+'"'+project_URL+'images/"'+"]").click() except: self.fail(msg='No Most built information in project detail page') - self.wait_until_present('#config-nav', poll=10) + self.wait_until_visible('#config-nav') self.assertTrue(re.search("Compatible image recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Choose a recipe to build link is not working properly') # testcase (1519) @@ -163,7 +168,7 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.get(reverse('all-projects')) self.wait_until_present('#projectstable', poll=10) self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_visible('#project-release-title') self.assertTrue(re.search("Yocto Project master",self.driver.find_element(By.ID, "project-release-title").text), 'No project release title information in project detail page') # testcase (1520) @@ -171,9 +176,11 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.get(reverse('all-projects')) self.wait_until_present('#projectstable', poll=10) self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#config-nav') project_URL=self.get_URL() + self.wait_until_visible('#layer-container') self.driver.find_element(By.XPATH, "//div[@id='layer-container']") + self.wait_until_visible('#project-layers-count') self.assertTrue(re.search("3",self.driver.find_element(By.ID, "project-layers-count").text),'There should be 3 layers listed in the layer count') try: @@ -205,18 +212,18 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.get(reverse('all-projects')) self.wait_until_present('#projectstable', poll=10) self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_present('#config-nav') project_URL=self.get_URL() self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li[@id='topbar-configuration-tab']/a[@href="+'"'+project_URL+'"'+"]").click() - self.wait_until_present('#config-nav', poll=10) + self.wait_until_visible('#topbar-configuration-tab') self.assertTrue(re.search("Configuration",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li[@id='topbar-configuration-tab']/a[@href="+'"'+project_URL+'"'+"]").text), 'Configuration tab in project topbar is misspelled') try: self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'builds/"'+"]").click() - self.wait_until_visible('#project-topbar', poll=10) except: self.fail(msg='Builds tab information is not present') + self.wait_until_visible('#project-topbar') self.assertTrue(re.search("Builds",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'builds/"'+"]").text), 'Builds tab in project topbar is misspelled') try: self.driver.find_element(By.XPATH, "//div[@id='empty-state-projectbuildstable']") @@ -225,9 +232,10 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): try: self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'importlayer"'+"]").click() - self.wait_until_visible('#project-topbar', poll=10) except: self.fail(msg='Import layer tab not loading properly') + + self.wait_until_visible('#project-topbar') self.assertTrue(re.search("Import layer",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'importlayer"'+"]").text), 'Import layer tab in project topbar is misspelled') try: self.driver.find_element(By.XPATH, "//fieldset[@id='repo-select']") @@ -237,9 +245,10 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): try: self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'newcustomimage/"'+"]").click() - self.wait_until_visible('#project-topbar', poll=10) except: self.fail(msg='New custom image tab not loading properly') + + self.wait_until_visible('#project-topbar') self.assertTrue(re.search("New custom image",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'newcustomimage/"'+"]").text), 'New custom image tab in project topbar is misspelled') self.assertTrue(re.search("Select the image recipe you want to customise",self.driver.find_element(By.XPATH, "//div[@class='col-md-12']/h2").text),'The new custom image tab is not loading correctly')

[06/28] toaster/tests/function/basic: Make element detection more specific

Commit Message

Patch