[05/28] toaster/tests/function/basic: Improve exception handling for error readability

Message ID	20241023095949.3351980-5-richard.purdie@linuxfoundation.org
State	New
Headers	show Return-Path: <richard.purdie@linuxfoundation.org> ip: 209.85.221.48, mailfrom: richard.purdie@linuxfoundation.org) From: Richard Purdie <richard.purdie@linuxfoundation.org> To: bitbake-devel@lists.openembedded.org Subject: [PATCH 05/28] toaster/tests/function/basic: Improve exception handling for error readability Date: Wed, 23 Oct 2024 10:59:26 +0100 Message-ID: <20241023095949.3351980-5-richard.purdie@linuxfoundation.org> In-Reply-To: <20241023095949.3351980-1-richard.purdie@linuxfoundation.org> References: <20241023095949.3351980-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	[01/28] toaster/test/functional: Move _create_test_new_project to base class as helper \| expand [01/28] toaster/test/functional: Move _create_test_new_project to base class as helper [02/28] toaster/tests/functional: Tweak the project creation function for better reuse [03/28] toaster/tests/functional_basic: Reuse common project creation code [04/28] toaster/tests/project_config: Reuse common project creation code [05/28] toaster/tests/function/basic: Improve exception handling for error readability [06/28] toaster/tests/function/basic: Make element detection more specific [07/28] toaster/tests/browser: Increase the default wait timeout [08/28] toaster/tests/browser: Drop unneeded poll parameters [09/28] toaster/tests/functional/helpers: Drop unneeded poll values and sleep [10/28] toaster/tests/functional/basic: Improve the projects table selection to a common function [11/28] toaster/tests/functional/project_config: Fix the wait calls to avoid polling [12/28] toaster/tests/functiona/project_page: Switch to using library create_project function [13/28] toaster/tests/functiona/project_page: Drop pointless test covered elsewhere [14/28] toaster/tests/functiona/project_page: Improve waits and drop polling [15/28] toaster/tests/browser/helpers: Add not visible wait function [16/28] toaster/tests/functiona/project_page_tab_config: Switch to using library create_project fun… [17/28] toaster/tests/functiona/project_page_tab_config: Improve waits and drop polling [18/28] toaster/tests/browser/helpers: Drop remains of polling/sleep calls [19/28] functional/utils: Drop unused code from wait_until_build_cancelled [20/28] toaster/tests/browser/helper: Improve wait_until_clickable exception handling [21/28] toaster/tests/browser/helper: Add wait_until_element_clickable funciton [22/28] toaster/tests/browser: Add various fixes for test failures encountered [23/28] toaster/tests/functional/util: Avoid test hangs [24/28] toaster/tests/functional/project_page: Use wait_until_element_clickable before click calls [25/28] toaster/tests/browser/helper: Add wait for jquery to complete [26/28] tests/toaster/functional/utils: Handle WebDriverException [27/28] toaster/tests/browser/layerdetails: Drop unwanted test skipping/exception handling [28/28] toaster/tests/selenium_helper_base: Dump a screenshot into tmp upon failure

diff --git a/lib/toaster/tests/functional/test_functional_basic.py b/lib/toaster/tests/functional/test_functional_basic.py index e2d1c7dd86..a95ce4862c 100644 --- a/lib/toaster/tests/functional/test_functional_basic.py +++ b/lib/toaster/tests/functional/test_functional_basic.py @@ -40,44 +40,44 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'customimages/"'+"]").click() self.wait_until_present('#config-nav', poll=10) - self.assertTrue(re.search("Custom images",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'Custom images information is not loading properly') except: self.fail(msg='No Custom images tab available') + self.assertTrue(re.search("Custom images",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'Custom images information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'images/"'+"]").click() self.wait_until_present('#config-nav', poll=10) - self.assertTrue(re.search("Compatible image recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible image recipes information is not loading properly') except: self.fail(msg='No Compatible image tab available') + self.assertTrue(re.search("Compatible image recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible image recipes information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'softwarerecipes/"'+"]").click() self.wait_until_present('#config-nav', poll=10) - self.assertTrue(re.search("Compatible software recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible software recipe information is not loading properly') except: self.fail(msg='No Compatible software recipe tab available') + self.assertTrue(re.search("Compatible software recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible software recipe information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'machines/"'+"]").click() self.wait_until_present('#config-nav', poll=10) - self.assertTrue(re.search("Compatible machines",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible machine information is not loading properly') except: self.fail(msg='No Compatible machines tab available') + self.assertTrue(re.search("Compatible machines",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible machine information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'layers/"'+"]").click() self.wait_until_present('#config-nav', poll=10) - self.assertTrue(re.search("Compatible layers",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible layer information is not loading properly') except: self.fail(msg='No Compatible layers tab available') + self.assertTrue(re.search("Compatible layers",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Compatible layer information is not loading properly') try: self.driver.find_element(By.XPATH, "//*[@id='config-nav']/ul/li/a[@href="+'"'+project_URL+'configuration"'+"]").click() self.wait_until_present('#config-nav', poll=10) - self.assertTrue(re.search("Bitbake variables",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Bitbake variables information is not loading properly') except: self.fail(msg='No Bitbake variables tab available') + self.assertTrue(re.search("Bitbake variables",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Bitbake variables information is not loading properly') # testcase (1516) def test_review_configuration_information(self): @@ -86,9 +86,11 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() project_URL=self.get_URL() self.wait_until_present('#config-nav', poll=10) + + # Machine section of page + self.assertTrue(self.element_exists('#machine-section'),'Machine section for the project configuration page does not exist') + self.assertTrue(re.search("qemux86-64",self.driver.find_element(By.XPATH, "//span[@id='project-machine-name']").text),'The machine type is not assigned') try: - self.assertTrue(self.element_exists('#machine-section'),'Machine section for the project configuration page does not exist') - self.assertTrue(re.search("qemux86-64",self.driver.find_element(By.XPATH, "//span[@id='project-machine-name']").text),'The machine type is not assigned') self.driver.find_element(By.XPATH, "//span[@id='change-machine-toggle']").click() self.wait_until_visible('#select-machine-form', poll=10) self.wait_until_visible('#cancel-machine-change', poll=10) @@ -96,33 +98,34 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): except: self.fail(msg='The machine information is wrong in the configuration page') + # Most built recipes section try: self.driver.find_element(By.ID, 'no-most-built') except: self.fail(msg='No Most built information in project detail page') - try: - self.assertTrue(re.search("Yocto Project master",self.driver.find_element(By.XPATH, "//span[@id='project-release-title']").text),'The project release is not defined') - except: - self.fail(msg='No project release title information in project detail page') + # Project Release title + self.assertTrue(re.search("Yocto Project master",self.driver.find_element(By.XPATH, "//span[@id='project-release-title']").text), 'The project release is not defined in the project detail page') + # List of layers in project + self.driver.find_element(By.XPATH, "//div[@id='layer-container']") + self.assertTrue(re.search("3",self.driver.find_element(By.ID, "project-layers-count").text),'There should be 3 layers listed in the layer count') try: - self.driver.find_element(By.XPATH, "//div[@id='layer-container']") - self.assertTrue(re.search("3",self.driver.find_element(By.ID, "project-layers-count").text),'There should be 3 layers listed in the layer count') layer_list = self.driver.find_element(By.ID, "layers-in-project-list") layers = layer_list.find_elements(By.TAG_NAME, "li") - for layer in layers: - if re.match ("openembedded-core",layer.text): - print ("openembedded-core layer is a default layer in the project configuration") - elif re.match ("meta-poky",layer.text): - print ("meta-poky layer is a default layer in the project configuration") - elif re.match ("meta-yocto-bsp",layer.text): - print ("meta-yocto-bsp is a default layer in the project configuratoin") - else: - self.fail(msg='default layers are missing from the project configuration') except: self.fail(msg='No Layer information in project detail page') + for layer in layers: + if re.match ("openembedded-core", layer.text): + print ("openembedded-core layer is a default layer in the project configuration") + elif re.match ("meta-poky", layer.text): + print ("meta-poky layer is a default layer in the project configuration") + elif re.match ("meta-yocto-bsp", layer.text): + print ("meta-yocto-bsp is a default layer in the project configuratoin") + else: + self.fail(msg='default layers are missing from the project configuration') + # testcase (1517) def test_verify_machine_information(self): self.get(reverse('all-projects')) @@ -130,9 +133,9 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() self.wait_until_present('#config-nav', poll=10) + self.assertTrue(self.element_exists('#machine-section'),'Machine section for the project configuration page does not exist') + self.assertTrue(re.search("qemux86-64",self.driver.find_element(By.ID, "project-machine-name").text),'The machine type is not assigned') try: - self.assertTrue(self.element_exists('#machine-section'),'Machine section for the project configuration page does not exist') - self.assertTrue(re.search("qemux86-64",self.driver.find_element(By.ID, "project-machine-name").text),'The machine type is not assigned') self.driver.find_element(By.ID, "change-machine-toggle").click() self.wait_until_visible('#select-machine-form', poll=10) self.wait_until_visible('#cancel-machine-change', poll=10) @@ -147,13 +150,13 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() self.wait_until_present('#config-nav', poll=10) project_URL=self.get_URL() + self.assertTrue(re.search("You haven't built any recipes yet",self.driver.find_element(By.ID, "no-most-built").text),'Default message of no builds is not present') try: - self.assertTrue(re.search("You haven't built any recipes yet",self.driver.find_element(By.ID, "no-most-built").text),'Default message of no builds is not present') self.driver.find_element(By.XPATH, "//div[@id='no-most-built']/p/a[@href="+'"'+project_URL+'images/"'+"]").click() - self.wait_until_present('#config-nav', poll=10) - self.assertTrue(re.search("Compatible image recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Choose a recipe to build link is not working properly') except: self.fail(msg='No Most built information in project detail page') + self.wait_until_present('#config-nav', poll=10) + self.assertTrue(re.search("Compatible image recipes",self.driver.find_element(By.XPATH, "//div[@class='col-md-10']").text),'The Choose a recipe to build link is not working properly') # testcase (1519) def test_verify_project_release_information(self): @@ -161,11 +164,7 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.wait_until_present('#projectstable', poll=10) self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() self.wait_until_present('#config-nav', poll=10) - - try: - self.assertTrue(re.search("Yocto Project master",self.driver.find_element(By.ID, "project-release-title").text),'The project release is not defined') - except: - self.fail(msg='No project release title information in project detail page') + self.assertTrue(re.search("Yocto Project master",self.driver.find_element(By.ID, "project-release-title").text), 'No project release title information in project detail page') # testcase (1520) def test_verify_layer_information(self): @@ -174,28 +173,32 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): self.find_element_by_link_text_in_table('projectstable', 'selenium-project').click() self.wait_until_present('#config-nav', poll=10) project_URL=self.get_URL() + self.driver.find_element(By.XPATH, "//div[@id='layer-container']") + self.assertTrue(re.search("3",self.driver.find_element(By.ID, "project-layers-count").text),'There should be 3 layers listed in the layer count') + try: - self.driver.find_element(By.XPATH, "//div[@id='layer-container']") - self.assertTrue(re.search("3",self.driver.find_element(By.ID, "project-layers-count").text),'There should be 3 layers listed in the layer count') layer_list = self.driver.find_element(By.ID, "layers-in-project-list") layers = layer_list.find_elements(By.TAG_NAME, "li") + except: + self.fail(msg='No Layer information in project detail page') - for layer in layers: - if re.match ("openembedded-core",layer.text): - print ("openembedded-core layer is a default layer in the project configuration") - elif re.match ("meta-poky",layer.text): - print ("meta-poky layer is a default layer in the project configuration") - elif re.match ("meta-yocto-bsp",layer.text): - print ("meta-yocto-bsp is a default layer in the project configuratoin") - else: - self.fail(msg='default layers are missing from the project configuration') + for layer in layers: + if re.match ("openembedded-core",layer.text): + print ("openembedded-core layer is a default layer in the project configuration") + elif re.match ("meta-poky",layer.text): + print ("meta-poky layer is a default layer in the project configuration") + elif re.match ("meta-yocto-bsp",layer.text): + print ("meta-yocto-bsp is a default layer in the project configuratoin") + else: + self.fail(msg='default layers are missing from the project configuration') + try: self.driver.find_element(By.XPATH, "//input[@id='layer-add-input']") self.driver.find_element(By.XPATH, "//button[@id='add-layer-btn']") self.driver.find_element(By.XPATH, "//div[@id='layer-container']/form[@class='form-inline']/p/a[@id='view-compatible-layers']") self.driver.find_element(By.XPATH, "//div[@id='layer-container']/form[@class='form-inline']/p/a[@href="+'"'+project_URL+'importlayer"'+"]") except: - self.fail(msg='No Layer information in project detail page') + self.fail(msg='Layer configuration controls missing') # testcase (1521) def test_verify_project_detail_links(self): @@ -211,7 +214,11 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): try: self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'builds/"'+"]").click() self.wait_until_visible('#project-topbar', poll=10) - self.assertTrue(re.search("Builds",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'builds/"'+"]").text), 'Builds tab in project topbar is misspelled') + except: + self.fail(msg='Builds tab information is not present') + + self.assertTrue(re.search("Builds",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'builds/"'+"]").text), 'Builds tab in project topbar is misspelled') + try: self.driver.find_element(By.XPATH, "//div[@id='empty-state-projectbuildstable']") except: self.fail(msg='Builds tab information is not present') @@ -219,7 +226,10 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): try: self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'importlayer"'+"]").click() self.wait_until_visible('#project-topbar', poll=10) - self.assertTrue(re.search("Import layer",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'importlayer"'+"]").text), 'Import layer tab in project topbar is misspelled') + except: + self.fail(msg='Import layer tab not loading properly') + self.assertTrue(re.search("Import layer",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'importlayer"'+"]").text), 'Import layer tab in project topbar is misspelled') + try: self.driver.find_element(By.XPATH, "//fieldset[@id='repo-select']") self.driver.find_element(By.XPATH, "//fieldset[@id='git-repo']") except: @@ -228,10 +238,10 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase): try: self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'newcustomimage/"'+"]").click() self.wait_until_visible('#project-topbar', poll=10) - self.assertTrue(re.search("New custom image",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'newcustomimage/"'+"]").text), 'New custom image tab in project topbar is misspelled') - self.assertTrue(re.search("Select the image recipe you want to customise",self.driver.find_element(By.XPATH, "//div[@class='col-md-12']/h2").text),'The new custom image tab is not loading correctly') except: self.fail(msg='New custom image tab not loading properly') + self.assertTrue(re.search("New custom image",self.driver.find_element(By.XPATH, "//div[@id='project-topbar']/ul[@class='nav nav-tabs']/li/a[@href="+'"'+project_URL+'newcustomimage/"'+"]").text), 'New custom image tab in project topbar is misspelled') + self.assertTrue(re.search("Select the image recipe you want to customise",self.driver.find_element(By.XPATH, "//div[@class='col-md-12']/h2").text),'The new custom image tab is not loading correctly')

[05/28] toaster/tests/function/basic: Improve exception handling for error readability

Commit Message

Patch