| Message ID | 20240604142803.3658144-1-richard.purdie@linuxfoundation.org |
|---|---|
| State | Accepted, archived |
| Commit | 2c8fa57778c4bd2a5c48a60b701ac57de4289cb2 |
| Headers | show |
| Series | [1/2] siggen: Drop copy_unihashes function | expand |
Hello Richard, On 04/06/2024 15:28:02+0100, Richard Purdie wrote: > The code in OE-Core using this has been replaced with something more fit > for purpose. Drop these function calls as they were never a great idea in the > first place and cause IO slowdown for runqueue needing to sync the cache. > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > --- > lib/bb/siggen.py | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py > index 92066da00c..89b70fb6a4 100644 > --- a/lib/bb/siggen.py > +++ b/lib/bb/siggen.py > @@ -201,9 +201,6 @@ class SignatureGenerator(object): > def save_unitaskhashes(self): > return > > - def copy_unitaskhashes(self, targetdir): > - return > - > def set_setscene_tasks(self, setscene_tasks): > return > > @@ -418,9 +415,6 @@ class SignatureGeneratorBasic(SignatureGenerator): > def save_unitaskhashes(self): > self.unihash_cache.save(self.unitaskhashes) > > - def copy_unitaskhashes(self, targetdir): > - self.unihash_cache.copyfile(targetdir) > - It breaks sstatetests.SStateBundles.test_minimal_bundle which uses copy_unitaskhashes > def dump_sigtask(self, mcfn, task, stampbase, runtime): > tid = mcfn + ":" + task > mc = bb.runqueue.mc_from_tid(mcfn) > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#16316): https://lists.openembedded.org/g/bitbake-devel/message/16316 > Mute This Topic: https://lists.openembedded.org/mt/106483284/3617179 > Group Owner: bitbake-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Sat, 2024-06-08 at 12:16 +0200, Alexandre Belloni wrote: > Hello Richard, > > > On 04/06/2024 15:28:02+0100, Richard Purdie wrote: > > The code in OE-Core using this has been replaced with something > > more fit > > for purpose. Drop these function calls as they were never a great > > idea in the > > first place and cause IO slowdown for runqueue needing to sync the > > cache. > > > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > > --- > > lib/bb/siggen.py | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py > > index 92066da00c..89b70fb6a4 100644 > > --- a/lib/bb/siggen.py > > +++ b/lib/bb/siggen.py > > @@ -201,9 +201,6 @@ class SignatureGenerator(object): > > def save_unitaskhashes(self): > > return > > > > - def copy_unitaskhashes(self, targetdir): > > - return > > - > > def set_setscene_tasks(self, setscene_tasks): > > return > > > > @@ -418,9 +415,6 @@ class > > SignatureGeneratorBasic(SignatureGenerator): > > def save_unitaskhashes(self): > > self.unihash_cache.save(self.unitaskhashes) > > > > - def copy_unitaskhashes(self, targetdir): > > - self.unihash_cache.copyfile(targetdir) > > - > > It breaks sstatetests.SStateBundles.test_minimal_bundle which uses > copy_unitaskhashes Is that patch only in your -next branch? I didn't see this issue in my own testing which makes me wonder... Cheers, Richard
I think it’s in my patch set for build replication that needs to be reworked to not use the function and should be dropped until then. Alex On Sat 8. Jun 2024 at 12.18, Richard Purdie via lists.openembedded.org <richard.purdie=linuxfoundation.org@lists.openembedded.org> wrote: > On Sat, 2024-06-08 at 12:16 +0200, Alexandre Belloni wrote: > > Hello Richard, > > > > > > On 04/06/2024 15:28:02+0100, Richard Purdie wrote: > > > The code in OE-Core using this has been replaced with something > > > more fit > > > for purpose. Drop these function calls as they were never a great > > > idea in the > > > first place and cause IO slowdown for runqueue needing to sync the > > > cache. > > > > > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > > > --- > > > lib/bb/siggen.py | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py > > > index 92066da00c..89b70fb6a4 100644 > > > --- a/lib/bb/siggen.py > > > +++ b/lib/bb/siggen.py > > > @@ -201,9 +201,6 @@ class SignatureGenerator(object): > > > def save_unitaskhashes(self): > > > return > > > > > > - def copy_unitaskhashes(self, targetdir): > > > - return > > > - > > > def set_setscene_tasks(self, setscene_tasks): > > > return > > > > > > @@ -418,9 +415,6 @@ class > > > SignatureGeneratorBasic(SignatureGenerator): > > > def save_unitaskhashes(self): > > > self.unihash_cache.save(self.unitaskhashes) > > > > > > - def copy_unitaskhashes(self, targetdir): > > > - self.unihash_cache.copyfile(targetdir) > > > - > > > > It breaks sstatetests.SStateBundles.test_minimal_bundle which uses > > copy_unitaskhashes > > > Is that patch only in your -next branch? I didn't see this issue in my > own testing which makes me wonder... > > Cheers, > > Richard > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#16331): > https://lists.openembedded.org/g/bitbake-devel/message/16331 > Mute This Topic: https://lists.openembedded.org/mt/106483284/1686489 > Group Owner: bitbake-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [ > alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On 08/06/2024 11:18:48+0100, Richard Purdie wrote: > On Sat, 2024-06-08 at 12:16 +0200, Alexandre Belloni wrote: > > Hello Richard, > > > > > > On 04/06/2024 15:28:02+0100, Richard Purdie wrote: > > > The code in OE-Core using this has been replaced with something > > > more fit > > > for purpose. Drop these function calls as they were never a great > > > idea in the > > > first place and cause IO slowdown for runqueue needing to sync the > > > cache. > > > > > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > > > --- > > > �lib/bb/siggen.py | 6 ------ > > > �1 file changed, 6 deletions(-) > > > > > > diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py > > > index 92066da00c..89b70fb6a4 100644 > > > --- a/lib/bb/siggen.py > > > +++ b/lib/bb/siggen.py > > > @@ -201,9 +201,6 @@ class SignatureGenerator(object): > > > ���� def save_unitaskhashes(self): > > > �������� return > > > � > > > -��� def copy_unitaskhashes(self, targetdir): > > > -������� return > > > - > > > ���� def set_setscene_tasks(self, setscene_tasks): > > > �������� return > > > � > > > @@ -418,9 +415,6 @@ class > > > SignatureGeneratorBasic(SignatureGenerator): > > > ���� def save_unitaskhashes(self): > > > �������� self.unihash_cache.save(self.unitaskhashes) > > > � > > > -��� def copy_unitaskhashes(self, targetdir): > > > -������� self.unihash_cache.copyfile(targetdir) > > > - > > > > It breaks sstatetests.SStateBundles.test_minimal_bundle which uses > > copy_unitaskhashes > > > Is that patch only in your -next branch? I didn't see this issue in my > own testing which makes me wonder... You are right, git blame told me it was applied a month ag and I didn't check further. I'll drop the patch.
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py index 92066da00c..89b70fb6a4 100644 --- a/lib/bb/siggen.py +++ b/lib/bb/siggen.py @@ -201,9 +201,6 @@ class SignatureGenerator(object): def save_unitaskhashes(self): return - def copy_unitaskhashes(self, targetdir): - return - def set_setscene_tasks(self, setscene_tasks): return @@ -418,9 +415,6 @@ class SignatureGeneratorBasic(SignatureGenerator): def save_unitaskhashes(self): self.unihash_cache.save(self.unitaskhashes) - def copy_unitaskhashes(self, targetdir): - self.unihash_cache.copyfile(targetdir) - def dump_sigtask(self, mcfn, task, stampbase, runtime): tid = mcfn + ":" + task mc = bb.runqueue.mc_from_tid(mcfn)
The code in OE-Core using this has been replaced with something more fit for purpose. Drop these function calls as they were never a great idea in the first place and cause IO slowdown for runqueue needing to sync the cache. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- lib/bb/siggen.py | 6 ------ 1 file changed, 6 deletions(-)