diff mbox series

[1/2] cooker: Improve handling errors during parsing when profiling

Message ID 20240530142654.3095813-1-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 171bd9dd575307fbd61b5179ad86131d76add067
Headers show
Series [1/2] cooker: Improve handling errors during parsing when profiling | expand

Commit Message

Richard Purdie May 30, 2024, 2:26 p.m. UTC 
We've seeing profiling tracebacks when parse errors occur during
profiling. Try and avoid these but not processing invalid profiles.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 lib/bb/cooker.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py
index 255b9f199a..673af8daec 100644
--- a/lib/bb/cooker.py
+++ b/lib/bb/cooker.py
@@ -2236,12 +2236,13 @@  class CookerParser(object):
             profiles = []
             for i in self.process_names:
                 logfile = "profile-parse-%s.log" % i
-                if os.path.exists(logfile):
+                if os.path.exists(logfile) and os.path.getsize(logfile):
                     profiles.append(logfile)
 
-            pout = "profile-parse.log.processed"
-            bb.utils.process_profilelog(profiles, pout = pout)
-            print("Processed parsing statistics saved to %s" % (pout))
+            if profiles:
+                pout = "profile-parse.log.processed"
+                bb.utils.process_profilelog(profiles, pout = pout)
+                print("Processed parsing statistics saved to %s" % (pout))
 
     def final_cleanup(self):
         if self.syncthread: