diff mbox series

bitbake: fetch2/npmsw: Check if there are dependencies before trying to fetch them

Message ID 20230720234121.168334-1-m.belouarga@technologyandstrategy.com
State Accepted, archived
Commit 48a102e49448656ef25fb689af7b0971fde523e3
Headers show
Series bitbake: fetch2/npmsw: Check if there are dependencies before trying to fetch them | expand

Commit Message

belouargamohamed@gmail.com July 20, 2023, 11:41 p.m. UTC 
From: BELOUARGA Mohamed <m.belouarga@technologyandstrategy.com>

When there are no dependencies, _foreach_proxy_method does not verify that there are
dependencies to fetch before fetching them.

Signed-off-by: BELOUARGA Mohamed <m.belouarga@technologyandstrategy.com>
---
 lib/bb/fetch2/npmsw.py | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
diff mbox series

Patch

diff --git a/lib/bb/fetch2/npmsw.py b/lib/bb/fetch2/npmsw.py
index 971ccc9050..4ff2c8ffc3 100644
--- a/lib/bb/fetch2/npmsw.py
+++ b/lib/bb/fetch2/npmsw.py
@@ -225,13 +225,15 @@  class NpmShrinkWrap(FetchMethod):
     @staticmethod
     def _foreach_proxy_method(ud, handle):
         returns = []
-        for proxy_url in ud.proxy.urls:
-            proxy_ud = ud.proxy.ud[proxy_url]
-            proxy_d = ud.proxy.d
-            proxy_ud.setup_localpath(proxy_d)
-            lf = lockfile(proxy_ud.lockfile)
-            returns.append(handle(proxy_ud.method, proxy_ud, proxy_d))
-            unlockfile(lf)
+        #Check if there are dependencies before try to fetch them
+        if len(ud.deps) > 0:
+            for proxy_url in ud.proxy.urls:
+                proxy_ud = ud.proxy.ud[proxy_url]
+                proxy_d = ud.proxy.d
+                proxy_ud.setup_localpath(proxy_d)
+                lf = lockfile(proxy_ud.lockfile)
+                returns.append(handle(proxy_ud.method, proxy_ud, proxy_d))
+                unlockfile(lf)
         return returns
 
     def verify_donestamp(self, ud, d):