| Message ID | 20221116122125.2564989-2-richard.purdie@linuxfoundation.org |
|---|---|
| State | Accepted, archived |
| Commit | 6b24efc0f4d19738d96754280e70bc493005167d |
| Headers | show |
| Series | [1/2] cache: Drop broken/unused code | expand |
> -----Original Message----- > From: bitbake-devel@lists.openembedded.org <bitbake-devel@lists.openembedded.org> On Behalf Of Richard Purdie > Sent: den 16 november 2022 13:21 > To: bitbake-devel@lists.openembedded.org > Subject: [bitbake-devel] [PATCH 2/2] cache: Drop unused function > > At this point users appear to all cann add_info directly. Failing Change "cann" to "call". > to do that means the file dependency tracking code isn't active > so would cause problems. Therefore drop the unused function. > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > --- > lib/bb/cache.py | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/lib/bb/cache.py b/lib/bb/cache.py > index 22ca6f56e6..22ed3e80be 100644 > --- a/lib/bb/cache.py > +++ b/lib/bb/cache.py > @@ -649,18 +649,6 @@ class Cache(object): > self.cacheclean = False > self.depends_cache[filename] = info_array > > - def add(self, file_name, data, cacheData, parsed=None): > - """ > - Save data we need into the cache > - """ > - > - realfn = virtualfn2realfn(file_name)[0] > - > - info_array = [] > - for cache_class in self.caches_array: > - info_array.append(cache_class(realfn, data)) > - self.add_info(file_name, info_array, cacheData, parsed) > - > class MulticonfigCache(Mapping): > def __init__(self, databuilder, data_hash, caches_array): > def progress(p): > -- > 2.34.1 //Peter
diff --git a/lib/bb/cache.py b/lib/bb/cache.py index 22ca6f56e6..22ed3e80be 100644 --- a/lib/bb/cache.py +++ b/lib/bb/cache.py @@ -649,18 +649,6 @@ class Cache(object): self.cacheclean = False self.depends_cache[filename] = info_array - def add(self, file_name, data, cacheData, parsed=None): - """ - Save data we need into the cache - """ - - realfn = virtualfn2realfn(file_name)[0] - - info_array = [] - for cache_class in self.caches_array: - info_array.append(cache_class(realfn, data)) - self.add_info(file_name, info_array, cacheData, parsed) - class MulticonfigCache(Mapping): def __init__(self, databuilder, data_hash, caches_array): def progress(p):
At this point users appear to all cann add_info directly. Failing to do that means the file dependency tracking code isn't active so would cause problems. Therefore drop the unused function. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- lib/bb/cache.py | 12 ------------ 1 file changed, 12 deletions(-)