diff mbox series

[bitbake-devel] bb/utils: remove: check the path again the expand python glob

Message ID 20220719093902.91911-1-jose.quaresma@foundries.io
State New
Headers show
Series [bitbake-devel] bb/utils: remove: check the path again the expand python glob | expand

Commit Message

Jose Quaresma July 19, 2022, 9:39 a.m. UTC
When we call the remove with recurse=True we first check if the
remove operation is safe in _check_unsafe_delete_path.
But the check is been done on the path instaed of the expanded
python glog.

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
---
 lib/bb/utils.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/lib/bb/utils.py b/lib/bb/utils.py
index 3abc4938..19ed68ea 100644
--- a/lib/bb/utils.py
+++ b/lib/bb/utils.py
@@ -692,8 +692,8 @@  def remove(path, recurse=False, ionice=False):
         return
     if recurse:
         for name in glob.glob(path):
-            if _check_unsafe_delete_path(path):
-                raise Exception('bb.utils.remove: called with dangerous path "%s" and recurse=True, refusing to delete!' % path)
+            if _check_unsafe_delete_path(name):
+                raise Exception('bb.utils.remove: called with dangerous path "%s" and recurse=True, refusing to delete!' % name)
         # shutil.rmtree(name) would be ideal but its too slow
         cmd = []
         if ionice: