| Message ID | 20251203-bitbake-setup-input-consistent-v1-0-3c7e6edecd57@cherry.de |
|---|---|
| Headers | show |
| Series | bitbake-setup: improve consistency in prompts | expand |
Thanks, all three lgtm. Alex On Wed, 3 Dec 2025 at 13:15, Quentin Schulz via lists.openembedded.org <foss=0leil.net@lists.openembedded.org> wrote: > > The prompts for integer inputs are displaying the user input after the > line while string inputs are displaying the user input next to the > prompt. This aligns the behavior to have the user input next to the > prompt in all cases, even for numbers, even for retries. > > This also fixes what could be said to be a typo: the colon was added > before the default value for one prompt instead of after, confusing me a > bit as to what was expected from me. > > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > --- > Quentin Schulz (3): > bitbake-setup: allow to pass a prompt to int_input > bitbake-setup: make all callers of int_input pass their prompt > bitbake-setup: put colon of prompt after suggested default > > bin/bitbake-setup | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > --- > base-commit: 720df1a53452983c1c832f624490e255cf389204 > change-id: 20251203-bitbake-setup-input-consistent-1186fa1d45a3 > > Best regards, > -- > Quentin Schulz <quentin.schulz@cherry.de> > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#18523): https://lists.openembedded.org/g/bitbake-devel/message/18523 > Mute This Topic: https://lists.openembedded.org/mt/116592605/1686489 > Group Owner: bitbake-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
The prompts for integer inputs are displaying the user input after the line while string inputs are displaying the user input next to the prompt. This aligns the behavior to have the user input next to the prompt in all cases, even for numbers, even for retries. This also fixes what could be said to be a typo: the colon was added before the default value for one prompt instead of after, confusing me a bit as to what was expected from me. Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> --- Quentin Schulz (3): bitbake-setup: allow to pass a prompt to int_input bitbake-setup: make all callers of int_input pass their prompt bitbake-setup: put colon of prompt after suggested default bin/bitbake-setup | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) --- base-commit: 720df1a53452983c1c832f624490e255cf389204 change-id: 20251203-bitbake-setup-input-consistent-1186fa1d45a3 Best regards,