mbox series

[v4,0/2] bitbake-setup: update: add a --update-bb-conf option

Message ID 20251118-bitbake-setup-conf-updates-v4-0-7336b663bca6@bootlin.com
Headers show
Series bitbake-setup: update: add a --update-bb-conf option | expand

Message

Antonin Godard Nov. 18, 2025, 8:19 a.m. UTC
Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
---
Changes in v4:
- Simplify argument passing in build_status(), as suggested by Alex
- Link to v3: https://lore.kernel.org/r/20251117-bitbake-setup-conf-updates-v3-0-46cdf826e79c@bootlin.com

Changes in v3:
- bitbake-setup:
  - Change the conf diff logic as suggested by Alex.
  - Use args in build_status() to get update_bb_conf.
  - Use get_diff() instead of git diff in _setup_bitbake_build()
- test:
  - Use hashlib update() instead of file_digest() for
    backwards-compatibility.
  - When computing checkum check that the item returned by glob.glob is
    a file and not a link (previously it would have tried to open a
    directory).
- Link to v2: https://lore.kernel.org/r/20251117-bitbake-setup-conf-updates-v2-0-209637e01fbe@bootlin.com

Changes in v2:
- As suggested by Alex, Rework the logic to apply upstream configuration
  changes first, then print the diff and ask the user whether to apply
  or not (default behavior).
- Behavior can still be overridden with --update-bb-conf='yes/no/prompt'
- Link to v1: https://lore.kernel.org/r/20251114-bitbake-setup-conf-updates-v1-0-990583d8251b@bootlin.com

---
Antonin Godard (2):
      bitbake-setup: update: add a --update-bb-conf option
      bitbake-selftest: setup: add test for --update-bb-conf=no

 bin/bitbake-setup                                  | 53 ++++++++++++++++------
 .../bitbake-user-manual-environment-setup.rst      |  8 ++++
 lib/bb/tests/setup.py                              | 41 +++++++++++++++--
 3 files changed, 84 insertions(+), 18 deletions(-)
---
base-commit: ae9a70c919f14ca323eb7c03ef9080fd0bd52c29
change-id: 20251114-bitbake-setup-conf-updates-91ae4efa86ae

Comments

Alexander Kanavin Nov. 18, 2025, 9:28 a.m. UTC | #1
Thanks, I think this patchset is now ready.

I'm glad there are now several people that actually know the code;
that means you can experiment and implement your own ideas :)

Alex

On Tue, 18 Nov 2025 at 09:20, Antonin Godard via
lists.yoctoproject.org
<antonin.godard=bootlin.com@lists.yoctoproject.org> wrote:
>
> Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
> ---
> Changes in v4:
> - Simplify argument passing in build_status(), as suggested by Alex
> - Link to v3: https://lore.kernel.org/r/20251117-bitbake-setup-conf-updates-v3-0-46cdf826e79c@bootlin.com
>
> Changes in v3:
> - bitbake-setup:
>   - Change the conf diff logic as suggested by Alex.
>   - Use args in build_status() to get update_bb_conf.
>   - Use get_diff() instead of git diff in _setup_bitbake_build()
> - test:
>   - Use hashlib update() instead of file_digest() for
>     backwards-compatibility.
>   - When computing checkum check that the item returned by glob.glob is
>     a file and not a link (previously it would have tried to open a
>     directory).
> - Link to v2: https://lore.kernel.org/r/20251117-bitbake-setup-conf-updates-v2-0-209637e01fbe@bootlin.com
>
> Changes in v2:
> - As suggested by Alex, Rework the logic to apply upstream configuration
>   changes first, then print the diff and ask the user whether to apply
>   or not (default behavior).
> - Behavior can still be overridden with --update-bb-conf='yes/no/prompt'
> - Link to v1: https://lore.kernel.org/r/20251114-bitbake-setup-conf-updates-v1-0-990583d8251b@bootlin.com
>
> ---
> Antonin Godard (2):
>       bitbake-setup: update: add a --update-bb-conf option
>       bitbake-selftest: setup: add test for --update-bb-conf=no
>
>  bin/bitbake-setup                                  | 53 ++++++++++++++++------
>  .../bitbake-user-manual-environment-setup.rst      |  8 ++++
>  lib/bb/tests/setup.py                              | 41 +++++++++++++++--
>  3 files changed, 84 insertions(+), 18 deletions(-)
> ---
> base-commit: ae9a70c919f14ca323eb7c03ef9080fd0bd52c29
> change-id: 20251114-bitbake-setup-conf-updates-91ae4efa86ae
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8068): https://lists.yoctoproject.org/g/docs/message/8068
> Mute This Topic: https://lists.yoctoproject.org/mt/116353215/1686489
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>