diff mbox series

[1/3] CI: always save the lockfile.yml in update-repos

Message ID 20250401130909.2924629-1-ross.burton@arm.com
State New
Headers show
Series [1/3] CI: always save the lockfile.yml in update-repos | expand

Commit Message

Ross Burton April 1, 2025, 1:09 p.m. UTC
The update-repos job can "fail with warnings" if the reference repository
fetch fails. This is intentionally a warning as the CI may have set
KAS_PREMIRRORS and a stale cache is fine.

However, by default artifacts are only saved on successful jobs, so if
this happens the lockfile.yml isn't saved. Ensure the artifacts are
always saved so the rest of the pipeline is successful.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .gitlab-ci.yml | 1 +
 1 file changed, 1 insertion(+)

Comments

Jon Mason April 2, 2025, 3:33 a.m. UTC | #1
On Tue, 01 Apr 2025 14:09:07 +0100, Ross Burton wrote:
> The update-repos job can "fail with warnings" if the reference repository
> fetch fails. This is intentionally a warning as the CI may have set
> KAS_PREMIRRORS and a stale cache is fine.
> 
> However, by default artifacts are only saved on successful jobs, so if
> this happens the lockfile.yml isn't saved. Ensure the artifacts are
> always saved so the rest of the pipeline is successful.
> 
> [...]

Applied, thanks!

[1/3] CI: always save the lockfile.yml in update-repos
      commit: c8da42d7bd3dfcdd89d639db83adbb1ae656b437
[2/3] CI: disable KAS_REPO_REF_DIR by default
      commit: 9b92d080b156cc0adb5d6fe3870bd488faddca61
[3/3] CI: dump all environment variables in update-repos
      commit: 2cc1cd16ab943a9f6317ea165d193f5668694096

Best regards,
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 6d613e45..2337f957 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -114,6 +114,7 @@  update-repos:
       exit $exit_code
   artifacts:
     name: "lockfile"
+    when: always
     paths:
       - lockfile.yml