diff mbox series

external-arm-toolchain: Enforce absolute path check

Message ID 20230620131639.40137-1-sumit.garg@linaro.org
State New
Headers show
Series external-arm-toolchain: Enforce absolute path check | expand

Commit Message

Sumit Garg June 20, 2023, 1:16 p.m. UTC
EXTERNAL_TOOLCHAIN variable should provide absolute path to external Arm
toolchain install directory. So make that absolute path check explicit.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
---
 meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jon Mason June 21, 2023, 4:08 a.m. UTC | #1
On Tue, 20 Jun 2023 18:46:39 +0530, Sumit Garg wrote:
> EXTERNAL_TOOLCHAIN variable should provide absolute path to external Arm
> toolchain install directory. So make that absolute path check explicit.

Applied, thanks!

[1/1] external-arm-toolchain: Enforce absolute path check
      commit: e6301496ce84eabaedf3dcddaa63a33ffc26be55

Best regards,
diff mbox series

Patch

diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
index 71fac597..88b694f8 100644
--- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
+++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
@@ -79,6 +79,9 @@  python toolchain_metadata_setup () {
     if not external_toolchain or external_toolchain == 'UNDEFINED':
         bb.fatal("Error: EXTERNAL_TOOLCHAIN must be set to the path to your arm toolchain")
 
+    if not os.path.isabs(external_toolchain):
+        bb.fatal("Error: EXTERNAL_TOOLCHAIN path '%s' must be absolute path" % external_toolchain)
+
     if not os.path.exists(external_toolchain):
         bb.fatal("Error: EXTERNAL_TOOLCHAIN path '%s' does not exist" % external_toolchain)