Message ID | 20220804094231.748681-1-Martin.Jansa@gmail.com |
---|---|
State | New |
Headers | show |
Series | [kirkstone] arm-toolchain/layer.conf: remove BB_DANGLINGAPPENDS_WARNONLY | expand |
Odd email format. I beleive you are asking me to apply this patch to kirkstone. If not, please let me know. Sumit/Denys, should I apply this all the way back to dunfell (as the grub entry is there in this oldest branch)? Thanks, Jon On Thu, Aug 04, 2022 at 11:42:31AM +0200, Martin Jansa wrote: > From: Ross Burton <ross.burton@arm.com> > > This appears to be historical from when the toolchain was in meta-linaro. > > It isn't needed anymore, there's one bbappend in meta-arm-toolchain for > grub which is part of oe-core, so will never be dangling. > > This variable has a global effect, so leaving it in here has a negative > impact on users. > > Signed-off-by: Ross Burton <ross.burton@arm.com> > Signed-off-by: Jon Mason <jon.mason@arm.com> > --- > meta-arm-toolchain/conf/layer.conf | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf > index 3512c34..dd54db8 100644 > --- a/meta-arm-toolchain/conf/layer.conf > +++ b/meta-arm-toolchain/conf/layer.conf > @@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5" > LAYERDEPENDS_arm-toolchain = "core" > LAYERSERIES_COMPAT_arm-toolchain = "kirkstone" > > -# do not error out on bbappends for missing recipes > -BB_DANGLINGAPPENDS_WARNONLY = "true" > - > # These variables are used for armcompiler license > BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE" > -- > 2.35.1 > >
Hi Jon, On Thu, 4 Aug 2022 at 18:36, Jon Mason <jdmason@kudzu.us> wrote: > > Odd email format. I beleive you are asking me to apply this patch to > kirkstone. If not, please let me know. > > Sumit/Denys, should I apply this all the way back to dunfell (as the > grub entry is there in this oldest branch)? > Yeah, it makes sense. -Sumit > Thanks, > Jon > > On Thu, Aug 04, 2022 at 11:42:31AM +0200, Martin Jansa wrote: > > From: Ross Burton <ross.burton@arm.com> > > > > This appears to be historical from when the toolchain was in meta-linaro. > > > > It isn't needed anymore, there's one bbappend in meta-arm-toolchain for > > grub which is part of oe-core, so will never be dangling. > > > > This variable has a global effect, so leaving it in here has a negative > > impact on users. > > > > Signed-off-by: Ross Burton <ross.burton@arm.com> > > Signed-off-by: Jon Mason <jon.mason@arm.com> > > --- > > meta-arm-toolchain/conf/layer.conf | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf > > index 3512c34..dd54db8 100644 > > --- a/meta-arm-toolchain/conf/layer.conf > > +++ b/meta-arm-toolchain/conf/layer.conf > > @@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5" > > LAYERDEPENDS_arm-toolchain = "core" > > LAYERSERIES_COMPAT_arm-toolchain = "kirkstone" > > > > -# do not error out on bbappends for missing recipes > > -BB_DANGLINGAPPENDS_WARNONLY = "true" > > - > > # These variables are used for armcompiler license > > BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE" > > -- > > 2.35.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#3642): https://lists.yoctoproject.org/g/meta-arm/message/3642 > Mute This Topic: https://lists.yoctoproject.org/mt/92810132/1777089 > Group Owner: meta-arm+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [sumit.garg@linaro.org] > -=-=-=-=-=-=-=-=-=-=-=- >
On Thu, Aug 04, 2022 at 06:37:09PM +0530, Sumit Garg wrote: > Hi Jon, > > On Thu, 4 Aug 2022 at 18:36, Jon Mason <jdmason@kudzu.us> wrote: > > > > Odd email format. I beleive you are asking me to apply this patch to > > kirkstone. If not, please let me know. > > > > Sumit/Denys, should I apply this all the way back to dunfell (as the > > grub entry is there in this oldest branch)? > > > > Yeah, it makes sense. I agree - this hasn't been needed for quite some time.
On Thu, Aug 04, 2022 at 11:47:20AM -0400, Denys Dmytriyenko wrote: > On Thu, Aug 04, 2022 at 06:37:09PM +0530, Sumit Garg wrote: > > Hi Jon, > > > > On Thu, 4 Aug 2022 at 18:36, Jon Mason <jdmason@kudzu.us> wrote: > > > > > > Odd email format. I beleive you are asking me to apply this patch to > > > kirkstone. If not, please let me know. > > > > > > Sumit/Denys, should I apply this all the way back to dunfell (as the > > > grub entry is there in this oldest branch)? > > > > > > > Yeah, it makes sense. > > I agree - this hasn't been needed for quite some time. > Removing it has found a bug (of course). Testing a fix now. Sorry for the delay. Thanks, Jon > -- > Denys > > > > > On Thu, Aug 04, 2022 at 11:42:31AM +0200, Martin Jansa wrote: > > > > From: Ross Burton <ross.burton@arm.com> > > > > > > > > This appears to be historical from when the toolchain was in meta-linaro. > > > > > > > > It isn't needed anymore, there's one bbappend in meta-arm-toolchain for > > > > grub which is part of oe-core, so will never be dangling. > > > > > > > > This variable has a global effect, so leaving it in here has a negative > > > > impact on users. > > > > > > > > Signed-off-by: Ross Burton <ross.burton@arm.com> > > > > Signed-off-by: Jon Mason <jon.mason@arm.com> > > > > --- > > > > meta-arm-toolchain/conf/layer.conf | 3 --- > > > > 1 file changed, 3 deletions(-) > > > > > > > > diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf > > > > index 3512c34..dd54db8 100644 > > > > --- a/meta-arm-toolchain/conf/layer.conf > > > > +++ b/meta-arm-toolchain/conf/layer.conf > > > > @@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5" > > > > LAYERDEPENDS_arm-toolchain = "core" > > > > LAYERSERIES_COMPAT_arm-toolchain = "kirkstone" > > > > > > > > -# do not error out on bbappends for missing recipes > > > > -BB_DANGLINGAPPENDS_WARNONLY = "true" > > > > - > > > > # These variables are used for armcompiler license > > > > BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE" > > > > -- > > > > 2.35.1 >
diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf index 3512c34..dd54db8 100644 --- a/meta-arm-toolchain/conf/layer.conf +++ b/meta-arm-toolchain/conf/layer.conf @@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5" LAYERDEPENDS_arm-toolchain = "core" LAYERSERIES_COMPAT_arm-toolchain = "kirkstone" -# do not error out on bbappends for missing recipes -BB_DANGLINGAPPENDS_WARNONLY = "true" - # These variables are used for armcompiler license BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"