| Message ID | 20220517122818.3324458-1-ross.burton@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] arm-toolchain/external-arm-toolchain: set the version in the recipe | expand |
On Tue, 17 May 2022 13:28:16 +0100, Ross Burton wrote: > We need to support multiple versions of external-arm-toolchain, partly as > different versions have different layouts on disk, and partly because > 11.2 doesn't work on pre-Broadwell hardware. > > Rename this recipe so the version is in the filename, and dynamically > set PKGV instead of PV so PREFERRED_VERSION is easier to use. Applied, thanks! [1/3] arm-toolchain/external-arm-toolchain: set the version in the recipe commit: ac83feb7cd16265d4e8ee0ed50dba903306867e5 [2/3] arm-toolchain/external-arm-toolchain: add back 10.3 commit: 5fec85b41d7263dcc8aa15351beb7c19e2017849 [3/3] CI: use external-arm-toolchain 10.3 commit: 4c6ccb833c1ac379df3efa02136e03067d89ef3e Best regards,
+ Denys Hi Jon, On Tue, 17 May 2022 at 20:54, Jon Mason <jdmason@kudzu.us> wrote: > > On Tue, 17 May 2022 13:28:16 +0100, Ross Burton wrote: > > We need to support multiple versions of external-arm-toolchain, partly as > > different versions have different layouts on disk, and partly because > > 11.2 doesn't work on pre-Broadwell hardware. > > > > Rename this recipe so the version is in the filename, and dynamically > > set PKGV instead of PV so PREFERRED_VERSION is easier to use. > > Applied, thanks! > > [1/3] arm-toolchain/external-arm-toolchain: set the version in the recipe > commit: ac83feb7cd16265d4e8ee0ed50dba903306867e5 > [2/3] arm-toolchain/external-arm-toolchain: add back 10.3 > commit: 5fec85b41d7263dcc8aa15351beb7c19e2017849 Can you please revert these two patches? We don't need duplicates for external-arm-toolchain recipe. The latest version supports both 11.2 and 10.3. So the only thing that's required is patch #3. -Sumit > [3/3] CI: use external-arm-toolchain 10.3 > commit: 4c6ccb833c1ac379df3efa02136e03067d89ef3e > > Best regards, > -- > Jon Mason <jon.mason@arm.com> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#3420): https://lists.yoctoproject.org/g/meta-arm/message/3420 > Mute This Topic: https://lists.yoctoproject.org/mt/91162100/1777089 > Group Owner: meta-arm+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [sumit.garg@linaro.org] > -=-=-=-=-=-=-=-=-=-=-=- >
:facepalm: Testing now, thanks. Ross From: Sumit Garg <sumit.garg@linaro.org> Date: Tuesday, 17 May 2022 at 17:07 To: Jon Mason <jdmason@kudzu.us> Cc: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>, Ross Burton <Ross.Burton@arm.com>, nd <nd@arm.com>, Denys Dmytriyenko <denis@denix.org> Subject: Re: [meta-arm] [PATCH 1/3] arm-toolchain/external-arm-toolchain: set the version in the recipe + Denys Hi Jon, On Tue, 17 May 2022 at 20:54, Jon Mason <jdmason@kudzu.us> wrote: > > On Tue, 17 May 2022 13:28:16 +0100, Ross Burton wrote: > > We need to support multiple versions of external-arm-toolchain, partly as > > different versions have different layouts on disk, and partly because > > 11.2 doesn't work on pre-Broadwell hardware. > > > > Rename this recipe so the version is in the filename, and dynamically > > set PKGV instead of PV so PREFERRED_VERSION is easier to use. > > Applied, thanks! > > [1/3] arm-toolchain/external-arm-toolchain: set the version in the recipe > commit: ac83feb7cd16265d4e8ee0ed50dba903306867e5 > [2/3] arm-toolchain/external-arm-toolchain: add back 10.3 > commit: 5fec85b41d7263dcc8aa15351beb7c19e2017849 Can you please revert these two patches? We don't need duplicates for external-arm-toolchain recipe. The latest version supports both 11.2 and 10.3. So the only thing that's required is patch #3. -Sumit > [3/3] CI: use external-arm-toolchain 10.3 > commit: 4c6ccb833c1ac379df3efa02136e03067d89ef3e > > Best regards, > -- > Jon Mason <jon.mason@arm.com> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#3420): https://lists.yoctoproject.org/g/meta-arm/message/3420 > Mute This Topic: https://lists.yoctoproject.org/mt/91162100/1777089 > Group Owner: meta-arm+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [sumit.garg@linaro.org] > -=-=-=-=-=-=-=-=-=-=-=- >
On Tue, 17 May 2022 13:28:16 +0100, Ross Burton wrote: > We need to support multiple versions of external-arm-toolchain, partly as > different versions have different layouts on disk, and partly because > 11.2 doesn't work on pre-Broadwell hardware. > > Rename this recipe so the version is in the filename, and dynamically > set PKGV instead of PV so PREFERRED_VERSION is easier to use. Applied, thanks! [1/3] arm-toolchain/external-arm-toolchain: set the version in the recipe (no commit info) [2/3] arm-toolchain/external-arm-toolchain: add back 10.3 (no commit info) [3/3] CI: use external-arm-toolchain 10.3 commit: fc09cc0e8db287600625e64905170a6de24f2686 Best regards,
On Tue, May 17, 2022 at 09:37:25PM +0530, Sumit Garg wrote: > + Denys > > Hi Jon, > > On Tue, 17 May 2022 at 20:54, Jon Mason <jdmason@kudzu.us> wrote: > > > > On Tue, 17 May 2022 13:28:16 +0100, Ross Burton wrote: > > > We need to support multiple versions of external-arm-toolchain, partly as > > > different versions have different layouts on disk, and partly because > > > 11.2 doesn't work on pre-Broadwell hardware. > > > > > > Rename this recipe so the version is in the filename, and dynamically > > > set PKGV instead of PV so PREFERRED_VERSION is easier to use. > > > > Applied, thanks! > > > > [1/3] arm-toolchain/external-arm-toolchain: set the version in the recipe > > commit: ac83feb7cd16265d4e8ee0ed50dba903306867e5 > > [2/3] arm-toolchain/external-arm-toolchain: add back 10.3 > > commit: 5fec85b41d7263dcc8aa15351beb7c19e2017849 > > Can you please revert these two patches? We don't need duplicates for > external-arm-toolchain recipe. The latest version supports both 11.2 > and 10.3. So the only thing that's required is patch #3. Sorry, I was traveling last week and missed this. As Sumit correctly says, the recipe is version agnostic on purpose and supports multiple versions of the binary toolchain.
On Tue, 17 May 2022 13:28:16 +0100, Ross Burton wrote: > We need to support multiple versions of external-arm-toolchain, partly as > different versions have different layouts on disk, and partly because > 11.2 doesn't work on pre-Broadwell hardware. > > Rename this recipe so the version is in the filename, and dynamically > set PKGV instead of PV so PREFERRED_VERSION is easier to use. Applied, thanks! [1/3] arm-toolchain/external-arm-toolchain: set the version in the recipe (no commit info) [2/3] arm-toolchain/external-arm-toolchain: add back 10.3 (no commit info) [3/3] CI: use external-arm-toolchain 10.3 commit: fc09cc0e8db287600625e64905170a6de24f2686 Best regards,
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain_11.2-2022.02.bb similarity index 99% rename from meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb rename to meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain_11.2-2022.02.bb index dcc8ebf0..0b2d3238 100644 --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain_11.2-2022.02.bb @@ -51,7 +51,7 @@ PROVIDES += "\ virtual/libc-locale \ " -PV = "${EAT_VER_MAIN}" +PKGV = "${EAT_VER_MAIN}" BINV = "${EAT_VER_GCC}"
We need to support multiple versions of external-arm-toolchain, partly as different versions have different layouts on disk, and partly because 11.2 doesn't work on pre-Broadwell hardware. Rename this recipe so the version is in the filename, and dynamically set PKGV instead of PV so PREFERRED_VERSION is easier to use. Signed-off-by: Ross Burton <ross.burton@arm.com> --- ...-arm-toolchain.bb => external-arm-toolchain_11.2-2022.02.bb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename meta-arm-toolchain/recipes-devtools/external-arm-toolchain/{external-arm-toolchain.bb => external-arm-toolchain_11.2-2022.02.bb} (99%)