diff mbox series

[meta-arago,master/wrynose,v2] chromium: restrict force-h264-youtube extension to supported boards

Message ID 20260911183900.631578-1-t-lannynd@ti.com
State New
Headers show
Series [meta-arago,master/wrynose,v2] chromium: restrict force-h264-youtube extension to supported boards | expand

Commit Message

Thorsten Lannynd Sept. 11, 2026, 6:39 p.m. UTC
Split force-h264-youtube into its own package, enabled only on boards that support
H264 YouTube hardware accelerated playback.

Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>
---

v2:
- Shorten commit message title

 .../chromium/chromium-ozone-wayland-arago.inc | 29 ++++++++++++++-----
 1 file changed, 22 insertions(+), 7 deletions(-)

Comments

PRC Automation Sept. 11, 2026, 6:45 p.m. UTC | #1
meta-arago / na / 20260911183900.631578-1-t-lannynd

PRC Results: FAIL

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed



=========================================================
  apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [meta-arago][master/wrynose][PATCH v2] chromium: restrict force-h264-youtube extension to supported boards
- Submitter: From: Thorsten Lannynd <t-lannynd@ti.com>
- Date: Date: Fri, 11 Sep 2026 13:39:00 -0500
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 715d6e9c817282eb3e7d6dbfb9f9f497db8e7485

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: master-wip
- Commit Author: Ryan Eatmon <reatmon@ti.com>
- Commit Subject: netopeer2-server: Patch for OpenSSL 4.0
- Commit SHA: 745d80a58f87d57cbccbf78d4a956b5611488a02

Patches
----------------------------------------
All patches applied

wrynose
=====================
Summary:
- Patch Series: [meta-arago][master/wrynose][PATCH v2] chromium: restrict force-h264-youtube extension to supported boards
- Submitter: From: Thorsten Lannynd <t-lannynd@ti.com>
- Date: Date: Fri, 11 Sep 2026 13:39:00 -0500
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 715d6e9c817282eb3e7d6dbfb9f9f497db8e7485

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: wrynose-wip
- Commit Author: Ryan Eatmon <reatmon@ti.com>
- Commit Subject: gstreamer1.0-plugins-good: Move to 1.28.4
- Commit SHA: dc357c044e81825a503aa301d1b90eab41c1f714

Patches
----------------------------------------
All patches applied



=========================================================
  check-yocto-repo: FAIL
=========================================================
master
=====================
FAIL
    WARN: The use of :append with other overrides needs to be manually checked. (APPEND-1)
        meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc:29
            RRECOMMENDS:${PN}:append = " ${@bb.utils.contains('CHROMIUM_H264_EXT', '1', '${PN}-force-h264-youtube', '', d)}"
    
    For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887

wrynose
=====================
FAIL
    WARN: The use of :append with other overrides needs to be manually checked. (APPEND-1)
        meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc:29
            RRECOMMENDS:${PN}:append = " ${@bb.utils.contains('CHROMIUM_H264_EXT', '1', '${PN}-force-h264-youtube', '', d)}"
    
    For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
Ryan Eatmon Sept. 11, 2026, 10:13 p.m. UTC | #2
On 9/11/2026 1:39 PM, Thorsten Lannynd wrote:
> Split force-h264-youtube into its own package, enabled only on boards that support
> H264 YouTube hardware accelerated playback.
> 
> Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>
> ---
> 
> v2:
> - Shorten commit message title
> 
>   .../chromium/chromium-ozone-wayland-arago.inc | 29 ++++++++++++++-----
>   1 file changed, 22 insertions(+), 7 deletions(-)
> 
> diff --git a/meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc b/meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc
> index d8eb0204..108f77c7 100644
> --- a/meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc
> +++ b/meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc
> @@ -1,6 +1,6 @@
>   PR:append = ".arago0"
>   
> -EXTENSION_DIR = "/usr/lib/chromium/extensions/force-h264-youtube"
> +EXTENSION_DIR = "${libdir}/chromium/extensions/force-h264-youtube"
>   
>   FILESEXTRAPATHS:prepend := "${THISDIR}/chromium-ozone-wayland:"
>   
> @@ -15,11 +15,26 @@ SRC_URI:append = " \
>                     file://force-h264-youtube/manifest.json \
>                     "
>   
> +PACKAGES:append = " ${PN}-force-h264-youtube"
> +FILES:${PN}-force-h264-youtube = "${EXTENSION_DIR}"
> +RDEPENDS:${PN}-force-h264-youtube = "${PN}"
> +
> +CHROMIUM_H264_EXT ?= ""
> +CHROMIUM_H264_EXT:am62pxx-evm = "1"
> +CHROMIUM_H264_EXT:j721s2-evm  = "1"
> +CHROMIUM_H264_EXT:j722s-evm   = "1"
> +CHROMIUM_H264_EXT:j742s2-evm  = "1"
> +CHROMIUM_H264_EXT:j784s4-evm  = "1"

Would it be better to create a MACHINE_FEATURES for h264 and then have 
this just key off that.  Then you could send a second patch to 
meta-ti-bsp that adds that feature?

Denys, thoughts?


> +RRECOMMENDS:${PN}:append = " ${@bb.utils.contains('CHROMIUM_H264_EXT', '1', '${PN}-force-h264-youtube', '', d)}"
> +
>   do_install:append() {
> -    install -d ${D}${EXTENSION_DIR}
> -    install -m 0644 ${WORKDIR}/sources/force-h264-youtube/force_h264.js \
> -                    ${WORKDIR}/sources/force-h264-youtube/manifest.json \
> -                    ${D}${EXTENSION_DIR}/
> +    if [ -n "${CHROMIUM_H264_EXT}" ]; then
> +        install -d ${D}${EXTENSION_DIR}
> +        install -m 0644 ${WORKDIR}/sources/force-h264-youtube/force_h264.js \
> +                        ${WORKDIR}/sources/force-h264-youtube/manifest.json \
> +                        ${D}${EXTENSION_DIR}/
> +        sed -i "s|CHROME_EXTRA_ARGS=\"\(.*\)\"|CHROME_EXTRA_ARGS=\"\1 --load-extension=${EXTENSION_DIR}\"|" \
> +            ${D}${libdir}/chromium/chromium-wrapper
> +    fi
>   }
> -
> -FILES:${PN}:append = " ${EXTENSION_DIR}"
diff mbox series

Patch

diff --git a/meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc b/meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc
index d8eb0204..108f77c7 100644
--- a/meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc
+++ b/meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland-arago.inc
@@ -1,6 +1,6 @@ 
 PR:append = ".arago0"
 
-EXTENSION_DIR = "/usr/lib/chromium/extensions/force-h264-youtube"
+EXTENSION_DIR = "${libdir}/chromium/extensions/force-h264-youtube"
 
 FILESEXTRAPATHS:prepend := "${THISDIR}/chromium-ozone-wayland:"
 
@@ -15,11 +15,26 @@  SRC_URI:append = " \
                   file://force-h264-youtube/manifest.json \
                   "
 
+PACKAGES:append = " ${PN}-force-h264-youtube"
+FILES:${PN}-force-h264-youtube = "${EXTENSION_DIR}"
+RDEPENDS:${PN}-force-h264-youtube = "${PN}"
+
+CHROMIUM_H264_EXT ?= ""
+CHROMIUM_H264_EXT:am62pxx-evm = "1"
+CHROMIUM_H264_EXT:j721s2-evm  = "1"
+CHROMIUM_H264_EXT:j722s-evm   = "1"
+CHROMIUM_H264_EXT:j742s2-evm  = "1"
+CHROMIUM_H264_EXT:j784s4-evm  = "1"
+
+RRECOMMENDS:${PN}:append = " ${@bb.utils.contains('CHROMIUM_H264_EXT', '1', '${PN}-force-h264-youtube', '', d)}"
+
 do_install:append() {
-    install -d ${D}${EXTENSION_DIR}
-    install -m 0644 ${WORKDIR}/sources/force-h264-youtube/force_h264.js \
-                    ${WORKDIR}/sources/force-h264-youtube/manifest.json \
-                    ${D}${EXTENSION_DIR}/
+    if [ -n "${CHROMIUM_H264_EXT}" ]; then
+        install -d ${D}${EXTENSION_DIR}
+        install -m 0644 ${WORKDIR}/sources/force-h264-youtube/force_h264.js \
+                        ${WORKDIR}/sources/force-h264-youtube/manifest.json \
+                        ${D}${EXTENSION_DIR}/
+        sed -i "s|CHROME_EXTRA_ARGS=\"\(.*\)\"|CHROME_EXTRA_ARGS=\"\1 --load-extension=${EXTENSION_DIR}\"|" \
+            ${D}${libdir}/chromium/chromium-wrapper
+    fi
 }
-
-FILES:${PN}:append = " ${EXTENSION_DIR}"