| Message ID | 20260105221926.2503358-2-afd@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-arago,master,1/2] shadow-securetty: Remove unneeded recipe | expand |
This one may not work. This assumes that you have ti-test intstalled (which not all images do). And without ti-test in the image, then you cannot telnet to the board during test. On 1/5/2026 4:19 PM, Andrew Davis wrote: > These are only used (and only ever should be used) in testing images. > Move these out of the base distro images and only into images including > the ti-test packagegroup. Move the recipes themselves also over to > meta-arago-test. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > check_yocto_rules.json | 4 ++-- > .../recipes-core/packagegroups/packagegroup-arago-base.bb | 2 -- > .../initscript-telnetd/initscript-telnetd.bb | 0 > .../initscript-telnetd/initscript-telnetd/telnetd | 0 > .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb | 0 > .../systemd-telnetd/systemd-telnetd/telnetd.service | 0 > meta-arago-test/recipes-core/packagegroups/ti-test.bb | 2 ++ > 7 files changed, 4 insertions(+), 4 deletions(-) > rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) > rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) > rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) > rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%) > > diff --git a/check_yocto_rules.json b/check_yocto_rules.json > index 7b3e20db..26275421 100644 > --- a/check_yocto_rules.json > +++ b/check_yocto_rules.json > @@ -27,8 +27,6 @@ > "PV-1" :{ > "skip_files" : [ > "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb", > - "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", > - "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", > "meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb", > "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb", > "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb", > @@ -38,6 +36,8 @@ > "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb", > "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb", > "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb" > + "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", > + "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", > ] > } > } > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb > index b80697e5..d36b4397 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb > @@ -16,8 +16,6 @@ ARAGO_BASE = "\ > mtd-utils \ > mtd-utils-ubifs \ > curl \ > - initscript-telnetd \ > - systemd-telnetd \ > ethtool \ > bash \ > opkg-bash-completion \ > diff --git a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb > similarity index 100% > rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb > rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb > diff --git a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd > similarity index 100% > rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd > rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd > diff --git a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb > similarity index 100% > rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb > rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb > diff --git a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service > similarity index 100% > rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service > rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service > diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > index 22957218..ebac81c2 100644 > --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb > +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > @@ -22,6 +22,7 @@ TI_TEST_BASE = "\ > hwspinlocktest \ > hdparm \ > i2c-tools \ > + initscript-telnetd \ > iozone3 \ > iproute2-tc \ > iproute2-devlink \ > @@ -57,6 +58,7 @@ TI_TEST_BASE = "\ > stress \ > stress-ng \ > strongswan \ > + systemd-telnetd \ > tcpdump \ > v4l-utils \ > xdp-tools-arago \
Maybe we should make a ti-test-core? or ti-test-required? And put things like this into that package and have it in ti-test as well. Then we could change the image dependencies to require the new ti-test-required... Would that work? On 1/5/2026 4:23 PM, Ryan Eatmon via lists.yoctoproject.org wrote: > > This one may not work. This assumes that you have ti-test intstalled > (which not all images do). And without ti-test in the image, then you > cannot telnet to the board during test. > > > On 1/5/2026 4:19 PM, Andrew Davis wrote: >> These are only used (and only ever should be used) in testing images. >> Move these out of the base distro images and only into images including >> the ti-test packagegroup. Move the recipes themselves also over to >> meta-arago-test. >> >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> check_yocto_rules.json | 4 ++-- >> .../recipes-core/packagegroups/packagegroup-arago-base.bb | 2 -- >> .../initscript-telnetd/initscript-telnetd.bb | 0 >> .../initscript-telnetd/initscript-telnetd/telnetd | 0 >> .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb | 0 >> .../systemd-telnetd/systemd-telnetd/telnetd.service | 0 >> meta-arago-test/recipes-core/packagegroups/ti-test.bb | 2 ++ >> 7 files changed, 4 insertions(+), 4 deletions(-) >> rename {meta-arago-distro => >> meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) >> rename {meta-arago-distro => >> meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) >> rename {meta-arago-distro => >> meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) >> rename {meta-arago-distro => >> meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%) >> >> diff --git a/check_yocto_rules.json b/check_yocto_rules.json >> index 7b3e20db..26275421 100644 >> --- a/check_yocto_rules.json >> +++ b/check_yocto_rules.json >> @@ -27,8 +27,6 @@ >> "PV-1" :{ >> "skip_files" : [ >> >> "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb", >> - >> "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", >> - >> "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", >> >> "meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb", >> >> "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb", >> >> "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb", >> @@ -38,6 +36,8 @@ >> >> "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb", >> >> "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb", >> >> "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb" >> + >> "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", >> + >> "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", >> ] >> } >> } >> diff --git >> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> index b80697e5..d36b4397 100644 >> --- >> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> +++ >> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> @@ -16,8 +16,6 @@ ARAGO_BASE = "\ >> mtd-utils \ >> mtd-utils-ubifs \ >> curl \ >> - initscript-telnetd \ >> - systemd-telnetd \ >> ethtool \ >> bash \ >> opkg-bash-completion \ >> diff --git >> a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >> similarity index 100% >> rename from >> meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >> rename to >> meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >> diff --git >> a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >> similarity index 100% >> rename from >> meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >> rename to >> meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >> diff --git >> a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >> similarity index 100% >> rename from >> meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >> rename to >> meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >> diff --git >> a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >> similarity index 100% >> rename from >> meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >> rename to >> meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >> diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb >> b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >> index 22957218..ebac81c2 100644 >> --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb >> +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >> @@ -22,6 +22,7 @@ TI_TEST_BASE = "\ >> hwspinlocktest \ >> hdparm \ >> i2c-tools \ >> + initscript-telnetd \ >> iozone3 \ >> iproute2-tc \ >> iproute2-devlink \ >> @@ -57,6 +58,7 @@ TI_TEST_BASE = "\ >> stress \ >> stress-ng \ >> strongswan \ >> + systemd-telnetd \ >> tcpdump \ >> v4l-utils \ >> xdp-tools-arago \ >
On 1/5/26 4:23 PM, Ryan Eatmon wrote: > > This one may not work. This assumes that you have ti-test intstalled (which not all images do). And without ti-test in the image, then you cannot telnet to the board during test. > Why would you need to telnet onto a board to check on test if you are not testing? If you are testing, then you would have ti-test. Removing this from images that are not specifically meant for use by our test automation is 100% intentional. Right now anyone can telnet into, as root, without a password, all of our images. As much as we love to claim no one should be using these images as a base for their production image, absolutly every single customer is anyway. Which means we have a huge security foot-gun here, and customers *will* end up shipping devices with this massive security issue. Andrew > > On 1/5/2026 4:19 PM, Andrew Davis wrote: >> These are only used (and only ever should be used) in testing images. >> Move these out of the base distro images and only into images including >> the ti-test packagegroup. Move the recipes themselves also over to >> meta-arago-test. >> >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> check_yocto_rules.json | 4 ++-- >> .../recipes-core/packagegroups/packagegroup-arago-base.bb | 2 -- >> .../initscript-telnetd/initscript-telnetd.bb | 0 >> .../initscript-telnetd/initscript-telnetd/telnetd | 0 >> .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb | 0 >> .../systemd-telnetd/systemd-telnetd/telnetd.service | 0 >> meta-arago-test/recipes-core/packagegroups/ti-test.bb | 2 ++ >> 7 files changed, 4 insertions(+), 4 deletions(-) >> rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) >> rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) >> rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) >> rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%) >> >> diff --git a/check_yocto_rules.json b/check_yocto_rules.json >> index 7b3e20db..26275421 100644 >> --- a/check_yocto_rules.json >> +++ b/check_yocto_rules.json >> @@ -27,8 +27,6 @@ >> "PV-1" :{ >> "skip_files" : [ >> "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb", >> - "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", >> - "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", >> "meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb", >> "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb", >> "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb", >> @@ -38,6 +36,8 @@ >> "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb", >> "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb", >> "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb" >> + "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", >> + "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", >> ] >> } >> } >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> index b80697e5..d36b4397 100644 >> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> @@ -16,8 +16,6 @@ ARAGO_BASE = "\ >> mtd-utils \ >> mtd-utils-ubifs \ >> curl \ >> - initscript-telnetd \ >> - systemd-telnetd \ >> ethtool \ >> bash \ >> opkg-bash-completion \ >> diff --git a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >> similarity index 100% >> rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >> rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >> diff --git a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >> similarity index 100% >> rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >> rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >> diff --git a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >> similarity index 100% >> rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >> rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >> diff --git a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >> similarity index 100% >> rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >> rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >> diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >> index 22957218..ebac81c2 100644 >> --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb >> +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >> @@ -22,6 +22,7 @@ TI_TEST_BASE = "\ >> hwspinlocktest \ >> hdparm \ >> i2c-tools \ >> + initscript-telnetd \ >> iozone3 \ >> iproute2-tc \ >> iproute2-devlink \ >> @@ -57,6 +58,7 @@ TI_TEST_BASE = "\ >> stress \ >> stress-ng \ >> strongswan \ >> + systemd-telnetd \ >> tcpdump \ >> v4l-utils \ >> xdp-tools-arago \ >
On 1/5/2026 5:36 PM, Andrew Davis wrote: > On 1/5/26 4:23 PM, Ryan Eatmon wrote: >> >> This one may not work. This assumes that you have ti-test intstalled >> (which not all images do). And without ti-test in the image, then you >> cannot telnet to the board during test. >> > > Why would you need to telnet onto a board to check on test if you are > not testing? If you are testing, then you would have ti-test. The base image is kept small to do network based tests. They then install the ti-test package from the NAS. But that assumes that the test framework could telnet to the board after boot in order to run commands... That's the scenario I'm thinking of. The best solution is to update all of the tests to use ssh, but that still means we are still hardcoding something in the file system to allow connecting in a bad way. What if we also combined the above with a variable that we set in the local.conf during our builds, but is off by default. And that varible override would make us include the ti-test-required. We could even just add that setting to the local.conf... > Removing this from images that are not specifically meant for use by our > test automation is 100% intentional. Right now anyone can telnet into, > as root, without a password, all of our images. As much as we love to claim > no one should be using these images as a base for their production image, > absolutly every single customer is anyway. Which means we have a huge > security foot-gun here, and customers *will* end up shipping devices with > this massive security issue. > > Andrew > >> >> On 1/5/2026 4:19 PM, Andrew Davis wrote: >>> These are only used (and only ever should be used) in testing images. >>> Move these out of the base distro images and only into images including >>> the ti-test packagegroup. Move the recipes themselves also over to >>> meta-arago-test. >>> >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> --- >>> check_yocto_rules.json | 4 ++-- >>> .../recipes-core/packagegroups/packagegroup-arago-base.bb | 2 -- >>> .../initscript-telnetd/initscript-telnetd.bb | 0 >>> .../initscript-telnetd/initscript-telnetd/telnetd | 0 >>> .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb | 0 >>> .../systemd-telnetd/systemd-telnetd/telnetd.service | 0 >>> meta-arago-test/recipes-core/packagegroups/ti-test.bb | 2 ++ >>> 7 files changed, 4 insertions(+), 4 deletions(-) >>> rename {meta-arago-distro => >>> meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) >>> rename {meta-arago-distro => >>> meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) >>> rename {meta-arago-distro => >>> meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) >>> rename {meta-arago-distro => >>> meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%) >>> >>> diff --git a/check_yocto_rules.json b/check_yocto_rules.json >>> index 7b3e20db..26275421 100644 >>> --- a/check_yocto_rules.json >>> +++ b/check_yocto_rules.json >>> @@ -27,8 +27,6 @@ >>> "PV-1" :{ >>> "skip_files" : [ >>> >>> "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb", >>> - >>> "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", >>> - >>> "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", >>> >>> "meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb", >>> >>> "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb", >>> >>> "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb", >>> @@ -38,6 +36,8 @@ >>> >>> "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb", >>> >>> "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb", >>> >>> "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb" >>> + >>> "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", >>> + >>> "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", >>> ] >>> } >>> } >>> diff --git >>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >>> index b80697e5..d36b4397 100644 >>> --- >>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >>> +++ >>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >>> @@ -16,8 +16,6 @@ ARAGO_BASE = "\ >>> mtd-utils \ >>> mtd-utils-ubifs \ >>> curl \ >>> - initscript-telnetd \ >>> - systemd-telnetd \ >>> ethtool \ >>> bash \ >>> opkg-bash-completion \ >>> diff --git >>> a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >>> similarity index 100% >>> rename from >>> meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >>> rename to >>> meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb >>> diff --git >>> a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >>> similarity index 100% >>> rename from >>> meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >>> rename to >>> meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd >>> diff --git >>> a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >>> similarity index 100% >>> rename from >>> meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >>> rename to >>> meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb >>> diff --git >>> a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >>> similarity index 100% >>> rename from >>> meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >>> rename to >>> meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service >>> diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> index 22957218..ebac81c2 100644 >>> --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> @@ -22,6 +22,7 @@ TI_TEST_BASE = "\ >>> hwspinlocktest \ >>> hdparm \ >>> i2c-tools \ >>> + initscript-telnetd \ >>> iozone3 \ >>> iproute2-tc \ >>> iproute2-devlink \ >>> @@ -57,6 +58,7 @@ TI_TEST_BASE = "\ >>> stress \ >>> stress-ng \ >>> strongswan \ >>> + systemd-telnetd \ >>> tcpdump \ >>> v4l-utils \ >>> xdp-tools-arago \ >> >
There's a standard DEBUG_BUILD variable that can be reused for this. But... It is a build-time condition, which means you end up with two separate builds for release and debugging. Do you test both? Or how can you ensure testing debug build also covers the release build properly? The idea of only building release images and then installing test packages at run-time for testing was to mitigate the above ambiguity... That said, I don't understand why it has to drive the run-time testing over telnet or ssh? Isn't the early boot testing already done over serial? Can the user-space Linux testing be done over serial as well?
On 1/5/26 7:44 PM, Denys Dmytriyenko wrote: > There's a standard DEBUG_BUILD variable that can be reused for this. But... > > It is a build-time condition, which means you end up with two separate builds > for release and debugging. Do you test both? Or how can you ensure testing > debug build also covers the release build properly? > > The idea of only building release images and then installing test packages at > run-time for testing was to mitigate the above ambiguity... > I believe it is always best to test the same configuration we release, so I'd like to avoid splitting the build. Instead simply looking to have a cleaner split between images with testing packages and images without (all built with the same configuration). Having the ti-test packages installed after by the test infra itself is also a reasonable solution. > That said, I don't understand why it has to drive the run-time testing over > telnet or ssh? Isn't the early boot testing already done over serial? Can the > user-space Linux testing be done over serial as well? > This would be much better. As Ryan pointed out, even SSH doesn't save us completely as we would need to still inject login info and such. Serial at least requires some level of physical access to the HW before getting root. Not perfect, but so much better than open root exposed over network. Andrew
diff --git a/check_yocto_rules.json b/check_yocto_rules.json index 7b3e20db..26275421 100644 --- a/check_yocto_rules.json +++ b/check_yocto_rules.json @@ -27,8 +27,6 @@ "PV-1" :{ "skip_files" : [ "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb", - "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", - "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", "meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb", "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb", "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb", @@ -38,6 +36,8 @@ "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb", "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb", "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb" + "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", + "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", ] } } diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb index b80697e5..d36b4397 100644 --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb @@ -16,8 +16,6 @@ ARAGO_BASE = "\ mtd-utils \ mtd-utils-ubifs \ curl \ - initscript-telnetd \ - systemd-telnetd \ ethtool \ bash \ opkg-bash-completion \ diff --git a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb similarity index 100% rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb diff --git a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd b/meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd similarity index 100% rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd diff --git a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb similarity index 100% rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb diff --git a/meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service b/meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service similarity index 100% rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb index 22957218..ebac81c2 100644 --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb @@ -22,6 +22,7 @@ TI_TEST_BASE = "\ hwspinlocktest \ hdparm \ i2c-tools \ + initscript-telnetd \ iozone3 \ iproute2-tc \ iproute2-devlink \ @@ -57,6 +58,7 @@ TI_TEST_BASE = "\ stress \ stress-ng \ strongswan \ + systemd-telnetd \ tcpdump \ v4l-utils \ xdp-tools-arago \
These are only used (and only ever should be used) in testing images. Move these out of the base distro images and only into images including the ti-test packagegroup. Move the recipes themselves also over to meta-arago-test. Signed-off-by: Andrew Davis <afd@ti.com> --- check_yocto_rules.json | 4 ++-- .../recipes-core/packagegroups/packagegroup-arago-base.bb | 2 -- .../initscript-telnetd/initscript-telnetd.bb | 0 .../initscript-telnetd/initscript-telnetd/telnetd | 0 .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb | 0 .../systemd-telnetd/systemd-telnetd/telnetd.service | 0 meta-arago-test/recipes-core/packagegroups/ti-test.bb | 2 ++ 7 files changed, 4 insertions(+), 4 deletions(-) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%)