| Message ID | 20250923121539.i7bx4zt7krbzmc7v@yogi-work-pc |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master/scarthgap] bt-ti: Restrict bt-ti packages to legacy platforms only | expand |
meta-arago / na / 20250923121539.i7bx4zt7krbzmc7v
PRC Results: PASS
=========================================================
check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
WARN - [meta-arago][master/scarthgap][PATCH] bt-ti: Restrict bt-ti packages to legacy platforms only
WARN: Commit message does not include file/recipe name: bt-ti: Restrict bt-ti packages. (COMMIT-MESSAGE-2)
patch
=========================================================
apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [meta-arago][master/scarthgap][PATCH] bt-ti: Restrict bt-ti packages to legacy platforms only
- Submitter: From: Yogesh Hegde <y-hegde@ti.com>
- Date: Date: Tue, 23 Sep 2025 17:45:39 +0530
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 2aada6d3a406c7ae53258ec5177f1323c2674ff3
Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: master-wip
- Commit Author: Ryan Eatmon <reatmon@ti.com>
- Commit Subject: ti-test: Make opencl-cts dependent on DISTRO_FEATURES
- Commit SHA: d3532063218f5c47b5e912554a0b236eb25e61f4
Patches
----------------------------------------
All patches applied
scarthgap
=====================
Summary:
- Patch Series: [meta-arago][master/scarthgap][PATCH] bt-ti: Restrict bt-ti packages to legacy platforms only
- Submitter: From: Yogesh Hegde <y-hegde@ti.com>
- Date: Date: Tue, 23 Sep 2025 17:45:39 +0530
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 2aada6d3a406c7ae53258ec5177f1323c2674ff3
Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: scarthgap-wip
- Commit Author: LCPD Automation Script <lcpdbld@list.ti.com>
- Commit Subject: CI/CD Auto-Merger: cicd.scarthgap.202509181257
- Commit SHA: 96f3c5b8e2efec96de9db131992e56272becc174
Patches
----------------------------------------
All patches applied
=========================================================
check-yocto-repo: PASS
=========================================================
master
=====================
PASS
scarthgap
=====================
PASS
The subject should be: packagegroup-arago-tisdk-connectivity: Restrict bt-ti to legacy platforms On 9/23/2025 7:15 AM, Yogesh Hegde wrote: > The bt-enable and bt-fw packages are only applicable for AM33X, AM43X and AM57XX > legacy platforms, but was being included for all machines. While the > bt-enable script performs noop for unsupported machines, it still adds > unnecessary overhead to boot time and generates log noise. > > Restrict the bt-enable and bt-fw packages to only be included for the > specific machine overrides (ti33x, ti43x, am57xx) that actually require > Bluetooth support. > > Signed-off-by: Yogesh Hegde <y-hegde@ti.com> > --- > .../packagegroup-arago-tisdk-connectivity.bb | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > index 5a91357b..5eeeaa01 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > @@ -49,7 +49,19 @@ BT_COMMON = "\ > linux-firmware-ibt-18 \ > " > > -BT_TI = "\ > +BT_TI = "" > + > +BT_TI:append:ti33x = "\ > + bt-enable \ > + bt-fw \ > +" > + > +BT_TI:append:ti43x = "\ > + bt-enable \ > + bt-fw \ > +" > + > +BT_TI:append:am57xx = "\ > bt-enable \ > bt-fw \ > "
On 9/23/2025 9:14 AM, Ryan Eatmon via lists.yoctoproject.org wrote: > > The subject should be: > > packagegroup-arago-tisdk-connectivity: Restrict bt-ti to legacy platforms Or even better: packagegroup-arago-tisdk-connectivity: Restrict BT_TI to legacy platforms > > On 9/23/2025 7:15 AM, Yogesh Hegde wrote: >> The bt-enable and bt-fw packages are only applicable for AM33X, AM43X >> and AM57XX >> legacy platforms, but was being included for all machines. While the >> bt-enable script performs noop for unsupported machines, it still adds >> unnecessary overhead to boot time and generates log noise. >> >> Restrict the bt-enable and bt-fw packages to only be included for the >> specific machine overrides (ti33x, ti43x, am57xx) that actually require >> Bluetooth support. >> >> Signed-off-by: Yogesh Hegde <y-hegde@ti.com> >> --- >> .../packagegroup-arago-tisdk-connectivity.bb | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git >> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb >> index 5a91357b..5eeeaa01 100644 >> --- >> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb >> +++ >> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb >> @@ -49,7 +49,19 @@ BT_COMMON = "\ >> linux-firmware-ibt-18 \ >> " >> -BT_TI = "\ >> +BT_TI = "" >> + >> +BT_TI:append:ti33x = "\ >> + bt-enable \ >> + bt-fw \ >> +" >> + >> +BT_TI:append:ti43x = "\ >> + bt-enable \ >> + bt-fw \ >> +" >> + >> +BT_TI:append:am57xx = "\ >> bt-enable \ >> bt-fw \ >> " >
On 9/23/2025 9:15 AM, Ryan Eatmon via lists.yoctoproject.org wrote: > > > On 9/23/2025 9:14 AM, Ryan Eatmon via lists.yoctoproject.org wrote: >> >> The subject should be: >> >> packagegroup-arago-tisdk-connectivity: Restrict bt-ti to legacy platforms > > > Or even better: > > packagegroup-arago-tisdk-connectivity: Restrict BT_TI to legacy platforms > > >> >> On 9/23/2025 7:15 AM, Yogesh Hegde wrote: >>> The bt-enable and bt-fw packages are only applicable for AM33X, AM43X >>> and AM57XX >>> legacy platforms, but was being included for all machines. While the >>> bt-enable script performs noop for unsupported machines, it still adds >>> unnecessary overhead to boot time and generates log noise. >>> >>> Restrict the bt-enable and bt-fw packages to only be included for the >>> specific machine overrides (ti33x, ti43x, am57xx) that actually require >>> Bluetooth support. >>> >>> Signed-off-by: Yogesh Hegde <y-hegde@ti.com> >>> --- >>> .../packagegroup-arago-tisdk-connectivity.bb | 14 +++++++++++++- >>> 1 file changed, 13 insertions(+), 1 deletion(-) >>> >>> diff --git >>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb >>> index 5a91357b..5eeeaa01 100644 >>> --- >>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb >>> +++ >>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb >>> @@ -49,7 +49,19 @@ BT_COMMON = "\ >>> linux-firmware-ibt-18 \ >>> " >>> -BT_TI = "\ >>> +BT_TI = "" >>> + >>> +BT_TI:append:ti33x = "\ >>> + bt-enable \ >>> + bt-fw \ >>> +" >>> + >>> +BT_TI:append:ti43x = "\ >>> + bt-enable \ >>> + bt-fw \ >>> +" >>> + >>> +BT_TI:append:am57xx = "\ >>> bt-enable \ >>> bt-fw \ >>> " >> I really should stop replying so quickly... In thinking about it a little longer, I think this change is a little too wordy. A better change would be: CONNECTIVITY_RDEPENDS = " \ htop \ iptables \ iproute2 \ iproute2-tc \ iproute2-devlink \ ${WLAN_COMMON} \ ${WLAN_TI} \ ${BT_COMMON} \ " CONNECTIVITY_RDEPENDS:append:ti33x = " ${BT_TI}" CONNECTIVITY_RDEPENDS:append:ti43x = " ${BT_TI}" CONNECTIVITY_RDEPENDS:append:am57xx = " ${BT_TI}" That way we still have a single variable to list the packages, just use the override to add the variable to the big list. We won't be repeating the package list over and over.
On 09:19-20250923, Ryan Eatmon wrote: > > > On 9/23/2025 9:15 AM, Ryan Eatmon via lists.yoctoproject.org wrote: > > > > > > On 9/23/2025 9:14 AM, Ryan Eatmon via lists.yoctoproject.org wrote: > > > > > > The subject should be: > > > > > > packagegroup-arago-tisdk-connectivity: Restrict bt-ti to legacy platforms > > > > > > Or even better: > > > > packagegroup-arago-tisdk-connectivity: Restrict BT_TI to legacy platforms > > > > > > > > > > On 9/23/2025 7:15 AM, Yogesh Hegde wrote: > > > > The bt-enable and bt-fw packages are only applicable for AM33X, > > > > AM43X and AM57XX > > > > legacy platforms, but was being included for all machines. While the > > > > bt-enable script performs noop for unsupported machines, it still adds > > > > unnecessary overhead to boot time and generates log noise. > > > > > > > > Restrict the bt-enable and bt-fw packages to only be included for the > > > > specific machine overrides (ti33x, ti43x, am57xx) that actually require > > > > Bluetooth support. > > > > > > > > Signed-off-by: Yogesh Hegde <y-hegde@ti.com> > > > > --- > > > > .../packagegroup-arago-tisdk-connectivity.bb | 14 +++++++++++++- > > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > > > > index 5a91357b..5eeeaa01 100644 > > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > > > > @@ -49,7 +49,19 @@ BT_COMMON = "\ > > > > linux-firmware-ibt-18 \ > > > > " > > > > -BT_TI = "\ > > > > +BT_TI = "" > > > > + > > > > +BT_TI:append:ti33x = "\ > > > > + bt-enable \ > > > > + bt-fw \ > > > > +" > > > > + > > > > +BT_TI:append:ti43x = "\ > > > > + bt-enable \ > > > > + bt-fw \ > > > > +" > > > > + > > > > +BT_TI:append:am57xx = "\ > > > > bt-enable \ > > > > bt-fw \ > > > > " > > > > > I really should stop replying so quickly... > > In thinking about it a little longer, I think this change is a little too > wordy. A better change would be: > > CONNECTIVITY_RDEPENDS = " \ > htop \ > iptables \ > iproute2 \ > iproute2-tc \ > iproute2-devlink \ > ${WLAN_COMMON} \ > ${WLAN_TI} \ > ${BT_COMMON} \ > " > > CONNECTIVITY_RDEPENDS:append:ti33x = " ${BT_TI}" > CONNECTIVITY_RDEPENDS:append:ti43x = " ${BT_TI}" > CONNECTIVITY_RDEPENDS:append:am57xx = " ${BT_TI}" > > That way we still have a single variable to list the packages, just use the > override to add the variable to the big list. We won't be repeating the > package list over and over. I will send a v2 patch with the suggested changes. I was wondering, since this is a machine-specific (read BSP) change, shouldn't this be in meta-ti instead of meta-arago? Thanks, -- Yogesh
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb index 5a91357b..5eeeaa01 100644 --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb @@ -49,7 +49,19 @@ BT_COMMON = "\ linux-firmware-ibt-18 \ " -BT_TI = "\ +BT_TI = "" + +BT_TI:append:ti33x = "\ + bt-enable \ + bt-fw \ +" + +BT_TI:append:ti43x = "\ + bt-enable \ + bt-fw \ +" + +BT_TI:append:am57xx = "\ bt-enable \ bt-fw \ "
The bt-enable and bt-fw packages are only applicable for AM33X, AM43X and AM57XX legacy platforms, but was being included for all machines. While the bt-enable script performs noop for unsupported machines, it still adds unnecessary overhead to boot time and generates log noise. Restrict the bt-enable and bt-fw packages to only be included for the specific machine overrides (ti33x, ti43x, am57xx) that actually require Bluetooth support. Signed-off-by: Yogesh Hegde <y-hegde@ti.com> --- .../packagegroup-arago-tisdk-connectivity.bb | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)