| Message ID | 20250917220826.2078836-2-a-christidis@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | Add libsdl2 test support | expand |
On 9/17/2025 5:08 PM, a-christidis@ti.com wrote: > From: Antonios Christidis <a-christidis@ti.com> > > The software provides tests, configure cmake to build and install them. > Package the tests in -tests package. > > Signed-off-by: Antonios Christidis <a-christidis@ti.com> > --- > meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc | 5 +++++ > meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++ > 2 files changed, 9 insertions(+) > create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc > create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend > > diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc > new file mode 100644 > index 00000000..12e06295 > --- /dev/null > +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc > @@ -0,0 +1,5 @@ > +EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \ > + -DSDL_INSTALL_TESTS=ON \ > + " > +PACKAGE_BEFORE_PN = "${PN}-tests" > +FILES:${PN}-tests += "${libexecdir} /usr/share/installed-tests/SDL2" I'm getting QA errors related to nativesdk-libsdl2. I had to change the above line to this: FILES:${PN}-tests:append = " ${datadir}/installed-tests/SDL2" FILES:${PN}-tests:append:class-nativesdk = " ${datadir}/installed-tests/SDL2" The libexecdir was not needed, and I changed the /usr/share to use the correct variable (datadir) in case someone wants to change the directory names in the Yocto manner. I moved to append just so that the two lines looked the same. I know this is also being submitted upstream, so these changes might be needed for those patches as well. > diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend > new file mode 100644 > index 00000000..385aa801 > --- /dev/null > +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend > @@ -0,0 +1,4 @@ > +LIBSDL2_TI = "" > +LIBSDL2_TI:ti-soc = "libsdl2-ti.inc" > + > +require ${LIBSDL2_TI}
diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc new file mode 100644 index 00000000..12e06295 --- /dev/null +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc @@ -0,0 +1,5 @@ +EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \ + -DSDL_INSTALL_TESTS=ON \ + " +PACKAGE_BEFORE_PN = "${PN}-tests" +FILES:${PN}-tests += "${libexecdir} /usr/share/installed-tests/SDL2" diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend new file mode 100644 index 00000000..385aa801 --- /dev/null +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend @@ -0,0 +1,4 @@ +LIBSDL2_TI = "" +LIBSDL2_TI:ti-soc = "libsdl2-ti.inc" + +require ${LIBSDL2_TI}