diff mbox series

[meta-arago,master,8/8] packagegroup-arago-tisdk-multimedia: Wrap various packages in a compliant manner

Message ID 20250320182041.2349-9-reatmon@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series Wrap various packages in a compliant manner | expand

Commit Message

Ryan Eatmon March 20, 2025, 6:20 p.m. UTC
yocto-check-layer does not load the conf/distro/arago.conf file during
its execution.  This means that the LICENSE_FLAGS_ACCEPTED variable is not
set according to what we are willing to accept.

If a packagegroup is trying to include a recipe that is marked as being
"commercial" and the LICENSE_FLAGS_ACCEPTED is not set, then yocto-check-layer
fails.

The solution is to wrap the inclusion of these recipes in the packagegroup
in a complaint manner.  Only if the DISTRO_OVERRIDE says that this is an
"arago" build, should the package be included and this under the direction
of the LICENSE_FLAGS_ACCEPTED variable.

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 .../packagegroups/packagegroup-arago-tisdk-multimedia.bb      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Denys Dmytriyenko March 24, 2025, 5:37 p.m. UTC | #1
On Thu, Mar 20, 2025 at 01:20:41PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> yocto-check-layer does not load the conf/distro/arago.conf file during
> its execution.  This means that the LICENSE_FLAGS_ACCEPTED variable is not
> set according to what we are willing to accept.
> 
> If a packagegroup is trying to include a recipe that is marked as being
> "commercial" and the LICENSE_FLAGS_ACCEPTED is not set, then yocto-check-layer
> fails.
> 
> The solution is to wrap the inclusion of these recipes in the packagegroup
> in a complaint manner.  Only if the DISTRO_OVERRIDE says that this is an
> "arago" build, should the package be included and this under the direction
> of the LICENSE_FLAGS_ACCEPTED variable.
> 
> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>  .../packagegroups/packagegroup-arago-tisdk-multimedia.bb      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> index 6a1b25b6..b7410e6f 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> @@ -7,12 +7,12 @@ PACKAGE_ARCH = "${MACHINE_ARCH}"
>  inherit packagegroup
>  
>  MULTIMEDIA = " \
> -    ffmpeg \
>      libcamera \
>      libcamera-gst \
> -    mpv \
>  "
>  
> +MULTIMEDIA:arago += "ffmpeg mpv"

It's not recommended to mix overrides (:arago) and appending operands (+=)

MULTIMEDIA:append:arago = " ffmpeg mpv"


>  MULTIMEDIA:omapl138 = ""
>  
>  MULTIMEDIA:append:dra7xx = " \
> -- 
> 2.17.1
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
index 6a1b25b6..b7410e6f 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
@@ -7,12 +7,12 @@  PACKAGE_ARCH = "${MACHINE_ARCH}"
 inherit packagegroup
 
 MULTIMEDIA = " \
-    ffmpeg \
     libcamera \
     libcamera-gst \
-    mpv \
 "
 
+MULTIMEDIA:arago += "ffmpeg mpv"
+
 MULTIMEDIA:omapl138 = ""
 
 MULTIMEDIA:append:dra7xx = " \