diff mbox series

[meta-arago,scarthgap,2/2] emptty: address feedback around append usage

Message ID 20250319211149.730403-2-rs@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series [meta-arago,scarthgap,1/2] emptty: handle legacy init a litte better | expand

Commit Message

Randolph Sapp March 19, 2025, 9:11 p.m. UTC 
From: Randolph Sapp <rs@ti.com>

Shy away from using append when not strictly necessary. Move the pam
specific runtime dependency under the relevant PACKAGECONFIG.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 .../recipes-graphics/emptty/emptty_0.13.0.bb   | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-graphics/emptty/emptty_0.13.0.bb b/meta-arago-distro/recipes-graphics/emptty/emptty_0.13.0.bb
index 176c9537..ce84898c 100644
--- a/meta-arago-distro/recipes-graphics/emptty/emptty_0.13.0.bb
+++ b/meta-arago-distro/recipes-graphics/emptty/emptty_0.13.0.bb
@@ -16,23 +16,25 @@  SRCREV_pam = "50ded1b0e7864b9bf75005eb945a8ec826bcf69d"
 
 SRCREV_FORMAT .= "_pam"
 
-PACKAGES:append = " ${PN}-conf"
+PACKAGES += "${PN}-conf"
 
 PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam x11', d)}"
-PACKAGECONFIG[pam] = ",,libpam"
+PACKAGECONFIG[pam] = ",,libpam,pam-plugin-succeed-if"
 PACKAGECONFIG[x11] = ",,virtual/libx11"
 
+DEPENDS += "${@bb.utils.contains('PACKAGECONFIG', 'pam', '', 'libxcrypt', d)}"
+
 GO_TAGS = ""
 GO_TAGS:append = "${@bb.utils.contains('PACKAGECONFIG', 'pam', '', ',nopam', d)}"
 GO_TAGS:append = "${@bb.utils.contains('PACKAGECONFIG', 'x11', '', ',noxlib', d)}"
 
-GOBUILDFLAGS:append = " -tags=${GO_TAGS}"
+GOBUILDFLAGS += "-tags=${GO_TAGS}"
 
 export GO111MODULE="off"
 
 inherit go update-rc.d systemd
 
-DEPENDS:append = " gzip"
+DEPENDS += "gzip-native"
 
 do_install () {
     # general collateral
@@ -64,11 +66,11 @@  FILES:${PN} = "\
     ${sysconfdir}/pam.d/emptty \
 "
 
-FILES:${PN}-conf:append = " ${sysconfdir}/emptty/conf"
-CONFFILES:${PN}-conf:append = " ${sysconfdir}/emptty/conf"
-RPROVIDES:${PN}-conf:append = " virtual-emptty-conf"
+FILES:${PN}-conf += "${sysconfdir}/emptty/conf"
+CONFFILES:${PN}-conf += "${sysconfdir}/emptty/conf"
+RPROVIDES:${PN}-conf += "virtual-emptty-conf"
 
-RDEPENDS:${PN}:append = " virtual-emptty-conf pam-plugin-succeed-if"
+RDEPENDS:${PN} += "virtual-emptty-conf"
 
 SYSTEMD_SERVICE:${PN} = "emptty.service"