Message ID | 20250318024235.3581162-1-a-christidis@ti.com |
---|---|
State | Superseded |
Delegated to: | Ryan Eatmon |
Headers | show |
Series | [meta-arago,scarthgap/master] ti-gc320-tests: Update SRCREV for recipe | expand |
On 3/17/2025 9:42 PM, Antonios Christidis via lists.yoctoproject.org wrote: > From: Antonios Christidis <a-christidis@ti.com> > > Include a new SRCREV for the recipe to build from. This is not a new version of > the tests repo, instead the new commit sha includes cross compilation errors > fixes. Agreed. This is the better way of doing this. > Signed-off-by: Antonios Christidis <a-christidis@ti.com> > --- > .../ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb b/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb > index f9b9685f..02605d98 100644 > --- a/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb > +++ b/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb > @@ -5,12 +5,12 @@ LIC_FILES_CHKSUM = "file://dra7x-sdk-ti-gc320-tests_manifest.html;md5=22a0018554 > > DEPENDS = "ti-gc320-libs" > > -BRANCH = "ti-${PV}" > +BRANCH = "ti-${PV}-scarthgap" Why did we create a scarthgap branch? The issues being addressed are far more broad and not specific to scarthgap? > SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-test.git;protocol=https;branch=${BRANCH} \ > file://0001-makefile.linux.def-relax-assignment-of-CC-and-other-.patch \ > " This will not apply to master as my previous patch that addressed some of the compile issues was already accepted and promoted to master, and your patch is missing the removal of that patch. I never applied my patch to scarthgap. This needs to be split into two patches, one for scarthgap and one for master. > -SRCREV = "53207f8e360a3336276b62066a1d8a9e923de17e" > +SRCREV = "3c334f2004c718c9bb4321213c362e65c491efe6" > PR = "r2" > > S = "${WORKDIR}/git"
On 3/19/25 9:19 AM, Ryan Eatmon wrote: > > > On 3/17/2025 9:42 PM, Antonios Christidis via lists.yoctoproject.org > wrote: >> From: Antonios Christidis <a-christidis@ti.com> >> >> Include a new SRCREV for the recipe to build from. This is not a new >> version of >> the tests repo, instead the new commit sha includes cross compilation >> errors >> fixes. > > Agreed. This is the better way of doing this. > > >> Signed-off-by: Antonios Christidis <a-christidis@ti.com> >> --- >> .../ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git >> a/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb >> b/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb >> >> index f9b9685f..02605d98 100644 >> --- >> a/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb >> +++ >> b/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb >> @@ -5,12 +5,12 @@ LIC_FILES_CHKSUM = >> "file://dra7x-sdk-ti-gc320-tests_manifest.html;md5=22a0018554 >> DEPENDS = "ti-gc320-libs" >> -BRANCH = "ti-${PV}" >> +BRANCH = "ti-${PV}-scarthgap" > > Why did we create a scarthgap branch? The issues being addressed are > far more broad and not specific to scarthgap? Very good point, initially I post-fixed "scarthgap" for the sake of consistency with the ti-gc320-libs recipe, as it too has a post-fixed "scarthgap". But, the changes made here (tests) and there (libs) are not specific to scarthgap branch. So, I'll update the branch name to just ti-${PV}. >> SRC_URI = >> "git://git.ti.com/git/graphics/ti-gc320-test.git;protocol=https;branch=${BRANCH} >> \ >> file://0001-makefile.linux.def-relax-assignment-of-CC-and-other-.patch \ >> " > > This will not apply to master as my previous patch that addressed some > of the compile issues was already accepted and promoted to master, and > your patch is missing the removal of that patch. I never applied my > patch to scarthgap. > > This needs to be split into two patches, one for scarthgap and one for > master. Will do. Ty for the feedback. > >> -SRCREV = "53207f8e360a3336276b62066a1d8a9e923de17e" >> +SRCREV = "3c334f2004c718c9bb4321213c362e65c491efe6" >> PR = "r2" >> S = "${WORKDIR}/git" >
diff --git a/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb b/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb index f9b9685f..02605d98 100644 --- a/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb +++ b/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb @@ -5,12 +5,12 @@ LIC_FILES_CHKSUM = "file://dra7x-sdk-ti-gc320-tests_manifest.html;md5=22a0018554 DEPENDS = "ti-gc320-libs" -BRANCH = "ti-${PV}" +BRANCH = "ti-${PV}-scarthgap" SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-test.git;protocol=https;branch=${BRANCH} \ file://0001-makefile.linux.def-relax-assignment-of-CC-and-other-.patch \ " -SRCREV = "53207f8e360a3336276b62066a1d8a9e923de17e" +SRCREV = "3c334f2004c718c9bb4321213c362e65c491efe6" PR = "r2" S = "${WORKDIR}/git"