diff mbox series

[meta-arago,scarthgap] meta-arago-test: Add runtime dependencies for pytesseract

Message ID 20250304060645.217310-1-a-christidis@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [meta-arago,scarthgap] meta-arago-test: Add runtime dependencies for pytesseract | expand

Commit Message

Antonios Christidis March 4, 2025, 6:06 a.m. UTC
From: Antonios Christidis <a-christidis@ti.com>

Pytesseract is a python wrapper for tesseract, so it should depend on it.
The pytesseract script calls the python packaging module, so add it as
well as a dependecy.

This is only for scarthgap branch, as the master recipe for this package
is in meta-openembedded.

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---
 .../recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb  | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ryan Eatmon March 4, 2025, 7:35 p.m. UTC | #1
The subject is not quite right.  It should be:

pytesseract: Add runtime dependencies

I don't care so much about knowing this patch was for meta-arago-test or 
whichever layer.  But the first part should always contain the recipe 
name being updated.

Please fix.


On 3/4/2025 12:06 AM, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> Pytesseract is a python wrapper for tesseract, so it should depend on it.
> The pytesseract script calls the python packaging module, so add it as
> well as a dependecy.
> 
> This is only for scarthgap branch, as the master recipe for this package
> is in meta-openembedded.
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>   .../recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb  | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb b/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
> index 91350cd5..0f505f63 100644
> --- a/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
> +++ b/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
> @@ -7,6 +7,8 @@ HOMEPAGE = "https://github.com/madmaze/pytesseract"
>   LICENSE = "Apache-2.0"
>   LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
>   
> +RDEPENDS:${PN}:append = "python3-packaging tesseract"
> +
>   SRC_URI[sha256sum] = "4bf5f880c99406f52a3cfc2633e42d9dc67615e69d8a509d74867d3baddb5db9"
>   
>   PYPI_PACKAGE = "pytesseract"
Antonios Christidis March 4, 2025, 8:54 p.m. UTC | #2
Thank you for point this out.

v2 just sent.

Regards

Antonios

On 3/4/25 1:35 PM, Ryan Eatmon wrote:
>
> The subject is not quite right.  It should be:
>
> pytesseract: Add runtime dependencies
>
> I don't care so much about knowing this patch was for meta-arago-test 
> or whichever layer.  But the first part should always contain the 
> recipe name being updated.
>
> Please fix.
>
>
> On 3/4/2025 12:06 AM, Antonios Christidis via lists.yoctoproject.org 
> wrote:
>> From: Antonios Christidis <a-christidis@ti.com>
>>
>> Pytesseract is a python wrapper for tesseract, so it should depend on 
>> it.
>> The pytesseract script calls the python packaging module, so add it as
>> well as a dependecy.
>>
>> This is only for scarthgap branch, as the master recipe for this package
>> is in meta-openembedded.
>>
>> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
>> ---
>> .../recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git 
>> a/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb 
>> b/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb 
>>
>> index 91350cd5..0f505f63 100644
>> --- 
>> a/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
>> +++ 
>> b/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
>> @@ -7,6 +7,8 @@ HOMEPAGE = "https://github.com/madmaze/pytesseract"
>>   LICENSE = "Apache-2.0"
>>   LIC_FILES_CHKSUM = 
>> "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
>>   +RDEPENDS:${PN}:append = "python3-packaging tesseract"
>> +
>>   SRC_URI[sha256sum] = 
>> "4bf5f880c99406f52a3cfc2633e42d9dc67615e69d8a509d74867d3baddb5db9"
>>     PYPI_PACKAGE = "pytesseract"
>
Denys Dmytriyenko March 4, 2025, 9 p.m. UTC | #3
On Tue, Mar 04, 2025 at 01:35:20PM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> The subject is not quite right.  It should be:
> 
> pytesseract: Add runtime dependencies
> 
> I don't care so much about knowing this patch was for
> meta-arago-test or whichever layer.  But the first part should
> always contain the recipe name being updated.
> 
> Please fix.
> 
> 
> On 3/4/2025 12:06 AM, Antonios Christidis via lists.yoctoproject.org wrote:
> >From: Antonios Christidis <a-christidis@ti.com>
> >
> >Pytesseract is a python wrapper for tesseract, so it should depend on it.
> >The pytesseract script calls the python packaging module, so add it as
> >well as a dependecy.
> >
> >This is only for scarthgap branch, as the master recipe for this package
> >is in meta-openembedded.
> >
> >Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> >---
> >  .../recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb  | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> >diff --git a/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb b/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
> >index 91350cd5..0f505f63 100644
> >--- a/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
> >+++ b/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
> >@@ -7,6 +7,8 @@ HOMEPAGE = "https://github.com/madmaze/pytesseract"
> >  LICENSE = "Apache-2.0"
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
> >+RDEPENDS:${PN}:append = "python3-packaging tesseract"

This can potentially mangle the existing RDEPENDS list...


> >  SRC_URI[sha256sum] = "4bf5f880c99406f52a3cfc2633e42d9dc67615e69d8a509d74867d3baddb5db9"
> >  PYPI_PACKAGE = "pytesseract"
diff mbox series

Patch

diff --git a/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb b/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
index 91350cd5..0f505f63 100644
--- a/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
+++ b/meta-arago-test/recipes-graphics/python3-pytesseract/pytesseract_0.3.13.bb
@@ -7,6 +7,8 @@  HOMEPAGE = "https://github.com/madmaze/pytesseract"
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
 
+RDEPENDS:${PN}:append = "python3-packaging tesseract"
+
 SRC_URI[sha256sum] = "4bf5f880c99406f52a3cfc2633e42d9dc67615e69d8a509d74867d3baddb5db9"
 
 PYPI_PACKAGE = "pytesseract"