diff mbox series

[meta-arago,master/scarthgap] packagegroup-arago-base: Add mosquitto packages

Message ID 20250116135431.1937360-1-d-mittal@ti.com
State New
Headers show
Series [meta-arago,master/scarthgap] packagegroup-arago-base: Add mosquitto packages | expand

Commit Message

Divyansh Mittal Jan. 16, 2025, 1:54 p.m. UTC
Mosquitto is an open source (Eclipse licensed) message broker that
implements the MQ Telemetry Transport protocol providing both an MQTT
broker and several command-line clients.

Signed-off-by: Divyansh Mittal <d-mittal@ti.com>
---
 .../recipes-core/packagegroups/packagegroup-arago-base.bb    | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Denys Dmytriyenko Jan. 16, 2025, 8:59 p.m. UTC | #1
On Thu, Jan 16, 2025 at 07:24:31PM +0530, Divyansh Mittal via lists.yoctoproject.org wrote:
> Mosquitto is an open source (Eclipse licensed) message broker that
> implements the MQ Telemetry Transport protocol providing both an MQTT
> broker and several command-line clients.
> 
> Signed-off-by: Divyansh Mittal <d-mittal@ti.com>
> ---
>  .../recipes-core/packagegroups/packagegroup-arago-base.bb    | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> index 121fa432..7634cb0c 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> @@ -50,6 +50,11 @@ ARAGO_EXTRA = "\
>      cifs-utils \
>      phytool \
>      lldpd \
> +    mosquitto \
> +    libmosquitto1 \
> +    libmosquittopp1 \

You don't need to explicitly list the libraries here. I haven't checked the 
mosquitto packaging, but I'm pretty sure either the main package or the 
clients one have the necessary dependencies. You do want to avoid explicitly 
listing libraries in here, especially since they contain the version number 
in their names when Debian renaming is enabled, or have completely different 
names otherwise.


> +    mosquitto-clients \
> +    mosquitto-dev \

Do you really need the development package here. Especially in the "base" 
packagegroup, which is meant to be used for minimal and bootstrapping images.

Just pulling a single -dev package like this will have a snowball effect and 
will explode the dependency tree with hundreds of other development packages, 
making the image suitable for runtime "development".

I just did a quick experiment with tisdk-base-image, just adding mosquitto-dev 
the number of packages increased by 112 and the size grew by 20%. And I also 
see both mosquitto libraries being added automatically. Here's the list:

acl
acl-dev
attr
attr-dev
base-files-dev
base-passwd-dev
bash-completion-dev
bash-dev
bzip2
bzip2-dev
cjson
cjson-dev
cryptodev-linux
cryptodev-linux-dev
dbus-dev
kbd-dev
kmod-dev
libc-malloc-debug0
libc6-dev
libc6-extra-nss
libc6-thread-db
libc6-utils
libcap-dev
libcap-ng-dev
libcrypt-dev
libedit-dev
libexpat-dev
libffi-dev
libform5
libgcc-s-dev
libgdbm-compat4
libgdbm-dev
libgdbm6
libgirepository-1.0-1
libgirepository-1.0-dev
libglib-2.0-dev
libmenu5
libmosquitto1
libmosquittopp1
libnsl-dev
libnsl3
libnss-db2
libpam-dev
libpanel5
libpcre2-16-0
libpcre2-32-0
libpcre2-dev
libseccomp-dev
libsqlite3-dev
libstdc++-dev
libticw5
libtirpc-dev
libuuid-dev
libuv-dev
libuv1
libwebsockets-dev
libwebsockets-evlib-uv
libwebsockets19
libxml2-dev
libz-dev
linux-libc-headers-dev
mosquitto
mosquitto-dev
ncurses-dev
openssl-dev
perl
perl-dev
perl-module-config-heavy
python3-asyncio
python3-compile
python3-crypt
python3-ctypes
python3-datetime
python3-dev
python3-difflib
python3-email
python3-html
python3-io
python3-json
python3-logging
python3-math
python3-mime
python3-netclient
python3-netserver
python3-numbers
python3-packaging
python3-packaging-dev
python3-pickle
python3-pkg-resources
python3-pkgutil
python3-plistlib
python3-pprint
python3-profile
python3-setuptools
python3-setuptools-dev
python3-shell
python3-stringold
python3-threading
python3-unittest
python3-unixadmin
python3-xml
shadow-dev
shadow-securetty-dev
shared-mime-info-dev
systemd-dev
uthash-dev
util-linux-dev
volatile-binds-dev
xz
xz-dev
zstd
zstd-dev
Jon Cormier Jan. 16, 2025, 10:03 p.m. UTC | #2
Perhaps it would make more sense to add it to
packagegroup-arago-tisdk-addons.bb then you could add -dev package to
packagegroup-arago-tisdk-addons-sdk-target.bb?

On Thu, Jan 16, 2025 at 3:59 PM Denys Dmytriyenko via lists.yoctoproject.org
<denis=denix.org@lists.yoctoproject.org> wrote:

> On Thu, Jan 16, 2025 at 07:24:31PM +0530, Divyansh Mittal via
> lists.yoctoproject.org wrote:
> > Mosquitto is an open source (Eclipse licensed) message broker that
> > implements the MQ Telemetry Transport protocol providing both an MQTT
> > broker and several command-line clients.
> >
> > Signed-off-by: Divyansh Mittal <d-mittal@ti.com>
> > ---
> >  .../recipes-core/packagegroups/packagegroup-arago-base.bb    | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/
> packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/
> packagegroup-arago-base.bb
> > index 121fa432..7634cb0c 100644
> > --- a/meta-arago-distro/recipes-core/packagegroups/
> packagegroup-arago-base.bb
> > +++ b/meta-arago-distro/recipes-core/packagegroups/
> packagegroup-arago-base.bb
> > @@ -50,6 +50,11 @@ ARAGO_EXTRA = "\
> >      cifs-utils \
> >      phytool \
> >      lldpd \
> > +    mosquitto \
> > +    libmosquitto1 \
> > +    libmosquittopp1 \
>
> You don't need to explicitly list the libraries here. I haven't checked
> the
> mosquitto packaging, but I'm pretty sure either the main package or the
> clients one have the necessary dependencies. You do want to avoid
> explicitly
> listing libraries in here, especially since they contain the version
> number
> in their names when Debian renaming is enabled, or have completely
> different
> names otherwise.
>
>
> > +    mosquitto-clients \
> > +    mosquitto-dev \
>
> Do you really need the development package here. Especially in the "base"
> packagegroup, which is meant to be used for minimal and bootstrapping
> images.
>
> Just pulling a single -dev package like this will have a snowball effect
> and
> will explode the dependency tree with hundreds of other development
> packages,
> making the image suitable for runtime "development".
>
> I just did a quick experiment with tisdk-base-image, just adding
> mosquitto-dev
> the number of packages increased by 112 and the size grew by 20%. And I
> also
> see both mosquitto libraries being added automatically. Here's the list:
>
> acl
> acl-dev
> attr
> attr-dev
> base-files-dev
> base-passwd-dev
> bash-completion-dev
> bash-dev
> bzip2
> bzip2-dev
> cjson
> cjson-dev
> cryptodev-linux
> cryptodev-linux-dev
> dbus-dev
> kbd-dev
> kmod-dev
> libc-malloc-debug0
> libc6-dev
> libc6-extra-nss
> libc6-thread-db
> libc6-utils
> libcap-dev
> libcap-ng-dev
> libcrypt-dev
> libedit-dev
> libexpat-dev
> libffi-dev
> libform5
> libgcc-s-dev
> libgdbm-compat4
> libgdbm-dev
> libgdbm6
> libgirepository-1.0-1
> libgirepository-1.0-dev
> libglib-2.0-dev
> libmenu5
> libmosquitto1
> libmosquittopp1
> libnsl-dev
> libnsl3
> libnss-db2
> libpam-dev
> libpanel5
> libpcre2-16-0
> libpcre2-32-0
> libpcre2-dev
> libseccomp-dev
> libsqlite3-dev
> libstdc++-dev
> libticw5
> libtirpc-dev
> libuuid-dev
> libuv-dev
> libuv1
> libwebsockets-dev
> libwebsockets-evlib-uv
> libwebsockets19
> libxml2-dev
> libz-dev
> linux-libc-headers-dev
> mosquitto
> mosquitto-dev
> ncurses-dev
> openssl-dev
> perl
> perl-dev
> perl-module-config-heavy
> python3-asyncio
> python3-compile
> python3-crypt
> python3-ctypes
> python3-datetime
> python3-dev
> python3-difflib
> python3-email
> python3-html
> python3-io
> python3-json
> python3-logging
> python3-math
> python3-mime
> python3-netclient
> python3-netserver
> python3-numbers
> python3-packaging
> python3-packaging-dev
> python3-pickle
> python3-pkg-resources
> python3-pkgutil
> python3-plistlib
> python3-pprint
> python3-profile
> python3-setuptools
> python3-setuptools-dev
> python3-shell
> python3-stringold
> python3-threading
> python3-unittest
> python3-unixadmin
> python3-xml
> shadow-dev
> shadow-securetty-dev
> shared-mime-info-dev
> systemd-dev
> uthash-dev
> util-linux-dev
> volatile-binds-dev
> xz
> xz-dev
> zstd
> zstd-dev
>
> --
> Denys
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#15696):
> https://lists.yoctoproject.org/g/meta-arago/message/15696
> Mute This Topic: https://lists.yoctoproject.org/mt/110646886/7902621
> Group Owner: meta-arago+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [
> jcormier@criticallink.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
>
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
index 121fa432..7634cb0c 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
@@ -50,6 +50,11 @@  ARAGO_EXTRA = "\
     cifs-utils \
     phytool \
     lldpd \
+    mosquitto \
+    libmosquitto1 \
+    libmosquittopp1 \
+    mosquitto-clients \
+    mosquitto-dev \
 "
 
 OPTEE_PKGS = " \