| Message ID | 20240618122453.1131089-1-c-shilwant@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master/scarthgap,v2] recipes-qt: qt5: Add xkbcommon to qtbase PACKAGECONFIG | expand |
Please add it to PACKAGECONFIG_DISTRO variable, where it was originally. Also, previously it was done in the arago.conf distro configuration, as adjusting PACKAGECONFIGs from their default values is considered a distro-specific change. Plus, it avoids creating tons of one-line .bbappends (though in the case of qtbase, we already have a .bbappend for other reasons). Lastly, refrain from using :append w/o additional overrides and use += instead - it automatically handles whitespaces and is much easier to undo downstream. On Tue, Jun 18, 2024 at 05:54:53PM +0530, Chirag Shilwant wrote: > From: Sai Sree Kartheek Adivi <s-adivi@ti.com> > > - For QT apps to use physical keyboard, xkbcommon has to be added in > PACKAGECONFIG. This was supported until 09.01 using xkbcommon-evdev which at > present is an invalid PACKAGECONFIG & hence was dropped from meta-arago [1]. > > - Hence, add xkbcommon to PACKAGECONFIG which will enable the use of > physical keyboard in QT apps. > > [1]: https://git.ti.com/cgit/arago-project/meta-arago/commit/?h=scarthgap&id=de16946741249265a38acb7bb503b39a0c2b4175 > > Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com> > Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> > --- > v2: Add xkbcommon in PACKAGECONFIG to all platforms instead of making it k3 machine specific > > meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend b/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend > index 8ae8110b..4ecfd7ed 100644 > --- a/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend > +++ b/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend > @@ -4,6 +4,8 @@ GLES_EXTRA_DEPS = "libdrm wayland" > > PACKAGECONFIG[gles2] = "-opengl es2 -eglfs,,virtual/libgles2 virtual/egl ${GLES_EXTRA_DEPS}" > > +PACKAGECONFIG:append = " xkbcommon" > + > PR:append = ".arago17" > > QT_CONFIG_FLAGS += "-qpa ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', 'eglfs', d)}" > -- > 2.34.1
Hi Denys, On 19/06/24 02:31, Denys Dmytriyenko wrote: > Please add it to PACKAGECONFIG_DISTRO variable, where it was originally. Also, > previously it was done in the arago.conf distro configuration, as adjusting > PACKAGECONFIGs from their default values is considered a distro-specific > change. Plus, it avoids creating tons of one-line .bbappends (though in the > case of qtbase, we already have a .bbappend for other reasons). Lastly, > refrain from using :append w/o additional overrides and use += instead - it > automatically handles whitespaces and is much easier to undo downstream. Thanks for your comments! Sent a v3 based on your suggestions - https://lists.yoctoproject.org/g/meta-arago/message/15403 > > On Tue, Jun 18, 2024 at 05:54:53PM +0530, Chirag Shilwant wrote: >> From: Sai Sree Kartheek Adivi <s-adivi@ti.com> >> >> - For QT apps to use physical keyboard, xkbcommon has to be added in >> PACKAGECONFIG. This was supported until 09.01 using xkbcommon-evdev which at >> present is an invalid PACKAGECONFIG & hence was dropped from meta-arago [1]. >> >> - Hence, add xkbcommon to PACKAGECONFIG which will enable the use of >> physical keyboard in QT apps. >> >> [1]: https://git.ti.com/cgit/arago-project/meta-arago/commit/?h=scarthgap&id=de16946741249265a38acb7bb503b39a0c2b4175 >> >> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com> >> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> >> --- >> v2: Add xkbcommon in PACKAGECONFIG to all platforms instead of making it k3 machine specific >> >> meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend b/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend >> index 8ae8110b..4ecfd7ed 100644 >> --- a/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend >> +++ b/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend >> @@ -4,6 +4,8 @@ GLES_EXTRA_DEPS = "libdrm wayland" >> >> PACKAGECONFIG[gles2] = "-opengl es2 -eglfs,,virtual/libgles2 virtual/egl ${GLES_EXTRA_DEPS}" >> >> +PACKAGECONFIG:append = " xkbcommon" >> + >> PR:append = ".arago17" >> >> QT_CONFIG_FLAGS += "-qpa ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', 'eglfs', d)}" >> -- >> 2.34.1
diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend b/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend index 8ae8110b..4ecfd7ed 100644 --- a/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend +++ b/meta-arago-distro/recipes-qt/qt5/qtbase_%.bbappend @@ -4,6 +4,8 @@ GLES_EXTRA_DEPS = "libdrm wayland" PACKAGECONFIG[gles2] = "-opengl es2 -eglfs,,virtual/libgles2 virtual/egl ${GLES_EXTRA_DEPS}" +PACKAGECONFIG:append = " xkbcommon" + PR:append = ".arago17" QT_CONFIG_FLAGS += "-qpa ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', 'eglfs', d)}"