| Message ID | 20240603063846.2815948-1-c-shilwant@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master/scarthgap] recipes-core: packagegroup-arago-tisdk-addons: Add back kmscube | expand |
On 6/3/2024 1:38 AM, Chirag Shilwant wrote: > - kmscube was earlier packaged as a run time dependency for matrix-gui. > But now as matrix-gui is removed [1], add kmscube manually. > > - kmscube can be used by developers to quickly validate the GPU and display > after driver or userspace changes. So it is good to add it back. > > [1]: https://git.ti.com/cgit/arago-project/meta-arago/commit/?h=master&id=e4b33fbc34aa90d156310b3cd1cb23f1d0cadab4 > > Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> > --- > .../packagegroups/packagegroup-arago-tisdk-addons.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb > index 8dbffa81..d25c9eb1 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb > @@ -79,6 +79,7 @@ EXTRA_PACKAGES = " \ > nodejs-npm \ > protobuf \ > ccief-basic \ > + kmscube \ > " Previously the kmscube was only included for builds that support graphics. This change just adds it in for all builds. I think we need to limit the scope of when it gets added in. Plus, is tisdk-addons the right place to add this? Versus tisdk-graphics? I think tisdk-graphics is already gated behind the check that I was mentioning above. > EXTRA_PACKAGES:omapl138 = " \
Hi Ryan, On 03/06/24 21:53, Ryan Eatmon wrote: > > > On 6/3/2024 1:38 AM, Chirag Shilwant wrote: >> - kmscube was earlier packaged as a run time dependency for matrix-gui. >> But now as matrix-gui is removed [1], add kmscube manually. >> >> - kmscube can be used by developers to quickly validate the GPU and >> display >> after driver or userspace changes. So it is good to add it back. >> >> [1]: >> https://git.ti.com/cgit/arago-project/meta-arago/commit/?h=master&id=e4b33fbc34aa90d156310b3cd1cb23f1d0cadab4 >> >> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> >> --- >> .../packagegroups/packagegroup-arago-tisdk-addons.bb | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb >> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb >> >> index 8dbffa81..d25c9eb1 100644 >> --- >> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb >> +++ >> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb >> @@ -79,6 +79,7 @@ EXTRA_PACKAGES = " \ >> nodejs-npm \ >> protobuf \ >> ccief-basic \ >> + kmscube \ >> " > > Previously the kmscube was only included for builds that support > graphics. This change just adds it in for all builds. I think we > need to limit the scope of when it gets added in. > > Plus, is tisdk-addons the right place to add this? Versus > tisdk-graphics? I think tisdk-graphics is already gated behind the > check that I was mentioning above. Agreed! Sent a v2 patch - https://lists.yoctoproject.org/g/meta-arago/message/15357 > > > > >> EXTRA_PACKAGES:omapl138 = " \ >
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb index 8dbffa81..d25c9eb1 100644 --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb @@ -79,6 +79,7 @@ EXTRA_PACKAGES = " \ nodejs-npm \ protobuf \ ccief-basic \ + kmscube \ " EXTRA_PACKAGES:omapl138 = " \
- kmscube was earlier packaged as a run time dependency for matrix-gui. But now as matrix-gui is removed [1], add kmscube manually. - kmscube can be used by developers to quickly validate the GPU and display after driver or userspace changes. So it is good to add it back. [1]: https://git.ti.com/cgit/arago-project/meta-arago/commit/?h=master&id=e4b33fbc34aa90d156310b3cd1cb23f1d0cadab4 Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> --- .../packagegroups/packagegroup-arago-tisdk-addons.bb | 1 + 1 file changed, 1 insertion(+)