| Message ID | 20240420125318.397900-1-c-shilwant@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master/scarthgap] meta-arago-distro: recipes-core: Add no-fstab-update option to WIC_CREATE_EXTRA_ARG | expand |
On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: > - Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition > but currently it lists the contents of /boot partition of the WIC Image. > > Eg - Incase of AM64x, > ``` > root@am64xx-evm:~# ls /boot/ > EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt Will this change affect EFI? As there's EFI directory in that partition. > > ``` > > - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc > to prevent WIC image from adding an additional entry in /etc/fstab. This flag is global and will prevent all other partitions from populating /etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other layers could have own wic files with e.g. /home or /data partitions. Mounting those will require a custom /etc/fstab instead of wic creating corresponding entries automatically. > Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> > --- > meta-arago-distro/recipes-core/images/arago-image.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc > index 00308b57..2a34a709 100644 > --- a/meta-arago-distro/recipes-core/images/arago-image.inc > +++ b/meta-arago-distro/recipes-core/images/arago-image.inc > @@ -31,4 +31,6 @@ BAD_RECOMMENDATIONS += " \ > " > BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", "busybox-syslog", d)}" > > +WIC_CREATE_EXTRA_ARGS += " --no-fstab-update" > + > inherit core-image remove-net-rules > -- > 2.34.1
+ Andreas On 21/04/24 08:37, Denys Dmytriyenko wrote: > On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: >> - Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition >> but currently it lists the contents of /boot partition of the WIC Image. >> >> Eg - Incase of AM64x, >> ``` >> root@am64xx-evm:~# ls /boot/ >> EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt > Will this change affect EFI? As there's EFI directory in that partition. The EFI partition under /rootfs/boot will still be present. Following is the output of `ls /boot` with this patch, ``` root@am64xx-evm:~# ls /boot EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage fitImage-6.1.80-ti-g2e423244f8c0 ``` > > >> ``` >> >> - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc >> to prevent WIC image from adding an additional entry in /etc/fstab. > This flag is global and will prevent all other partitions from populating > /etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other > layers could have own wic files with e.g. /home or /data partitions. Mounting > those will require a custom /etc/fstab instead of wic creating corresponding > entries automatically. > Apparently, this change was being carried in processor sdk layer from quite a long time (from dunfell) to resolve a customer issue reported by Andreas. Diving into our internal JIRA system showed that this fix was suggested by Andreas & was resolved by the SDK team back then by keeping this change in processor sdk layer [1]. Not sure why this was in processor sdk layer though. Maybe Andreas can provide additional details. Btw, I also see other SOC vendors (meta-freescale) adding --no-fstab-update flag to WIC_CREATE_EXTRA_ARG [2] So, if we are planning to pull in this change should it go somewhere in meta-ti (maybe k3.inc [3])? [1]: https://git.ti.com/cgit/processor-sdk/meta-processor-sdk/commit/recipes-core/images/tisdk-default-image.bbappend?h=dunfell&id=58975a30e8f90efbffb97e49d5baac02971644da [2]: https://git.yoctoproject.org/meta-freescale/tree/conf/machine/include/imx-base.inc?h=scarthgap#n614 [3]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/conf/machine/include/k3.inc?h=scarthgap >> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> >> --- >> meta-arago-distro/recipes-core/images/arago-image.inc | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc >> index 00308b57..2a34a709 100644 >> --- a/meta-arago-distro/recipes-core/images/arago-image.inc >> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc >> @@ -31,4 +31,6 @@ BAD_RECOMMENDATIONS += " \ >> " >> BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", "busybox-syslog", d)}" >> >> +WIC_CREATE_EXTRA_ARGS += " --no-fstab-update" >> + >> inherit core-image remove-net-rules >> -- >> 2.34.1
Fyi, This is not a k3 only issue. We fix this for pretty much all ti products. We've fixed this for years on our own layer by defining our own wic image which removes the /boot. Setting --no-fstab-update wouldn't break our solution, though i do wonder if it's too heavy handed. https://support.criticallink.com/gitweb/?p=meta-mitysom.git;a=blob;f=wic/sdimage-bootpart-nomountboot.wks;h=1e2c3927de62cd33382733fd4fdd24047a7d8fd9;hb=refs/heads/kirkstone https://support.criticallink.com/gitweb/?p=meta-mitysom.git;a=blob;f=conf/machine/mitysom.inc;h=85256ad4c9039af390411e9811f6f49e570269d4;hb=refs/heads/kirkstone#l3 Ps. Not sure if anyone from meta-edgeai is on here but why would you rename the boot partition to BOOT and change the rootfs name... Anyways I digress. On Sat, Apr 20, 2024, 11:12 PM Chirag Shilwant via lists.yoctoproject.org <c-shilwant=ti.com@lists.yoctoproject.org> wrote: > + Andreas > On 21/04/24 08:37, Denys Dmytriyenko wrote: > > On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: > >> - Ideally running `ls /boot/` in filesystem should list contents from > /rootfs/boot partition > >> but currently it lists the contents of /boot partition of the WIC Image. > >> > >> Eg - Incase of AM64x, > >> ``` > >> root@am64xx-evm:~# ls /boot/ > >> EFI Image tiboot3-am64x-gp-evm.bin > tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin > tispl.bin u-boot.img uEnv.txt > > Will this change affect EFI? As there's EFI directory in that partition. > > The EFI partition under /rootfs/boot will still be present. > Following is the output of `ls /boot` with this patch, > > ``` > root@am64xx-evm:~# ls /boot > EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage > fitImage-6.1.80-ti-g2e423244f8c0 > > ``` > > > > > > > >> ``` > >> > >> - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG > in arago-image.inc > >> to prevent WIC image from adding an additional entry in /etc/fstab. > > This flag is global and will prevent all other partitions from populating > > /etc/fstab properly. Sure, meta-ti only has /boot and / defined, but > other > > layers could have own wic files with e.g. /home or /data partitions. > Mounting > > those will require a custom /etc/fstab instead of wic creating > corresponding > > entries automatically. > > > > > Apparently, this change was being carried in processor sdk layer from > quite a long time (from dunfell) to resolve a customer issue reported by > Andreas. > Diving into our internal JIRA system showed that this fix was suggested > by Andreas > & was resolved by the SDK team back then by keeping this change in > processor sdk layer [1]. > Not sure why this was in processor sdk layer though. Maybe Andreas can > provide additional details. > > Btw, I also see other SOC vendors (meta-freescale) adding > --no-fstab-update flag to WIC_CREATE_EXTRA_ARG [2] > So, if we are planning to pull in this change should it go somewhere in > meta-ti (maybe k3.inc [3])? > > [1]: > > https://git.ti.com/cgit/processor-sdk/meta-processor-sdk/commit/recipes-core/images/tisdk-default-image.bbappend?h=dunfell&id=58975a30e8f90efbffb97e49d5baac02971644da > [2]: > > https://git.yoctoproject.org/meta-freescale/tree/conf/machine/include/imx-base.inc?h=scarthgap#n614 > [3]: > > https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/conf/machine/include/k3.inc?h=scarthgap > > > >> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> > >> --- > >> meta-arago-distro/recipes-core/images/arago-image.inc | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc > b/meta-arago-distro/recipes-core/images/arago-image.inc > >> index 00308b57..2a34a709 100644 > >> --- a/meta-arago-distro/recipes-core/images/arago-image.inc > >> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc > >> @@ -31,4 +31,6 @@ BAD_RECOMMENDATIONS += " \ > >> " > >> BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", > "sysvinit", "", "busybox-syslog", d)}" > >> > >> +WIC_CREATE_EXTRA_ARGS += " --no-fstab-update" > >> + > >> inherit core-image remove-net-rules > >> -- > >> 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15300): > https://lists.yoctoproject.org/g/meta-arago/message/15300 > Mute This Topic: https://lists.yoctoproject.org/mt/105635090/7902621 > Group Owner: meta-arago+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [ > jcormier@criticallink.com] > -=-=-=-=-=-=-=-=-=-=-=- > > >
On Sun, Apr 21, 2024 at 02:42:23PM +0530, Chirag Shilwant wrote: > + Andreas > On 21/04/24 08:37, Denys Dmytriyenko wrote: > >On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: > >>- Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition > >>but currently it lists the contents of /boot partition of the WIC Image. > >> > >>Eg - Incase of AM64x, > >>``` > >> root@am64xx-evm:~# ls /boot/ > >> EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt > >Will this change affect EFI? As there's EFI directory in that partition. > > The EFI partition under /rootfs/boot will still be present. > Following is the output of `ls /boot` with this patch, > > ``` > root@am64xx-evm:~# ls /boot > EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage > fitImage-6.1.80-ti-g2e423244f8c0 > > ``` Thanks, I'll do some additional testing with EFI a bit later. > >>- To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc > >>to prevent WIC image from adding an additional entry in /etc/fstab. > >This flag is global and will prevent all other partitions from populating > >/etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other > >layers could have own wic files with e.g. /home or /data partitions. Mounting > >those will require a custom /etc/fstab instead of wic creating corresponding > >entries automatically. > > > > > Apparently, this change was being carried in processor sdk layer from > quite a long time (from dunfell) to resolve a customer issue > reported by Andreas. > Diving into our internal JIRA system showed that this fix was > suggested by Andreas > & was resolved by the SDK team back then by keeping this change in > processor sdk layer [1]. > Not sure why this was in processor sdk layer though. Maybe Andreas > can provide additional details. I tested and submitted a different fix last night to adjust WIC templates to not mount boot partition under /boot directory[1]. I still believe doing it just for that one partition is better than disabling fstab updates globally. [1] https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/ Can you please take a look and maybe test this option for your use case? Thanks.
Looks good to me. Though i'm curious what the /boot -> boot part does. When we did it we deleted the /boot entirely. Also while we are touching the file. Could add the M to "128" in the non efi file so it matches and is more clear. On Mon, Apr 22, 2024, 12:32 PM Denys Dmytriyenko via lists.yoctoproject.org <denis=denix.org@lists.yoctoproject.org> wrote: > On Sun, Apr 21, 2024 at 02:42:23PM +0530, Chirag Shilwant wrote: > > + Andreas > > On 21/04/24 08:37, Denys Dmytriyenko wrote: > > >On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: > > >>- Ideally running `ls /boot/` in filesystem should list contents from > /rootfs/boot partition > > >>but currently it lists the contents of /boot partition of the WIC > Image. > > >> > > >>Eg - Incase of AM64x, > > >>``` > > >> root@am64xx-evm:~# ls /boot/ > > >> EFI Image tiboot3-am64x-gp-evm.bin > tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin > tispl.bin u-boot.img uEnv.txt > > >Will this change affect EFI? As there's EFI directory in that partition. > > > > The EFI partition under /rootfs/boot will still be present. > > Following is the output of `ls /boot` with this patch, > > > > ``` > > root@am64xx-evm:~# ls /boot > > EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage > > fitImage-6.1.80-ti-g2e423244f8c0 > > > > ``` > > Thanks, I'll do some additional testing with EFI a bit later. > > > > >>- To fix this issue, add --no-fstab-update flag to > WIC_CREATE_EXTRA_ARG in arago-image.inc > > >>to prevent WIC image from adding an additional entry in /etc/fstab. > > >This flag is global and will prevent all other partitions from > populating > > >/etc/fstab properly. Sure, meta-ti only has /boot and / defined, but > other > > >layers could have own wic files with e.g. /home or /data partitions. > Mounting > > >those will require a custom /etc/fstab instead of wic creating > corresponding > > >entries automatically. > > > > > > > > > Apparently, this change was being carried in processor sdk layer from > > quite a long time (from dunfell) to resolve a customer issue > > reported by Andreas. > > Diving into our internal JIRA system showed that this fix was > > suggested by Andreas > > & was resolved by the SDK team back then by keeping this change in > > processor sdk layer [1]. > > Not sure why this was in processor sdk layer though. Maybe Andreas > > can provide additional details. > > I tested and submitted a different fix last night to adjust WIC templates > to > not mount boot partition under /boot directory[1]. I still believe doing > it > just for that one partition is better than disabling fstab updates > globally. > > [1] > https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/ > > Can you please take a look and maybe test this option for your use case? > Thanks. > > -- > Denys > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15302): > https://lists.yoctoproject.org/g/meta-arago/message/15302 > Mute This Topic: https://lists.yoctoproject.org/mt/105635090/7902621 > Group Owner: meta-arago+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [ > jcormier@criticallink.com] > -=-=-=-=-=-=-=-=-=-=-=- > > >
On 4/22/2024 5:32 PM, Denys Dmytriyenko wrote: > On Sun, Apr 21, 2024 at 02:42:23PM +0530, Chirag Shilwant wrote: >> + Andreas >> On 21/04/24 08:37, Denys Dmytriyenko wrote: >>> On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: >>>> - Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition >>>> but currently it lists the contents of /boot partition of the WIC Image. >>>> >>>> Eg - Incase of AM64x, >>>> ``` >>>> root@am64xx-evm:~# ls /boot/ >>>> EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt >>> Will this change affect EFI? As there's EFI directory in that partition. >> >> The EFI partition under /rootfs/boot will still be present. >> Following is the output of `ls /boot` with this patch, >> >> ``` >> root@am64xx-evm:~# ls /boot >> EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage >> fitImage-6.1.80-ti-g2e423244f8c0 >> >> ``` > > Thanks, I'll do some additional testing with EFI a bit later. > > >>>> - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc >>>> to prevent WIC image from adding an additional entry in /etc/fstab. >>> This flag is global and will prevent all other partitions from populating >>> /etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other >>> layers could have own wic files with e.g. /home or /data partitions. Mounting >>> those will require a custom /etc/fstab instead of wic creating corresponding >>> entries automatically. >>> >> >> >> Apparently, this change was being carried in processor sdk layer from >> quite a long time (from dunfell) to resolve a customer issue >> reported by Andreas. >> Diving into our internal JIRA system showed that this fix was >> suggested by Andreas >> & was resolved by the SDK team back then by keeping this change in >> processor sdk layer [1]. >> Not sure why this was in processor sdk layer though. Maybe Andreas >> can provide additional details. > > I tested and submitted a different fix last night to adjust WIC templates to > not mount boot partition under /boot directory[1]. I still believe doing it > just for that one partition is better than disabling fstab updates globally. > > [1] https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/ So with the above referenced patch in meta-ti, I'm assuming we do not need this patch in meta-arago? > Can you please take a look and maybe test this option for your use case? > Thanks. >
On Mon, Apr 22, 2024 at 02:05:46PM -1000, Jon Cormier wrote: > Looks good to me. > > Though i'm curious what the /boot -> boot part does. When we did it we > deleted the /boot entirely. wic --help says: * 'part' or 'partition' This command creates a partition on the system and uses the following syntax: part [<mountpoint>] The <mountpoint> is where the partition will be mounted and must take of one of the following forms: /<path>: For example: /, /usr, or /home swap: The partition will be used as swap space. If a <mountpoint> is not specified the partition will be created but will not be mounted. Partitions with a <mountpoint> specified will be automatically mounted. So, the <mountpoint> part is optional, you can definitely fully omit it. But, I've seen many layers use it as a name, mostly in cases of --source=rawcopy or --source=empty as those don't have a --label parameter. But it behaves the same with --source=bootimg-partition and won't treat it as actual mountpoint when it doesn't start with a / character. It's rather undocumented, but it works. I guess we can also remove it to just follow the docs, since we have label as well to avoid confusion... > Also while we are touching the file. Could add the M to "128" in the non > efi file so it matches and is more clear. I guess I can send a v2 for that...
On Wed, Apr 24, 2024 at 08:32:52AM -0500, Ryan Eatmon wrote: > > > On 4/22/2024 5:32 PM, Denys Dmytriyenko wrote: > >On Sun, Apr 21, 2024 at 02:42:23PM +0530, Chirag Shilwant wrote: > >>+ Andreas > >>On 21/04/24 08:37, Denys Dmytriyenko wrote: > >>>On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: > >>>>- Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition > >>>>but currently it lists the contents of /boot partition of the WIC Image. > >>>> > >>>>Eg - Incase of AM64x, > >>>>``` > >>>> root@am64xx-evm:~# ls /boot/ > >>>> EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt > >>>Will this change affect EFI? As there's EFI directory in that partition. > >> > >>The EFI partition under /rootfs/boot will still be present. > >>Following is the output of `ls /boot` with this patch, > >> > >>``` > >>root@am64xx-evm:~# ls /boot > >>EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage > >>fitImage-6.1.80-ti-g2e423244f8c0 > >> > >>``` > > > >Thanks, I'll do some additional testing with EFI a bit later. > > > > > >>>>- To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc > >>>>to prevent WIC image from adding an additional entry in /etc/fstab. > >>>This flag is global and will prevent all other partitions from populating > >>>/etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other > >>>layers could have own wic files with e.g. /home or /data partitions. Mounting > >>>those will require a custom /etc/fstab instead of wic creating corresponding > >>>entries automatically. > >>> > >> > >> > >>Apparently, this change was being carried in processor sdk layer from > >>quite a long time (from dunfell) to resolve a customer issue > >>reported by Andreas. > >>Diving into our internal JIRA system showed that this fix was > >>suggested by Andreas > >>& was resolved by the SDK team back then by keeping this change in > >>processor sdk layer [1]. > >>Not sure why this was in processor sdk layer though. Maybe Andreas > >>can provide additional details. > > > >I tested and submitted a different fix last night to adjust WIC templates to > >not mount boot partition under /boot directory[1]. I still believe doing it > >just for that one partition is better than disabling fstab updates globally. > > > >[1] https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/ > > So with the above referenced patch in meta-ti, I'm assuming we do > not need this patch in meta-arago? That's my pitch here. Chirag, Will that work for you and others? > >Can you please take a look and maybe test this option for your use case? > >Thanks.
Hi Denys, On 25/04/24 01:40, Denys Dmytriyenko wrote: > On Wed, Apr 24, 2024 at 08:32:52AM -0500, Ryan Eatmon wrote: >> >> On 4/22/2024 5:32 PM, Denys Dmytriyenko wrote: >>> On Sun, Apr 21, 2024 at 02:42:23PM +0530, Chirag Shilwant wrote: >>>> + Andreas >>>> On 21/04/24 08:37, Denys Dmytriyenko wrote: >>>>> On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: >>>>>> - Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition >>>>>> but currently it lists the contents of /boot partition of the WIC Image. >>>>>> >>>>>> Eg - Incase of AM64x, >>>>>> ``` >>>>>> root@am64xx-evm:~# ls /boot/ >>>>>> EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt >>>>> Will this change affect EFI? As there's EFI directory in that partition. >>>> The EFI partition under /rootfs/boot will still be present. >>>> Following is the output of `ls /boot` with this patch, >>>> >>>> ``` >>>> root@am64xx-evm:~# ls /boot >>>> EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage >>>> fitImage-6.1.80-ti-g2e423244f8c0 >>>> >>>> ``` >>> Thanks, I'll do some additional testing with EFI a bit later. >>> >>> >>>>>> - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc >>>>>> to prevent WIC image from adding an additional entry in /etc/fstab. >>>>> This flag is global and will prevent all other partitions from populating >>>>> /etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other >>>>> layers could have own wic files with e.g. /home or /data partitions. Mounting >>>>> those will require a custom /etc/fstab instead of wic creating corresponding >>>>> entries automatically. >>>>> >>>> >>>> Apparently, this change was being carried in processor sdk layer from >>>> quite a long time (from dunfell) to resolve a customer issue >>>> reported by Andreas. >>>> Diving into our internal JIRA system showed that this fix was >>>> suggested by Andreas >>>> & was resolved by the SDK team back then by keeping this change in >>>> processor sdk layer [1]. >>>> Not sure why this was in processor sdk layer though. Maybe Andreas >>>> can provide additional details. >>> I tested and submitted a different fix last night to adjust WIC templates to >>> not mount boot partition under /boot directory[1]. I still believe doing it >>> just for that one partition is better than disabling fstab updates globally. >>> >>> [1] https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/ >> So with the above referenced patch in meta-ti, I'm assuming we do >> not need this patch in meta-arago? > That's my pitch here. > > Chirag, > > Will that work for you and others? Let me kickoff a build with your meta-ti patch [1] & see if that works for us as well. Will get back in a day or two. [1]: https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/ > > >>> Can you please take a look and maybe test this option for your use case? >>> Thanks.
Hi, On 25/04/24 10:32, Chirag Shilwant via lists.yoctoproject.org wrote: > Hi Denys, On 25/04/24 01: 40, Denys Dmytriyenko wrote: > On Wed, Apr > 24, 2024 at 08: 32: 52AM -0500, Ryan Eatmon wrote: >> >> On 4/22/2024 > 5: 32 PM, Denys Dmytriyenko wrote: >>> On Sun, Apr 21, 2024 at > 02: 42: 23PM +0530, > ZjQcmQRYFpfptBannerStart > This message was sent from outside of Texas Instruments. > Do not click links or open attachments unless you recognize the source > of this email and know the content is safe. If you wish to report this > message to IT Security, please forward the message as an attachment to > phishing@list.ti.com > ZjQcmQRYFpfptBannerEnd > Hi Denys, > On 25/04/24 01:40, Denys Dmytriyenko wrote: > > On Wed, Apr 24, 2024 at 08:32:52AM -0500, Ryan Eatmon wrote: > >> > >> On 4/22/2024 5:32 PM, Denys Dmytriyenko wrote: > >>> On Sun, Apr 21, 2024 at 02:42:23PM +0530, Chirag Shilwant wrote: > >>>> + Andreas > >>>> On 21/04/24 08:37, Denys Dmytriyenko wrote: > >>>>> On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: > >>>>>> - Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition > >>>>>> but currently it lists the contents of /boot partition of the WIC Image. > >>>>>> > >>>>>> Eg - Incase of AM64x, > >>>>>> ``` > >>>>>> root@am64xx-evm:~# ls /boot/ > >>>>>> EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt > >>>>> Will this change affect EFI? As there's EFI directory in that partition. > >>>> The EFI partition under /rootfs/boot will still be present. > >>>> Following is the output of `ls /boot` with this patch, > >>>> > >>>> ``` > >>>> root@am64xx-evm:~# ls /boot > >>>> EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage > >>>> fitImage-6.1.80-ti-g2e423244f8c0 > >>>> > >>>> ``` > >>> Thanks, I'll do some additional testing with EFI a bit later. > >>> > >>> > >>>>>> - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc > >>>>>> to prevent WIC image from adding an additional entry in /etc/fstab. > >>>>> This flag is global and will prevent all other partitions from populating > >>>>> /etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other > >>>>> layers could have own wic files with e.g. /home or /data partitions. Mounting > >>>>> those will require a custom /etc/fstab instead of wic creating corresponding > >>>>> entries automatically. > >>>>> > >>>> > >>>> Apparently, this change was being carried in processor sdk layer from > >>>> quite a long time (from dunfell) to resolve a customer issue > >>>> reported by Andreas. > >>>> Diving into our internal JIRA system showed that this fix was > >>>> suggested by Andreas > >>>> & was resolved by the SDK team back then by keeping this change in > >>>> processor sdk layer [1]. > >>>> Not sure why this was in processor sdk layer though. Maybe Andreas > >>>> can provide additional details. > >>> I tested and submitted a different fix last night to adjust WIC templates to > >>> not mount boot partition under /boot directory[1]. I still believe doing it > >>> just for that one partition is better than disabling fstab updates globally. > >>> > >>> [1] https://urldefense.com/v3/__https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/__;!!G3vK!Qwf1x-GVI8r-vE0PXQX0UPdf9Wvl5Dp5bgpXJk3tcBfm8Dae64HW2APer6EWUrW4uAhOK3m7xVvsOm_KrFX_7d-6nDuRMT8M2qlU$ > >> So with the above referenced patch in meta-ti, I'm assuming we do > >> not need this patch in meta-arago? Ryan, We can ignore this patch. Since we have integrated Denys patch in meta-ti, I will go ahead and remove WIC_CREATE_EXTRA_ARG from meta-tisdk as well [1] [1]: https://git.ti.com/cgit/ti-sdk-linux/meta-tisdk/tree/recipes-core/images?h=scarthgap > > That's my pitch here. > > > > Chirag, > > > > Will that work for you and others? > > > Let me kickoff a build with your meta-ti patch [1] & see if that works > for us as well. Denys, As you pitched, it works for us as well. I don't see the boot binaries under /rootfs/boot with your meta-ti patch [1] Running `ls /boot/` in filesystem now lists the following, ``` root@am64xx-evm:~# ls /boot/ EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage fitImage-6.1.80-ti-g2e423244f8c0 ``` [1]: https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/ > Will get back in a day or two. > > [1]: > https://urldefense.com/v3/__https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/__;!!G3vK!Qwf1x-GVI8r-vE0PXQX0UPdf9Wvl5Dp5bgpXJk3tcBfm8Dae64HW2APer6EWUrW4uAhOK3m7xVvsOm_KrFX_7d-6nDuRMT8M2qlU$ > > > > > > > >>> Can you please take a look and maybe test this option for your use case? > >>> Thanks. > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15310):https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-arago/message/15310__;!!G3vK!Qwf1x-GVI8r-vE0PXQX0UPdf9Wvl5Dp5bgpXJk3tcBfm8Dae64HW2APer6EWUrW4uAhOK3m7xVvsOm_KrFX_7d-6nDuRMaDJiVhR$ > Mute This Topic:https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/105635090/7030289__;!!G3vK!Qwf1x-GVI8r-vE0PXQX0UPdf9Wvl5Dp5bgpXJk3tcBfm8Dae64HW2APer6EWUrW4uAhOK3m7xVvsOm_KrFX_7d-6nDuRMfG91eNy$ > Group Owner: meta-arago+owner@lists.yoctoproject.org > Unsubscribe:https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-arago/unsub__;!!G3vK!Qwf1x-GVI8r-vE0PXQX0UPdf9Wvl5Dp5bgpXJk3tcBfm8Dae64HW2APer6EWUrW4uAhOK3m7xVvsOm_KrFX_7d-6nDuRMT03j9XI$ [c-shilwant@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc index 00308b57..2a34a709 100644 --- a/meta-arago-distro/recipes-core/images/arago-image.inc +++ b/meta-arago-distro/recipes-core/images/arago-image.inc @@ -31,4 +31,6 @@ BAD_RECOMMENDATIONS += " \ " BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", "busybox-syslog", d)}" +WIC_CREATE_EXTRA_ARGS += " --no-fstab-update" + inherit core-image remove-net-rules
- Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition but currently it lists the contents of /boot partition of the WIC Image. Eg - Incase of AM64x, ``` root@am64xx-evm:~# ls /boot/ EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt ``` - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc to prevent WIC image from adding an additional entry in /etc/fstab. Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> --- meta-arago-distro/recipes-core/images/arago-image.inc | 2 ++ 1 file changed, 2 insertions(+)