[meta-arago,master/kirkstone,v2,2/2] gstreamer1.0-plugins-good: Add patch to increase min buffers for CSI capture

This is required to avoid the frame drops and increase the tolrence
for CSI capture using gsteamer

Signed-off-by: Rahul T R <r-ravikumar@ti.com>
---
 ...ct-Increase-min-buffers-for-CSI-capt.patch | 32 +++++++++++++++++++
 .../gstreamer1.0-plugins-good_1.20.%.bbappend |  3 +-
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch

On 23/01/24 21:23, Rahul T R wrote:
> This is required to avoid the frame drops and increase the tolrence
> for CSI capture using gsteamer
> 
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>

Reviewed-by: Devarsh Thakkar <devarsht@ti.com>

> ---
>  ...ct-Increase-min-buffers-for-CSI-capt.patch | 32 +++++++++++++++++++
>  .../gstreamer1.0-plugins-good_1.20.%.bbappend |  3 +-
>  2 files changed, 34 insertions(+), 1 deletion(-)
>  create mode 100644 meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
> 
> diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
> new file mode 100644
> index 00000000..cd3ff613
> --- /dev/null
> +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
> @@ -0,0 +1,32 @@
> +From a314ac52a306f8ddde1b53321b8cba5e35f5fa72 Mon Sep 17 00:00:00 2001
> +From: Rahul T R <r-ravikumar@ti.com>
> +Date: Tue, 10 Oct 2023 14:42:13 +0530
> +Subject: [PATCH] HACK: gstv4l2object: Increase min buffers for CSI capture
> +
> +With default min buffers, frame drops are observed with CSI capture
> +pipeline with VISS, LDC and DSS with DMABuf Import mode
> +
> +Increasing min buffers queued in v4l2src seems to fix this issue.
> +Need more amalysis on the exact root cause
> +
> +Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> +---
> + sys/v4l2/gstv4l2object.c | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c
> +index 4ce9fac..9f5a85b 100644
> +--- a/sys/v4l2/gstv4l2object.c
> ++++ b/sys/v4l2/gstv4l2object.c
> +@@ -5172,6 +5172,8 @@ gst_v4l2_object_decide_allocation (GstV4l2Object * obj, GstQuery * query)
> +      * pool, we'll need what the driver one, and one more, so we can dequeu */
> +     if (0 == strcmp(obj->vcap.driver, "wave5-dec")) {
> +         own_min = obj->min_buffers + 3;
> ++    } else if (0 == strcmp(obj->vcap.driver, "j721e-csi2rx")) {
> ++        own_min = obj->min_buffers + 4;
> +     } else {
> +         own_min = obj->min_buffers + 1;
> +     }
> +-- 
> +2.34.1
> +
> diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
> index 2a1a6e68..782b54a4 100644
> --- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
> +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
> @@ -5,6 +5,7 @@ SRC_URI:append = " \
>      file://0002-Adding-support-for-bayer-formats-with-IR-component.patch \
>      file://0003-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \
>      file://0004-v4l2-Give-preference-to-contiguous-format-if-support.patch \
> +    file://0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch \
>  "
>  
> -PR:append = ".arago1"
> +PR:append = ".arago2"

On 1/23/2024 9:53 AM, Rahul T R wrote:
> This is required to avoid the frame drops and increase the tolrence
> for CSI capture using gsteamer
> 
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
>   ...ct-Increase-min-buffers-for-CSI-capt.patch | 32 +++++++++++++++++++
>   .../gstreamer1.0-plugins-good_1.20.%.bbappend |  3 +-
>   2 files changed, 34 insertions(+), 1 deletion(-)
>   create mode 100644 meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
> 
> diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
> new file mode 100644
> index 00000000..cd3ff613
> --- /dev/null
> +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
> @@ -0,0 +1,32 @@
> +From a314ac52a306f8ddde1b53321b8cba5e35f5fa72 Mon Sep 17 00:00:00 2001
> +From: Rahul T R <r-ravikumar@ti.com>
> +Date: Tue, 10 Oct 2023 14:42:13 +0530
> +Subject: [PATCH] HACK: gstv4l2object: Increase min buffers for CSI capture
> +
> +With default min buffers, frame drops are observed with CSI capture
> +pipeline with VISS, LDC and DSS with DMABuf Import mode
> +
> +Increasing min buffers queued in v4l2src seems to fix this issue.
> +Need more amalysis on the exact root cause
> +

NAK.  This patch file is missing an Upstream-Status entry.  There are 
now QA checks in master that require that to be present for long term 
auditing purposes.  More info can be found at:

https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status

Please fix and send a v3.



> +Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> +---
> + sys/v4l2/gstv4l2object.c | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c
> +index 4ce9fac..9f5a85b 100644
> +--- a/sys/v4l2/gstv4l2object.c
> ++++ b/sys/v4l2/gstv4l2object.c
> +@@ -5172,6 +5172,8 @@ gst_v4l2_object_decide_allocation (GstV4l2Object * obj, GstQuery * query)
> +      * pool, we'll need what the driver one, and one more, so we can dequeu */
> +     if (0 == strcmp(obj->vcap.driver, "wave5-dec")) {
> +         own_min = obj->min_buffers + 3;
> ++    } else if (0 == strcmp(obj->vcap.driver, "j721e-csi2rx")) {
> ++        own_min = obj->min_buffers + 4;
> +     } else {
> +         own_min = obj->min_buffers + 1;
> +     }
> +--
> +2.34.1
> +
> diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
> index 2a1a6e68..782b54a4 100644
> --- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
> +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
> @@ -5,6 +5,7 @@ SRC_URI:append = " \
>       file://0002-Adding-support-for-bayer-formats-with-IR-component.patch \
>       file://0003-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \
>       file://0004-v4l2-Give-preference-to-contiguous-format-if-support.patch \
> +    file://0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch \
>   "
>   
> -PR:append = ".arago1"
> +PR:append = ".arago2"