| Message ID | 20231206143618.27770-3-sinthu.raja@ti.com |
|---|---|
| State | RFC |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | Add gstreamer 1.20 | expand |
On 12/6/2023 8:36 AM, Sinthu Raja M via lists.yoctoproject.org wrote: > From: Sinthu Raja <sinthu.raja@ti.com> > > The Ducati and VPE gst plugins requires network during the do_configure task > so, enable the network task flag for the same. Why does it require network? Can you elaborate a little more? > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com> > --- > .../gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb | 2 ++ > .../gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb > index 1ff2dfb0..99a5615c 100644 > --- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb > +++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb > @@ -18,4 +18,6 @@ SRC_URI = " \ > file://0001-gstducati-configure.ac-stop-using-export-symbols-reg.patch \ > " > > +do_configure[network] = "1" > + > FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" > diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb > index 237031b1..25d4d9c2 100644 > --- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb > +++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb > @@ -15,3 +15,5 @@ SRCREV = "b9dba5a8bc7d14d55125abdce04672e3dc30bbdf" > SRC_URI = "git://git.ti.com/git/glsdk/gst-plugin-vpe.git;protocol=https \ > file://0001-gstvpe-configure.ac-stop-using-export-symbols-regex.patch \ > " > + > +do_configure[network] = "1"
On Wed, Dec 06, 2023 at 09:33:31AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote: > > > On 12/6/2023 8:36 AM, Sinthu Raja M via lists.yoctoproject.org wrote: > >From: Sinthu Raja <sinthu.raja@ti.com> > > > >The Ducati and VPE gst plugins requires network during the do_configure task > >so, enable the network task flag for the same. > > Why does it require network? Can you elaborate a little more? Because sources in git didn't have common gstreamer-specific autotools files, scripts and supporting stuff, which were pulled and setup as a "common" git submodule from here: git://anongit.freedesktop.org/gstreamer/common https://cgit.freedesktop.org/gstreamer/common/ That is done by autogen.sh in do_configure(): https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ti.inc https://git.ti.com/cgit/glsdk/gst-plugin-ducati/tree/autogen.sh That's also been the case for git versions of the upstream gstreamer and plugins years ago. So, autogen.sh had to be called after do_unpack() and before do_configure(), but the former is a python function. Released versions of gstreamer and plugins never had this issue, as they come with all required pieces already packaged in a tarball. All git-versioned recipes for gstreamer and plugins were removed from OE-Core almost 7 years ago: https://git.openembedded.org/openembedded-core/commit/?id=2b15451e3f1b9fb9a7f44317f3f9cd22d8712ff5 Moreover, gstreamer builds have migrated from autotools to meson around the same time and this "common" submodule/tree hasn't been used or updated for quite some time. Unfortunaly, gst-plugins-ti haven't been touched for 5 years and still use the old (ancient) "common" submodule for autotools stuff... So, proper, but most involved solution would be to migrate gst-plugins-ti to use meson. Otherwise, you can add the "common" tree to SRC_URI and set the corresponding SRCREV. That should satisfy git submodule update, but may need extra tweaking. SRC_URI += "git://anongit.freedesktop.org/gstreamer/common;destsuffix=git/common;name=common" SRCREV_common = "011bcc8a0fc7f798ee874a7ba899123fb2470e22" BTW, this commit ^^^ that is used for "common" submodule in gst-plugins-ti is 13 years old and dated 2010-10-27!!! > >Signed-off-by: Sinthu Raja <sinthu.raja@ti.com> > >--- > > .../gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb | 2 ++ > > .../gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb | 2 ++ > > 2 files changed, 4 insertions(+) > > > >diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb > >index 1ff2dfb0..99a5615c 100644 > >--- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb > >+++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb > >@@ -18,4 +18,6 @@ SRC_URI = " \ > > file://0001-gstducati-configure.ac-stop-using-export-symbols-reg.patch \ > > " > >+do_configure[network] = "1" > >+ > > FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" > >diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb > >index 237031b1..25d4d9c2 100644 > >--- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb > >+++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb > >@@ -15,3 +15,5 @@ SRCREV = "b9dba5a8bc7d14d55125abdce04672e3dc30bbdf" > > SRC_URI = "git://git.ti.com/git/glsdk/gst-plugin-vpe.git;protocol=https \ > > file://0001-gstvpe-configure.ac-stop-using-export-symbols-regex.patch \ > > " > >+ > >+do_configure[network] = "1"
On 12/6/2023 4:38 PM, Denys Dmytriyenko wrote: > On Wed, Dec 06, 2023 at 09:33:31AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote: >> >> >> On 12/6/2023 8:36 AM, Sinthu Raja M via lists.yoctoproject.org wrote: >>> From: Sinthu Raja <sinthu.raja@ti.com> >>> >>> The Ducati and VPE gst plugins requires network during the do_configure task >>> so, enable the network task flag for the same. >> >> Why does it require network? Can you elaborate a little more? > > Because sources in git didn't have common gstreamer-specific autotools > files, scripts and supporting stuff, which were pulled and setup as a > "common" git submodule from here: > git://anongit.freedesktop.org/gstreamer/common > https://cgit.freedesktop.org/gstreamer/common/ > > That is done by autogen.sh in do_configure(): > https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ti.inc > https://git.ti.com/cgit/glsdk/gst-plugin-ducati/tree/autogen.sh > > That's also been the case for git versions of the upstream gstreamer and > plugins years ago. So, autogen.sh had to be called after do_unpack() and > before do_configure(), but the former is a python function. > > Released versions of gstreamer and plugins never had this issue, as they > come with all required pieces already packaged in a tarball. > > All git-versioned recipes for gstreamer and plugins were removed from > OE-Core almost 7 years ago: > https://git.openembedded.org/openembedded-core/commit/?id=2b15451e3f1b9fb9a7f44317f3f9cd22d8712ff5 > > Moreover, gstreamer builds have migrated from autotools to meson around the > same time and this "common" submodule/tree hasn't been used or updated for > quite some time. Unfortunaly, gst-plugins-ti haven't been touched for 5 years > and still use the old (ancient) "common" submodule for autotools stuff... > > So, proper, but most involved solution would be to migrate gst-plugins-ti to > use meson. > > Otherwise, you can add the "common" tree to SRC_URI and set the corresponding > SRCREV. That should satisfy git submodule update, but may need extra tweaking. > > SRC_URI += "git://anongit.freedesktop.org/gstreamer/common;destsuffix=git/common;name=common" > SRCREV_common = "011bcc8a0fc7f798ee874a7ba899123fb2470e22" This is exactly what I was hoping to hear. That it there was the possibility of condensing the network stuff into the SRC_URI to be a little more yocto compliant. I agree that long term all of the stuff should be moved to meson like the main gstreamer. > BTW, this commit ^^^ that is used for "common" submodule in gst-plugins-ti > is 13 years old and dated 2010-10-27!!! > > >>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com> >>> --- >>> .../gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb | 2 ++ >>> .../gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb | 2 ++ >>> 2 files changed, 4 insertions(+) >>> >>> diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb >>> index 1ff2dfb0..99a5615c 100644 >>> --- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb >>> +++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb >>> @@ -18,4 +18,6 @@ SRC_URI = " \ >>> file://0001-gstducati-configure.ac-stop-using-export-symbols-reg.patch \ >>> " >>> +do_configure[network] = "1" >>> + >>> FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" >>> diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb >>> index 237031b1..25d4d9c2 100644 >>> --- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb >>> +++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb >>> @@ -15,3 +15,5 @@ SRCREV = "b9dba5a8bc7d14d55125abdce04672e3dc30bbdf" >>> SRC_URI = "git://git.ti.com/git/glsdk/gst-plugin-vpe.git;protocol=https \ >>> file://0001-gstvpe-configure.ac-stop-using-export-symbols-regex.patch \ >>> " >>> + >>> +do_configure[network] = "1"
diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb index 1ff2dfb0..99a5615c 100644 --- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb +++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb @@ -18,4 +18,6 @@ SRC_URI = " \ file://0001-gstducati-configure.ac-stop-using-export-symbols-reg.patch \ " +do_configure[network] = "1" + FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb index 237031b1..25d4d9c2 100644 --- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb +++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb @@ -15,3 +15,5 @@ SRCREV = "b9dba5a8bc7d14d55125abdce04672e3dc30bbdf" SRC_URI = "git://git.ti.com/git/glsdk/gst-plugin-vpe.git;protocol=https \ file://0001-gstvpe-configure.ac-stop-using-export-symbols-regex.patch \ " + +do_configure[network] = "1"