[meta-arago,kirkstone] tisdk-default-image: Add Matrix GUI only for legacy platforms

Today, only ti33x and ti43x family platforms ship matrix-gui in the SDK.
It is removed for all other platforms in SDK layers. So add it only for
required platforms.

Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
---
 .../recipes-core/images/tisdk-default-image.bb       | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

On Thu, Oct 19, 2023 at 10:40:56AM +0530, Sai Sree Kartheek Adivi wrote:
> Today, only ti33x and ti43x family platforms ship matrix-gui in the SDK.
> It is removed for all other platforms in SDK layers. So add it only for
> required platforms.
> 
> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
> ---
>  .../recipes-core/images/tisdk-default-image.bb       | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> index 787fac95..2c7b2f0c 100644
> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> @@ -24,8 +24,6 @@ IMAGE_INSTALL += "\
>      ${@['','packagegroup-arago-tisdk-opencl'][oe.utils.all_distro_features(d, 'opencl', True, False) and bb.utils.contains('MACHINE_FEATURES', 'dsp', True, False, d)]} \
>      packagegroup-arago-tisdk-connectivity \
>      packagegroup-arago-tisdk-crypto \
> -    packagegroup-arago-tisdk-matrix \
> -    packagegroup-arago-tisdk-matrix-extra \
>      packagegroup-arago-tisdk-multimedia \
>      packagegroup-arago-tisdk-addons \
>      packagegroup-arago-tisdk-addons-extra \
> @@ -36,6 +34,16 @@ IMAGE_INSTALL += "\
>      packagegroup-arago-tisdk-sysrepo \
>  "
>  
> +IMAGE_INSTALL:append:ti33x = " \
> +    packagegroup-arago-tisdk-matrix \
> +    packagegroup-arago-tisdk-matrix-extra \
> +"
> +
> +IMAGE_INSTALL:append:ti43x = " \
> +    packagegroup-arago-tisdk-matrix \
> +    packagegroup-arago-tisdk-matrix-extra \
> +"

Instead of appending directly to IMAGE_INSTALL, it's better to use an indirect 
variable. Take a look how it's done with CHROMIUM variable in the same recipe.


>  export IMAGE_BASENAME = "tisdk-default-image"
>  
>  # Disable ubi/ubifs as the filesystem requires more space than is
> -- 
> 2.34.1

On 10/19/2023 12:42 AM, Denys Dmytriyenko wrote:
> On Thu, Oct 19, 2023 at 10:40:56AM +0530, Sai Sree Kartheek Adivi wrote:
>> Today, only ti33x and ti43x family platforms ship matrix-gui in the SDK.
>> It is removed for all other platforms in SDK layers. So add it only for
>> required platforms.
>>
>> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
>> ---
>>   .../recipes-core/images/tisdk-default-image.bb       | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>> index 787fac95..2c7b2f0c 100644
>> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>> @@ -24,8 +24,6 @@ IMAGE_INSTALL += "\
>>       ${@['','packagegroup-arago-tisdk-opencl'][oe.utils.all_distro_features(d, 'opencl', True, False) and bb.utils.contains('MACHINE_FEATURES', 'dsp', True, False, d)]} \
>>       packagegroup-arago-tisdk-connectivity \
>>       packagegroup-arago-tisdk-crypto \
>> -    packagegroup-arago-tisdk-matrix \
>> -    packagegroup-arago-tisdk-matrix-extra \
>>       packagegroup-arago-tisdk-multimedia \
>>       packagegroup-arago-tisdk-addons \
>>       packagegroup-arago-tisdk-addons-extra \
>> @@ -36,6 +34,16 @@ IMAGE_INSTALL += "\
>>       packagegroup-arago-tisdk-sysrepo \
>>   "
>>   
>> +IMAGE_INSTALL:append:ti33x = " \
>> +    packagegroup-arago-tisdk-matrix \
>> +    packagegroup-arago-tisdk-matrix-extra \
>> +"
>> +
>> +IMAGE_INSTALL:append:ti43x = " \
>> +    packagegroup-arago-tisdk-matrix \
>> +    packagegroup-arago-tisdk-matrix-extra \
>> +"
> 
> Instead of appending directly to IMAGE_INSTALL, it's better to use an indirect
> variable. Take a look how it's done with CHROMIUM variable in the same recipe.

Agreed.

> 
>>   export IMAGE_BASENAME = "tisdk-default-image"
>>   
>>   # Disable ubi/ubifs as the filesystem requires more space than is
>> -- 
>> 2.34.1