diff mbox series

[meta-arago,kirkstone/master,5/5] arago-tiny-image: add packagegroup-arago-boot to IMAGE_INSTALL

Message ID 20230728002032.853330-6-rs@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series Packagegroup cleaning and a new proposal | expand

Commit Message

Randolph Sapp July 28, 2023, 12:20 a.m. UTC
From: Randolph Sapp <rs@ti.com>

This image install override is interesting. Perhaps we should move to
the separate build target distro configs like pokey uses [1] to avoid
configuration collisions while still allowing for some base image
templating through include files like arago-image.inc

[1] https://git.yoctoproject.org/poky/tree/meta-poky/conf/distro/poky-tiny.conf?h=kirkstone

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 meta-arago-distro/recipes-core/images/arago-tiny-image.inc | 1 +
 1 file changed, 1 insertion(+)

Comments

Denys Dmytriyenko July 28, 2023, 9:20 p.m. UTC | #1
On Thu, Jul 27, 2023 at 07:20:32PM -0500, Randolph Sapp via lists.yoctoproject.org wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> This image install override is interesting. Perhaps we should move to
> the separate build target distro configs like pokey uses [1] to avoid

What's "pokey"? It's Poky - https://elinux.org/Poky


> configuration collisions while still allowing for some base image
> templating through include files like arago-image.inc
> 
> [1] https://git.yoctoproject.org/poky/tree/meta-poky/conf/distro/poky-tiny.conf?h=kirkstone

Either way, the above commit log doesn't seem to have anything to do with the 
actual change...


> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
>  meta-arago-distro/recipes-core/images/arago-tiny-image.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-arago-distro/recipes-core/images/arago-tiny-image.inc b/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
> index 242e763c..77ee9ea2 100644
> --- a/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
> +++ b/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
> @@ -6,4 +6,5 @@ IMAGE_FEATURES:remove = "splash"
>  
>  IMAGE_INSTALL = " \
>  	packagegroup-arago-sysvinit-boot \
> +	packagegroup-arago-boot \

This include file is shared among tiny and bootstrap images. While addind 
irqbalance and/or other tools might be useful for bootstrapping (?) it is not 
so clear for the tiny image. It was meant to be the very bare minimum and also 
used as initramfs and jailhouse cells.
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-core/images/arago-tiny-image.inc b/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
index 242e763c..77ee9ea2 100644
--- a/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
+++ b/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
@@ -6,4 +6,5 @@  IMAGE_FEATURES:remove = "splash"
 
 IMAGE_INSTALL = " \
 	packagegroup-arago-sysvinit-boot \
+	packagegroup-arago-boot \
 "